commit 349c389ef1d68eefa0e5aa1ab61458c63d18e630 Author: Steve Youngs Date: Tue Jan 31 12:31:43 2012 +1000 Fix build on OpenIndiana "Fix" is probably too strong a word here, it wasn't really broken in the first place. Just a tiny tweak to autogen.sh was the only "fix" needed here. This changeset also documents (in PROBLEMS) the missing deps needed to build SXEmacs on OpenIndiana. * autogen.sh: Only add the xpg4/bin directory to the $PATH if this isn't OpenIndiana. * PROBLEMS: Document build quirks for OpenIndiana. Signed-off-by: Steve Youngs :100644 100644 24cda27... 0e7e449... M PROBLEMS :100755 100755 a3690c1... 4b2ee13... M autogen.sh commit fef249060579771eb4f43bfb4cd7ebe827c6a633 Author: Steve Youngs Date: Sat Jan 28 17:41:50 2012 +1000 Whitespace cleanup in src [m-z] Signed-off-by: Steve Youngs :100644 100644 db4f1c7... b5b0372... M src/map.c :100644 100644 5b5b456... b57816d... M src/map.h :100644 100644 4a8262b... 8824bfe... M src/md5.c :100644 100644 b9e023f... 80a4219... M src/objects.c :100644 100644 80f6472... 70459a5... M src/opaque.c :100644 100644 6c59082... f87f7aa... M src/openssl.c :100644 100644 e8402a6... acc1c69... M src/openssl.h :100644 100644 5ce5549... 47c5f48... M src/print.c :100644 100644 f122cc5... b3e00db... M src/process-unix.c :100644 100644 cb5b035... 1a64736... M src/process.c :100644 100644 0e5b1c6... 9d987ba... M src/process.h :100644 100644 fbbb461... 8cb153c... M src/procimpl.h :100644 100644 6eadb54... 9d7ad46... M src/rangetab.c :100644 100644 6fc583d... 1ccfd70... M src/realpath.c :100644 100644 7d2e40f... 8cb04ee... M src/regex.c :100644 100644 872c973... e4faf29... M src/regex.h :100644 100644 52271ce... 2c1e019... M src/search.c :100644 100644 4cc90da... 817c66b... M src/semaphore.c :100644 100644 81989d6... d4d8d9e... M src/semaphore.h :100644 100644 f38a13f... 092b627... M src/seq.c :100644 100644 c3a8d73... b302bd9... M src/seq.h :100644 100644 25f9508... 9f21ce7... M src/skiplist.c :100644 100644 3f48dfa... e6d20bf... M src/skiplist.h :100644 100644 1ecf13d... 3969a72... M src/specifier.h :100644 100644 3e9b9f6... cdc8c7f... M src/strcat.c :100644 100644 95e88eb... 39ca53e... M src/strcmp.c :100644 100644 5cc99eb... f19a4aa... M src/strcpy.c :100644 100644 94185ca... 3ebe4d6... M src/sunOS-fix.c :100644 100644 e30034f... 7f6bfe0... M src/sxe-utils.h :100644 100644 fff6d46... a7d9f5e... M src/symbols.c :100644 100644 d8f7968... 4fbe814... M src/syntax.c :100644 100644 6a63904... fe79780... M src/syntax.h :100644 100644 e4844df... 7d0536b... M src/sysdep.c :100644 100644 65d70c4... c506d26... M src/sysdep.h :100644 100644 86e4cf1... 254252f... M src/sysfile.h :100644 100644 53f78dc... 265b55e... M src/syspwd.h :100644 100644 6e7f941... 708953c... M src/systime.h commit 90cc8d398a07c66e6bbe151961a2e73697dfacd1 Author: Steve Youngs Date: Sat Jan 28 17:27:57 2012 +1000 Whitespace cleanup in src [f-l] Signed-off-by: Steve Youngs :100644 100644 63b1959... 5595770... M src/fileio.c :100644 100644 f353f13... 957236e... M src/filelock.c :100644 100644 ed1884b... 7a332a4... M src/fns.c :100644 100644 fefb2a4... 315fd7b... M src/gdbinit :100644 100644 d4c6a13... 6b514fe... M src/getloadavg.c :100644 100644 87b6c66... af41561... M src/hftctl.c :100644 100644 d0c303b... ec802b2... M src/indent.c :100644 100644 ce6d3ad... 1c6d095... M src/libsst.c :100644 100644 4dd1be5... 2525d62... M src/lisp-disunion.h :100644 100644 e41c4c8... a858a9e... M src/lisp.h :100644 100644 2642141... 4354541... M src/lread.c :100644 100644 b909267... 0642434... M src/lrecord.h :100644 100644 eb7196d... 21214e0... M src/lstream.c :100644 100644 72f0718... a34e12b... M src/lstream.h commit c3a11ea4b0d1bceb3381a0f2bc76ee0387339656 Author: Steve Youngs Date: Sat Jan 28 17:22:02 2012 +1000 Whitespace cleanup in src [a-e] Signed-off-by: Steve Youngs :100644 100644 9aab242... 947e78f... M src/Makefile.am :100644 100644 6f33710... e5e4c21... M src/alloc.c :100644 100644 da5b67a... 385cf75... M src/alloca.s :100644 100644 8af50fe... 57c1dab... M src/backtrace.h :100644 100644 4b19c50... 75347e4... M src/bloom.c :100644 100644 adc63d7... 037de16... M src/broken-sun.h :100644 100644 5a8fd89... a6ad0e8... M src/buffer.c :100644 100644 0492730... 4e8b770... M src/buffer.h :100644 100644 a38cc83... 9d71d65... M src/callproc.c :100644 100644 5ad354b... cf054ae... M src/category.c :100644 100644 ca9224d... bb21c57... M src/category.h :100644 100644 8e9267e... 71d757a... M src/chartab.c :100644 100644 8518476... bcac4f5... M src/data.c :100644 100644 3eb0fa5... 82e408b... M src/debug.c :100644 100644 61bcfd2... b0a5258... M src/debug.h :100644 100644 84ee6ad... 1e3dd4f... M src/dict.c :100644 100644 475d3c1... e7d1159... M src/dict.h :100644 100644 e957a22... fd942a5... M src/dired.c :100644 100644 438ea31... 4f911bc... M src/dllist.c :100644 100644 3d0fb83... 1ebb10d... M src/doc.c :100644 100644 8076a6b... 0924fd3... M src/doprnt.c :100644 100644 6555451... 2f6742b... M src/dumper.c :100644 100644 ab5c4f0... 36f78fe... M src/dynacat.c :100644 100644 55bff0e... 8e1307a... M src/dynacat.h :100644 100644 620c2d1... acf8ae7... M src/dynarr.c :100644 100644 d4c6db9... 04e5f7b... M src/ecrt0.c :100644 100644 a32f51b... 4e52585... M src/editfns.c :100644 100644 8859a04... 761b295... M src/effi.c :100644 100644 1b734a0... 600c368... M src/effi.h :100644 100644 fbd4f77... 0b4b387... M src/elhash.c :100644 100644 3ac6f2e... 4375c06... M src/emacs.c :100644 100644 99c646d... 5bd1f9c... M src/emodules-ng.c :100644 100644 a8ef87e... 29b6409... M src/emodules-ng.h :100644 100644 f9efb21... e92bf4c... M src/eval.c :100644 100644 7cdfed7... 58a1284... M src/extents.c :100644 100644 097c96f... ba36c74... M src/extw-Xt.c commit 78dd9663a9a07a0572e1e286dfea557c6f5be826 Author: Steve Youngs Date: Sat Jan 28 17:08:21 2012 +1000 Whitespace cleanup in src/database Signed-off-by: Steve Youngs :100644 100644 a05809a... d3154c7... M src/database/Makefile.am :100644 100644 d1174d3... e291387... M src/database/database.c :100644 100644 8870e49... 283e9dd... M src/database/eldap.h :100644 100644 d125335... 422ef45... M src/database/postgresql.c commit 51b9dd462d23dd8dcc7eeebfc434842c31813314 Author: Steve Youngs Date: Sat Jan 28 17:06:29 2012 +1000 Whitespace cleanup in src/ent Signed-off-by: Steve Youngs :100644 100644 299b8aa... e9f84d9... M src/ent/Makefile.am :100644 100644 f7869ff... a7f82d4... M src/ent/ent-binary-op.c :100644 100644 869ad75... 40f2a2a... M src/ent/ent-binary-op.h :100644 100644 e656657... c7c1590... M src/ent/ent-binary-rel.c :100644 100644 92c2123... 686d6e7... M src/ent/ent-binary-rel.h :100644 100644 4345ba7... 79e458e... M src/ent/ent-float.c :100644 100644 ea8e8ef... 61fd433... M src/ent/ent-gaussian.c :100644 100644 d8b9eda... 585f1e6... M src/ent/ent-gmp.c :100644 100644 ea9ee99... e91c125... M src/ent/ent-indef.c :100644 100644 1177d3e... 0a8be61... M src/ent/ent-indef.h :100644 100644 10e9350... 95d801b... M src/ent/ent-inf.h :100644 100644 276c165... 0b687eb... M src/ent/ent-lift.c :100644 100644 52cff71... 4057b81... M src/ent/ent-lift.h :100644 100644 768bd0c... c15da06... M src/ent/ent-mpc.c :100644 100644 042bd18... aafed6b... M src/ent/ent-mpfr.c :100644 100644 f062908... cba303e... M src/ent/ent-nullary-op.c :100644 100644 37153a7... a8cda85... M src/ent/ent-nullary-op.h :100644 100644 23ec886... 3c8e550... M src/ent/ent-optable.h :100644 100644 5778e79... ef7b8c9... M src/ent/ent-pseumpc.c :100644 100644 dd39442... cc728d9... M src/ent/ent-pseumpc.h :100644 100644 01e2271... 66469fc... M src/ent/ent-quatern.c :100644 100644 c19edcd... 855c1ca... M src/ent/ent-strflt.h :100644 100644 f32e084... 23c2e48... M src/ent/ent-unary-op.c :100644 100644 41d10fd... d08c44f... M src/ent/ent-unary-op.h :100644 100644 5312546... 59c8d1b... M src/ent/ent-unary-rel.c :100644 100644 6a4ca72... f49fcd5... M src/ent/ent-unary-rel.h :100644 100644 d9df318... 4d48bc9... M src/ent/ent.c :100644 100644 c74fc98... 03802ad... M src/ent/ent.h :100644 100644 8badb26... 0882857... M src/ent/floatfns.c commit 1b7a96138033cb621be9516c3d6bca7b567da1fc Author: Steve Youngs Date: Sat Jan 28 16:59:05 2012 +1000 Whitespace cleanup in src/events Signed-off-by: Steve Youngs :100644 100644 e483e37... 9bd6684... M src/events/Makefile.am :100644 100644 ad2bde2... 7549ed3... M src/events/event-queue.c :100644 100644 66a83e2... 068754b... M src/events/event-queue.h :100644 100644 687ef18... 11c9a76... M src/events/event-stream.c :100644 100644 bb9a72f... d877a65... M src/events/event-unixoid.c :100644 100644 40a6b19... 727f37e... M src/events/events.c :100644 100644 87331da... 6274240... M src/events/events.h :100644 100644 53fb356... 6f79ec1... M src/events/worker-asyneq.c :100644 100644 38da7cf... c6ab0f5... M src/events/worker-asyneq.h :100644 100644 570a241... 3f96c5f... M src/events/workers.c :100644 100644 c05e144... b65ce50... M src/events/workers.h commit 81369204cbeace21f3f3677ae5e3962cd3a7f4f3 Author: Steve Youngs Date: Sat Jan 28 16:54:49 2012 +1000 Whitespace cleanup in src/m Signed-off-by: Steve Youngs :100644 100644 8cf7df7... 4d8b781... M src/m/arm.h :100644 100644 d4e4ae7... cb302c0... M src/m/cydra5.h :100644 100644 564df07... ec47324... M src/m/elxsi.h :100644 100644 991540f... 6a759b8... M src/m/gec63.h :100644 100644 ec8ef6c... de6c775... M src/m/hp300bsd.h :100644 100644 5de8d01... 9edcd04... M src/m/hp800.h :100644 100644 cb4f794... 53adead... M src/m/hp9000s300.h :100644 100644 e2904a8... 2b05ef7... M src/m/i860.h :100644 100644 003d190... a7666ea... M src/m/intel386.h :100644 100644 5eb06f6... 12fa597... M src/m/luna88k.h :100644 100644 68e468e... d503e03... M src/m/news-risc.h :100644 100644 2716f5c... 45b0ab9... M src/m/news.h :100644 100644 1a70e76... b5ab106... M src/m/next.h :100644 100644 637cb9b... 74a8e09... M src/m/pmax.h :100644 100644 d21ea18... 5327531... M src/m/powerpc.h :100644 100644 09e9675... f9308ea... M src/m/sgi-challenge.h :100644 100644 48793f8... b531a77... M src/m/sparc.h :100644 100644 4c7cb4c... d5a0073... M src/m/sun1.h :100644 100644 0cfb579... d2e175f... M src/m/sun2.h :100644 100644 0c992a5... 19b0caf... M src/m/sun3-68881.h :100644 100644 8496bfd... b918706... M src/m/sun3-fpa.h :100644 100644 565fc35... 2025b21... M src/m/sun3-soft.h :100644 100644 b997888... 13439ca... M src/m/sun3.h :100644 100644 e65bcd3... ecf2d48... M src/m/sun386.h :100644 100644 2a02bc2... 9744bea... M src/m/template.h :100644 100644 090cc2d... 251ae5b... M src/m/vax.h commit 2b8cb4cd000b5f186b03357b7e0ea45dd522d955 Author: Steve Youngs Date: Sat Jan 28 16:47:35 2012 +1000 Whitespace cleanup in src/media Signed-off-by: Steve Youngs :100644 100644 bd2007c... 9c3367b... M src/media/Makefile.am :100644 100644 ce01e53... 8160b46... M src/media/dgif_lib.c :100644 100644 531eab0... dd050f7... M src/media/gif_io.c :100644 100644 e1667a3... 797641b... M src/media/media-ffmpeg.c :100644 100644 8d393aa... f7dfd1a... M src/media/media-internal.c :100644 100644 ea6a5c7... ba2101c... M src/media/media-mad.c :100644 100644 df548e4... 2de21fd... M src/media/media-mad.h :100644 100644 49f804f... f6d8d80... M src/media/media-magic.c :100644 100644 9c5e99a... 8d0256e... M src/media/media-magic.h :100644 100644 d6e86da... e819126... M src/media/media-sndfile.c :100644 100644 6d3482f... 7bca240... M src/media/media-sox.c :100644 100644 386026c... a6668cf... M src/media/media.c :100644 100644 7f405bb... 97e3d1a... M src/media/media.h :100644 100644 ee69cdb... 865bfb7... M src/media/sound-ao.c :100644 100644 8018e5f... aa76fa6... M src/media/sound-jack.c :100644 100644 5977b3d... 98fd3d5... M src/media/sound-nas.c :100644 100644 9ac7732... 2a16094... M src/media/sound-oss.c :100644 100644 c2e1e18... f51bcf2... M src/media/sound-pulse.c :100644 100644 704fd59... 158c20e... M src/media/sound.c :100644 100644 14d6991... 545de38... M src/media/sound.h commit d928b01207790fefc3581086e5dcb3658a84a48d Author: Steve Youngs Date: Sat Jan 28 16:41:08 2012 +1000 Whitespace cleanup in src/mem Signed-off-by: Steve Youngs :100644 100644 3dd0253... b8f7fc3... M src/mem/Makefile.am :100644 100644 22eb64e... 8634f9f... M src/mem/free-hook.c :100644 100644 4eed116... ad052f8... M src/mem/malloc.c :100644 100644 5d0b7fd... 62a4b17... M src/mem/ralloc.c commit 684ef72bbf5b2c4723ff5a5ee954a21041c360b2 Author: Steve Youngs Date: Sat Jan 28 16:39:24 2012 +1000 Whitespace cleanup in src/mule Signed-off-by: Steve Youngs :100644 100644 f5292e8... 2fc9232... M src/mule/Makefile.am :100644 100644 b6241eb... 094da82... M src/mule/file-coding.c :100644 100644 ef5c0bd... 0f7bd38... M src/mule/input-method-xlib.c :100644 100644 7368d45... 70b595c... M src/mule/mule-canna.c :100644 100644 99c8942... a158776... M src/mule/mule-ccl.c :100644 100644 6254544... 87ed848... M src/mule/mule-ccl.h :100644 100644 183082e... 7c81024... M src/mule/mule-wnnfns.c commit 90cc0c07043b6d027c64d617c96d3238eb36c353 Author: Steve Youngs Date: Sat Jan 28 16:36:00 2012 +1000 Whitespace cleanup in src/s Signed-off-by: Steve Youngs :100644 100644 52cdbf7... 5837938... M src/s/386bsd.h :100644 100644 0528e0b... 34462b1... M src/s/darwin.h :100644 100644 bdc5af9... 41198d9... M src/s/ewsux5r4.h :100644 100644 ee0523e... a7a5b83... M src/s/hpux.h :100644 100644 a7875c9... 020dd18... M src/s/hpux8.h :100644 100644 d4370fe... 71f7b7a... M src/s/hpux9.h :100644 100644 7a8ccd9... 9989704... M src/s/linux.h :100644 100644 30d336e... 3553528... M src/s/mach-bsd4-3.h :100644 100644 0a3552b... b4148e5... M src/s/ptx.h :100644 100644 44df302... 67161ca... M src/s/sco4.h :100644 100644 bebc840... 35c4e67... M src/s/sunos4-1-1.h :100644 100644 2a3e816... a36d0b3... M src/s/usg5-4.h commit 2eb6b615c74269b58acb8813f74a0266a706f111 Author: Steve Youngs Date: Sat Jan 28 16:20:04 2012 +1000 Whitespace cleanup in src/ui Signed-off-by: Steve Youngs :100644 100644 4db4ea1... a15ce95... M src/ui/Makefile.am :100644 100644 0992698... 4f6cee7... M src/ui/bitmaps.h :100644 100644 952fa83... 0113bdf... M src/ui/console.c :100644 100644 6c3ca0f... 1763967... M src/ui/console.h :100644 100644 04d7a8b... 02a1628... M src/ui/device.c :100644 100644 51a8742... 2d72de1... M src/ui/device.h :100644 100644 4beca9c... 3535469... M src/ui/faces.c :100644 100644 2c982ce... de1e4a4... M src/ui/frame.c :100644 100644 5036d57... 769825d... M src/ui/frame.h :100644 100644 f6fdb96... 109ad24... M src/ui/gifrlib.h :100644 100644 2704f1d... e60c589... M src/ui/glyphs-eimage.c :100644 100644 e68fdea... 75a3bcb... M src/ui/glyphs-widget.c :100644 100644 c6a3edc... 213b27b... M src/ui/glyphs.c :100644 100644 5a5555d... dc8dea3... M src/ui/gutter.h :100644 100644 f5d176d... 99b27bc... M src/ui/imgproc.c :100644 100644 bd71546... 603a0e4... M src/ui/insdel.c :100644 100644 b81ccfe... e702f19... M src/ui/keymap.c :100644 100644 bd519f0... 93c7372... M src/ui/menubar.c :100644 100644 2dbefa3... 5e18f4b... M src/ui/redisplay-output.c :100644 100644 fc7d520... 7bc6c7d... M src/ui/redisplay.c :100644 100644 b78a1ca... 324179f... M src/ui/redisplay.h :100644 100644 ac0665d... 96997b5... M src/ui/scrollbar.c :100644 100644 e826ef5... 34f8cc7... M src/ui/select.c :100644 100644 29bb731... 55dcf50... M src/ui/specifier.c :100644 100644 b531297... 0eecb49... M src/ui/toolbar.c :100644 100644 d679d38... 4ec1d6d... M src/ui/window.c :100644 100644 820a088... b25bb1c... M src/ui/window.h commit 995db1fb6de1789cfc79ce631a00cb7abac75a9e Author: Steve Youngs Date: Sat Jan 28 16:06:36 2012 +1000 Whitespace cleanup in src/ui/lwlib Signed-off-by: Steve Youngs :100644 100644 5729cda... 824e6f6... M src/ui/lwlib/Makefile.am :100644 100644 7cd1c4e... f24bf74... M src/ui/lwlib/lwlib-Xaw.c :100644 100644 26e7d73... 9b98877... M src/ui/lwlib/lwlib-Xlw.c :100644 100644 329cbea... 53dc741... M src/ui/lwlib/lwlib-Xm.c :100644 100644 8d5962f... 13de716... M src/ui/lwlib/lwlib-utils.c :100644 100644 b66dcb1... 7748709... M src/ui/lwlib/lwlib.c :100644 100644 ea7771f... 2b07311... M src/ui/lwlib/xlwcheckbox.h :100644 100644 9cf0720... 5cf0711... M src/ui/lwlib/xlwcheckboxP.h :100644 100644 c308e9e... 07dbebc... M src/ui/lwlib/xlwgauge.c :100644 100644 61bf4e4... 6966ee3... M src/ui/lwlib/xlwgauge.h :100644 100644 0cc4f0e... 309150f... M src/ui/lwlib/xlwgaugeP.h :100644 100644 7b067d7... dae3ca5... M src/ui/lwlib/xlwmenu.c :100644 100644 37c7206... 40393c9... M src/ui/lwlib/xlwradio.h :100644 100644 cc0c6df... 812f1cb... M src/ui/lwlib/xlwradioP.h :100644 100644 c178f11... c6ccddc... M src/ui/lwlib/xlwscrollbar.h :100644 100644 18abf45... bcafe58... M src/ui/lwlib/xlwtabs.c :100644 100644 9fb5c0b... 26a4728... M src/ui/lwlib/xlwtabs.h commit f14519b61a9036436a6a00c80e6e742aa4810d09 Author: Steve Youngs Date: Sat Jan 28 16:01:24 2012 +1000 Whitespace cleanup in src/ui/X11 Signed-off-by: Steve Youngs :100644 100644 cdcf626... fdcb832... M src/ui/X11/EmacsShell-sub.c :100644 100644 4762f37... 5f6eb58... M src/ui/X11/ExternalShell.c :100644 100644 200ba77... 4420437... M src/ui/X11/Makefile.am :100644 100644 ffe489a... a051890... M src/ui/X11/console-x.h :100644 100644 8211541... 47c4211... M src/ui/X11/device-x.c :100644 100644 b2cadcf... 4811a08... M src/ui/X11/event-Xt.c :100644 100644 3349e88... 5c9e792... M src/ui/X11/frame-x.c :100644 100644 ba3b46b... e2290c3... M src/ui/X11/glyphs-x.c :100644 100644 f288b16... 2f17329... M src/ui/X11/objects-x.c :100644 100644 01dcdbb... 775135f... M src/ui/X11/redisplay-x.c :100644 100644 0e06a97... cfb04c2... M src/ui/X11/scrollbar-x.c :100644 100644 457f7b3... a1c1f17... M src/ui/X11/select-x.c :100644 100644 67eb9a1... fe28f39... M src/ui/X11/toolbar-x.c :100644 100644 068ce4b... 2512b1f... M src/ui/X11/xgccache.c :100644 100644 1201462... 90864e6... M src/ui/X11/xmu.c commit 5053592fa224291fbbf002809244e64052af4334 Author: Steve Youngs Date: Sat Jan 28 15:45:45 2012 +1000 Whitespace cleanup in src/ui/TTY Signed-off-by: Steve Youngs :100644 100644 9db3046... 30be50f... M src/ui/TTY/Makefile.am :100644 100644 a443037... 3b3d57e... M src/ui/TTY/console-tty.h :100644 100644 54bb734... 26897dc... M src/ui/TTY/event-tty.c :100644 100644 026a5d3... edd79ba... M src/ui/TTY/objects-tty.c :100644 100644 4bc7786... 31beba6... M src/ui/TTY/objects-tty.h :100644 100644 c8c8485... a907ce0... M src/ui/TTY/redisplay-tty.c :100644 100644 db13b47... 111f5d7... M src/ui/TTY/terminfo.c commit 3e2d91363c72d9a2c6be01dde0a4dddaeb09c869 Author: Steve Youngs Date: Sat Jan 28 14:35:02 2012 +1000 Whitespace cleanup in tests Signed-off-by: Steve Youngs :100644 100644 4edf25d... 976b3e0... M tests/Makefile.am :100644 100644 5519eaa... 5ba0d17... M tests/automated/ase-interval-tests.el :100644 100644 fcd8242... 7872448... M tests/automated/base64-tests.el :100644 100644 29c5445... 6ae4d25... M tests/automated/bloom-tests.el :100644 100644 152df84... 1e9dd7f... M tests/automated/byte-compiler-tests.el :100644 100644 d350c0b... 4832cf6... M tests/automated/c-tests.el :100644 100644 9aac263... c13c64e... M tests/automated/case-tests.el :100644 100644 7beb21e... 2efb9a3... M tests/automated/ccl-tests.el :100644 100644 ffcf05b... 51f4cdf... M tests/automated/cl-loop-tests.el :100644 100644 25f19ee... c848697... M tests/automated/database-tests.el :100644 100644 3f2dd52... 753cee6... M tests/automated/ent-tests.el :100644 100644 6c1df6d... 3985da3... M tests/automated/extent-tests.el :100644 100644 6bea45b... facaded... M tests/automated/format-tests.el :100644 100644 f8816cf... 22b69bb... M tests/automated/hash-table-tests.el :100644 100644 fd5ea98... cf9cd24... M tests/automated/inplace-tests.el :100644 100644 28b239b... dc9a496... M tests/automated/lisp-reader-tests.el :100644 100644 5d57aef... 13a08e9... M tests/automated/lisp-tests.el :100644 100644 e439b69... 7367efe... M tests/automated/map-tests.el :100644 100644 834a7b7... 2efd0ce... M tests/automated/md5-tests.el :100644 100644 bb8ebf7... f81c14f... M tests/automated/mule-tests.el :100644 100644 ef2401d... bdbc1b4... M tests/automated/openssl-tests.el :100644 100644 697d649... 4ddd0a0... M tests/automated/os-tests.el :100644 100644 5216d8e... 5c43fa3... M tests/automated/regexp-tests.el :100644 100644 520e3e2... 5f46e81... M tests/automated/region-tests.el :100644 100644 8b58fd9... 759b052... M tests/automated/skiplist-tests.el :100644 100644 0305cc7... 8a8c4ca... M tests/automated/symbol-tests.el :100644 100644 10aa5c1... 0d54e9e... M tests/automated/syntax-tests.el :100644 100644 d9f9b40... a604b33... M tests/automated/tag-tests.el :100644 100644 e9ca782... 9372bd1... M tests/automated/test-harness.el :100644 100644 ef069fd... e6ae188... M tests/automated/weak-tests.el :100644 100644 85b09cd... e0b3f64... M tests/benchmark/benchmark.el :100644 100644 5ce3f8e... 2eb5831... M tests/frame.el :100644 100644 7330032... 24da2fc... M tests/glyph-test.el :100644 100644 c73b09f... ac4edec... M tests/gutter-test.el :100644 100644 dc7152b... 9b7a773... M tests/mule/match.el :100644 100644 e961d6c... 1faa953... M tests/redisplay-tests.el :100644 100644 cf7d060... 8ed3aaf... M tests/reproduce-bugs.el commit aa2509b313f40b4548e0070631892b9e0548c290 Author: Steve Youngs Date: Sat Jan 28 14:28:25 2012 +1000 Whitespace cleanup in modules Signed-off-by: Steve Youngs :100644 100644 744a6d4... b0249a6... M modules/Makefile.am :100644 100644 161483c... aada462... M modules/ase/Makefile.am :100644 100644 2432548... bdd327c... M modules/ase/ase-cartesian.c :100644 100644 424e09e... 472201f... M modules/ase/ase-cartesian.h :100644 100644 9970cb1... 8209162... M modules/ase/ase-digraph.c :100644 100644 9f67c8b... 659892d... M modules/ase/ase-digraph.h :100644 100644 fecb754... ad5ea86... M modules/ase/ase-heap-profs.el :100644 100644 0066bc6... e5757e1... M modules/ase/ase-heap.c :100644 100644 5dbc8e1... 4233201... M modules/ase/ase-heap.h :100644 100644 b0f1cbc... 2814745... M modules/ase/ase-interval.c :100644 100644 a8459ba... 3f9bbdc... M modules/ase/ase-interval.h :100644 100644 9ea995c... b14a682... M modules/ase/ase-metric.c :100644 100644 2507982... 835958f... M modules/ase/ase-metric.h :100644 100644 48f1fec... 638b2f3... M modules/ase/ase-neighbourhood.c :100644 100644 f39a194... 52b26c9... M modules/ase/ase-neighbourhood.h :100644 100644 653c3ca... f00a178... M modules/ase/ase-permutation.c :100644 100644 99d5aaf... ea850e4... M modules/ase/ase-permutation.h :100644 100644 44a33e8... 4ede700... M modules/ase/ase-resclass.c :100644 100644 9e44d64... 2d1e9d8... M modules/ase/ase-resclass.h :100644 100644 dd095eb... f27187f... M modules/ase/ase-set.c :100644 100644 8b747e1... b8727eb... M modules/ase/ase-set.h :100644 100644 bc2d181... 167722f... M modules/ase/ase.c :100644 100644 27ec6dc... e67d35e... M modules/ase/ase.h :100644 100644 947df24... e63b9b2... M modules/cl/Makefile.am :100644 100644 6ab521b... b7a72eb... M modules/cl/cl-loop-parser.y :100644 100644 f6e3631... 49c1faf... M modules/cl/cl-loop-profs.el :100644 100644 77eed6b... 8c40291... M modules/cl/cl-loop.c :100644 100644 54de70d... 13cde85... M modules/cl/cl-loop.h :100644 100644 6480b89... 078b072... M modules/cl/cl.c :100644 100644 4ad2084... 67bc64c... M modules/cl/cl.h :100644 100644 d636276... 6b1fa8f... M modules/configure.ac :100644 100644 723b877... 597c2ff... M modules/dbus/Makefile.am :100644 100644 9515554... d1a3650... M modules/ldap/Makefile.am commit 2e251269f55dc1275e01d92ba8d72e9a9670175c Author: Steve Youngs Date: Sat Jan 28 14:20:31 2012 +1000 Whitespace cleanup in m4 Signed-off-by: Steve Youngs :100644 100644 2da122a... 1a838e2... M m4/sxe-acx_pthread.m4 :100644 100644 f79af76... 08593a1... M m4/sxe-arch.m4 :100644 100644 bf34396... 1499c3c... M m4/sxe-aux.m4 :100644 100644 c7f9cdb... 6d71535... M m4/sxe-bldchain-progs.m4 :100644 100644 13a78ae... c230461... M m4/sxe-bldenv.m4 :100644 100644 d27ed6d... 8c7c566... M m4/sxe-compiler.m4 :100644 100644 4ae9d7d... 4af3e69... M m4/sxe-crypto.m4 :100644 100644 3c97142... 0194531... M m4/sxe-dbms.m4 :100644 100644 99ee02a... ca7cb65... M m4/sxe-fs-funs.m4 :100644 100644 390eb5c... d992ce7... M m4/sxe-gui.m4 :100644 100644 f7e7881... 9388ddf... M m4/sxe-iconv.m4 :100644 100644 9c32661... a8aa1fb... M m4/sxe-libc.m4 :100644 100644 cbdd76c... d084f03... M m4/sxe-machine.m4 :100644 100644 3bf2a02... 9f86b83... M m4/sxe-maths.m4 :100644 100644 cc67a7f... e6a21aa... M m4/sxe-mm.m4 :100644 100644 68dde84... 777c0ba... M m4/sxe-option-groups.m4 :100644 100644 f46023b... 2c71798... M m4/sxe-sockets.m4 :100644 100644 acdfbf4... fdcdbd7... M m4/sxe-summary.m4 commit 4f026a3301f46f760b59dedece9991ea8ea0b0d6 Author: Steve Youngs Date: Sat Jan 28 14:16:00 2012 +1000 Whitespace cleanup in lisp Signed-off-by: Steve Youngs :100644 100644 95e46e1... 66f7129... M lisp/Makefile.am :100644 100644 211ba61... c6e1d8c... M lisp/abbrev.el :100644 100644 9179f1c... a87d94f... M lisp/about.el :100644 100644 6c6df04... b52d594... M lisp/apropos.el :100644 100644 8849dbb... 0174427... M lisp/auto-save.el :100644 100644 df57711... 856a5e2... M lisp/auto-show.el :100644 100644 51e665b... 52bbd4b... M lisp/autoload.el :100644 100644 2eb5529... c0c7f6e... M lisp/backquote.el :100644 100644 194aa8e... cff7562... M lisp/buff-menu.el :100644 100644 38bb3b1... 123c457... M lisp/build-autoloads.el :100644 100644 e9c2ba2... b8a38ee... M lisp/build-rpt.el :100644 100644 1d5a284... 0d6d865... M lisp/byte-optimize.el :100644 100644 cbe5a87... 519d006... M lisp/bytecomp-runtime.el :100644 100644 0e5ed1e... bcee9c0... M lisp/bytecomp.el :100644 100644 04106f3... 2ee1b50... M lisp/cl-compat.el :100644 100644 4bc30d1... 00e2662... M lisp/cl-extra.el :100644 100644 dd89a60... d1d2cf0... M lisp/cl-macs.el :100644 100644 7568c06... da688b8... M lisp/cl.el :100644 100644 1f7466d... 1333fca... M lisp/cmdloop.el :100644 100644 5eb3b65... 9ee7887... M lisp/code-cmds.el :100644 100644 b63e4e1... 1d2a0ef... M lisp/code-files.el :100644 100644 59da19d... 728b9b4... M lisp/code-process.el :100644 100644 072fc4d... 604f3b4... M lisp/compat.el :100644 100644 920cb93... cc877e4... M lisp/compile-core.el :100644 100644 bca7b6c... 302c717... M lisp/console.el :100644 100644 8024079... 27449e6... M lisp/cus-edit.el :100644 100644 b473fbe... af468c8... M lisp/cus-face.el :100644 100644 7790595... a604485... M lisp/cus-start.el :100644 100644 06d7aca... 39075d3... M lisp/custom.el :100644 100644 e492f96... f34ea51... M lisp/derived.el :100644 100644 fcb1793... 5df671e... M lisp/device.el :100644 100644 8c47c32... 3b05a69... M lisp/dialog-items.el :100644 100644 2081854... 6f50ed8... M lisp/dialog.el :100644 100644 e7854dc... 0d58c32... M lisp/disass.el :100644 100644 e64a327... c072bee... M lisp/disp-table.el :100644 100644 d763ab0... 594d9d3... M lisp/dragdrop.el :100644 100644 dd0dafa... b96c3ce... M lisp/dump-paths.el :100644 100644 c775066... c592c05... M lisp/dumped-lisp.el :100644 100644 f75d187... 1bc9a60... M lisp/easy-mmode.el :100644 100644 f78e0e3... b8dbec8... M lisp/easymenu.el :100644 100644 06c1128... a885097... M lisp/emod-utils.el :100644 100644 c619a9c... 357e7d0... M lisp/etags.el :100644 100644 83cc777... 83e5437... M lisp/events.el :100644 100644 a2fbc3d... 8f858ed... M lisp/extents.el :100644 100644 63ae037... 6649204... M lisp/faces.el :100644 100644 69e863d... 274a366... M lisp/ffi.el :100644 100644 f2b4ea1... dbb0202... M lisp/ffi/ffi-curl.el :100644 100644 572c3c5... ecfe283... M lisp/ffi/ffi-dbus.el :100644 100644 3c9406c... 846cc12... M lisp/ffi/ffi-gcrypt.el :100644 100644 456652b... ff91d74... M lisp/ffi/ffi-libc.el :100644 100644 5068146... 408cdaf... M lisp/ffi/ffi-magic.el :100644 100644 3dbffa5... bcc7b52... M lisp/ffi/ffi-sqlite.el :100644 100644 808e81b... 5d74f85... M lisp/ffi/ffi-taglib.el :100644 100644 45819cb... 9ca2a59... M lisp/ffi/ffi-wand.el :100644 100644 e261a1b... c200929... M lisp/files.el :100644 100644 485145d... 84cd6d1... M lisp/fill.el :100644 100644 ec507fc... aa89a66... M lisp/find-paths.el :100644 100644 0b7011c... 9b7a412... M lisp/finder.el :100644 100644 0f0deb9... 734689f... M lisp/font-lock.el :100644 100644 4f55c8a... 03ec57e... M lisp/font-menu.el :100644 100644 5829c68... 66c7b5c... M lisp/font.el :100644 100644 9fc1fa5... 6f37367... M lisp/fontl-hooks.el :100644 100644 2e7414d... cf1b7c6... M lisp/format.el :100644 100644 6636a66... f366856... M lisp/frame.el :100644 100644 76fcea0... 1313074... M lisp/glyphs.el :100644 100644 39c84f5... faba993... M lisp/gnuserv.el :100644 100644 f353be9... 30f3584... M lisp/gui.el :100644 100644 3d714ab... 3edb53d... M lisp/gutter-items.el :100644 100644 f5d8ceb... cd09836... M lisp/gutter.el :100644 100644 0f801f2... e736613... M lisp/help-macro.el :100644 100644 3ec02df... f586ee5... M lisp/help.el :100644 100644 c739699... a3ae02b... M lisp/hyper-apropos.el :100644 100644 75eb8b8... cf8620e... M lisp/indent.el :100644 100644 4e02b08... e15974e... M lisp/info.el :100644 100644 b90140c... f52c33c... M lisp/isearch-mode.el :100644 100644 e9f053a... 3abee4d... M lisp/iso8859-1.el :100644 100644 5ea36ca... be60010... M lisp/issue-tracker.el :100644 100644 fdf8468... 52aa517... M lisp/itimer-autosave.el :100644 100644 4a9c3f9... 40a329c... M lisp/keydefs.el :100644 100644 a4fbeb2... 7370b06... M lisp/keymap.el :100644 100644 6ff1679... 61529ef... M lisp/lib-complete.el :100644 100644 03a71d2... c83bfff... M lisp/lisp-initd.el :100644 100644 6e2f69b... 12d6cb6... M lisp/lisp-mnt.el :100644 100644 4737eb5... 8d81dbc... M lisp/lisp-mode.el :100644 100644 cbacc3d... 06c1d93... M lisp/lisp.el :100644 100644 390ccdd... 2f3b63d... M lisp/list-mode.el :100644 100644 7f1fa50... 134c214... M lisp/loaddefs.el :100644 100644 46136a6... 1ea7a05... M lisp/loadhist.el :100644 100644 a2e64b4... 9591871... M lisp/loadup.el :100644 100644 0244966... ce106d2... M lisp/make-docfile.el :100644 100644 1e31f8b... a9b264b... M lisp/map-ynp.el :100644 100644 a1c106d... b73d1b6... M lisp/menubar-items.el :100644 100644 6aef638... a0a3352... M lisp/menubar.el :100644 100644 9cf418e... 02c1d69... M lisp/minibuf.el :100644 100644 1ea0aa0... cdc66a5... M lisp/mode-motion.el :100644 100644 6ac7c00... 339812d... M lisp/modeline.el :100644 100644 362e712... 237a165... M lisp/mouse.el :100644 100644 033d8c7... 194cc6f... M lisp/mule/ccl.el :100644 100644 ca4cf20... 3449e36... M lisp/mule/chinese.el :100644 100644 c3a79f4... 374094d... M lisp/mule/cyrillic.el :100644 100644 8162db3... 818c3c6... M lisp/mule/japanese.el :100644 100644 8037ee8... 9b07eee... M lisp/mule/kinsoku.el :100644 100644 a120e2a... 527dfac... M lisp/mule/mule-category.el :100644 100644 84112cc... 673dedc... M lisp/mule/mule-charset.el :100644 100644 0faf689... 883f9e4... M lisp/mule/mule-cmds.el :100644 100644 45279b0... 3bc3146... M lisp/mule/mule-help.el :100644 100644 8e077d4... 27fa5b2... M lisp/mule/mule-init.el :100644 100644 d063fe3... deff049... M lisp/mule/mule-x-init.el :100644 100644 e3a6bea... 8c8ea3f... M lisp/mule/thai-xtis.el :100644 100644 e6133e6... ef67303... M lisp/mule/vietnamese.el :100644 100644 f4ae507... 6b21af7... M lisp/multicast.el :100644 100644 0895dd6... 89ea3aa... M lisp/number.el :100644 100644 4ba7ac1... 2475b7a... M lisp/obsolete.el :100644 100644 b528223... f45c667... M lisp/package-admin.el :100644 100644 4b4a2db... 3f650cd... M lisp/package-get.el :100644 100644 667a1ba... b77e71b... M lisp/package-ui.el :100644 100644 8d82d65... 34a555c... M lisp/packages.el :100644 100644 1f41213... 929455b... M lisp/page.el :100644 100644 17f4e37... 4a423d7... M lisp/paragraphs.el :100644 100644 fdcefbd... 4056841... M lisp/picture.el :100644 100644 df29374... fd46bee... M lisp/printer.el :100644 100644 93cd616... f556089... M lisp/process.el :100644 100644 1ced83a... dbffc5a... M lisp/rect.el :100644 100644 fc0d02c... ccc34d3... M lisp/regexp-opt.el :100644 100644 4aa70d7... ba9718f... M lisp/register.el :100644 100644 d79ab0c... 45a3e6d... M lisp/replace.el :100644 100644 297cb98... e07180c... M lisp/resize-minibuffer.el :100644 100644 91837cc... e200ac8... M lisp/select.el :100644 100644 2cc01bc... ad3ed76... M lisp/setup-paths.el :100644 100644 93f3e6c... 1d5fd96... M lisp/shadow.el :100644 100644 22b08fa... a524213... M lisp/simple.el :100644 100644 c18afe6... 9a48ea2... M lisp/site-load.el :100644 100644 98a07c8... 4048093... M lisp/sound.el :100644 100644 fade7c3... 0111f01... M lisp/specifier.el :100644 100644 6a878b8... 1423533... M lisp/startup.el :100644 100644 e662dd0... a1b4959... M lisp/subr.el :100644 100644 068cdd9... 7061250... M lisp/symbols.el :100644 100644 9739859... 346dcf1... M lisp/syntax.el :100644 100644 2b94a93... cd30615... M lisp/term/apollo.el :100644 100644 beb84b2... 003a201... M lisp/term/internal.el :100644 100644 7648252... 223d5e4... M lisp/term/linux.el :100644 100644 53d40b3... 1eecdd7... M lisp/term/sun-mouse.el :100644 100644 9c8176e... d50a824... M lisp/term/sup-mouse.el :100644 100644 0f9cc3c... c8056dd... M lisp/term/tvi970.el :100644 100644 53621c0... 9e96030... M lisp/term/vt100.el :100644 100644 c9cb125... 31f64a0... M lisp/term/vt201.el :100644 100644 c9cb125... 31f64a0... M lisp/term/vt220.el :100644 100644 8bbd5a4... 18b4e2d... M lisp/text-mode.el :100644 100644 63a87f2... 68e2ea0... M lisp/toolbar-items.el :100644 100644 5851204... f92eff2... M lisp/tty-init.el :100644 100644 34c22b4... 8751d2d... M lisp/update-elc-2.el :100644 100644 403e7cd... eca0f19... M lisp/update-elc.el :100644 100644 6322480... 598845b... M lisp/userlock.el :100644 100644 8f999b1... 6991be1... M lisp/version.el :100644 100644 d1fce9f... 4308531... M lisp/wid-browse.el :100644 100644 8637175... c1345c1... M lisp/wid-edit.el :100644 100644 5de4e7e... 247081f... M lisp/window-xemacs.el :100644 100644 0f23596... 9933a2a... M lisp/window.el :100644 100644 9cc1c9a... 4f3cf1c... M lisp/x-color.el :100644 100644 abc9461... eb9d8cc... M lisp/x-faces.el :100644 100644 254d5e8... b9a7844... M lisp/x-font-menu.el :100644 100644 0aaf4b0... ddde8aa... M lisp/x-init.el :100644 100644 085404e... ddce62d... M lisp/x-iso8859-1.el :100644 100644 cb8dfde... 5f262d1... M lisp/x-mouse.el :100644 100644 0581e6c... ea28940... M lisp/x-scrollbar.el commit 708516071709b1ff2248021abef1ffd82efbecab Author: Steve Youngs Date: Sat Jan 28 13:00:23 2012 +1000 Whitespace cleanup in lib-src Signed-off-by: Steve Youngs :100644 100644 9a2788a... 80dbd31... M lib-src/Makefile.am :100644 100644 6fd951e... b58ff0a... M lib-src/etags.c :100644 100644 1fdc26b... 5328b97... M lib-src/gnuclient.c :100644 100644 3c6d126... 103765c... M lib-src/gnuserv.c :100644 100644 a112310... 4d44919... M lib-src/gnuserv.h :100644 100644 c15520f... e388fc0... M lib-src/gnuslib.c :100644 100644 621ed6b... d7c0926... M lib-src/hexl.c :100644 100644 e746506... 6cd2278... M lib-src/make-docfile.c :100644 100644 ac15679... fb2b56e... M lib-src/make-msgfile.lex :100644 100644 6195f16... a65387c... M lib-src/mmencode.c :100644 100644 909a7cc... 89760f8... M lib-src/movemail.c :100644 100644 4ce713f... a99196a... M lib-src/ootags.c :100644 100644 5e88567... 9945443... M lib-src/pop.c :100644 100644 4a97d7a... 4749b86... M lib-src/pop.h :100644 100644 c8fa369... d54e4ea... M lib-src/profile.c :100644 100644 32e2f70... afd00b9... M lib-src/qsort.c :100644 100644 3394e73... c582cd0... M lib-src/sorted-doc.c :100644 100644 01a7c77... 3dad330... M lib-src/yow.c commit 1e43ad452b2eeda9b987d7e675d501ae4af18b31 Author: Steve Youngs Date: Sat Jan 28 12:52:19 2012 +1000 Whitespace cleanup in info Signed-off-by: Steve Youngs :100644 100644 bc14445... 7cfa90c... M info/emodules.texi :100644 100644 e6bd910... 35bdf64... M info/internals/index.texi :100644 100644 6ce4a2d... 372db74... M info/internals/internals.texi :100644 100644 748fb1b... 37bc889... M info/lispref/backups.texi :100644 100644 0ffd0d6... fdcf5eb... M info/lispref/building.texi :100644 100644 a44d03e... a12918e... M info/lispref/commands.texi :100644 100644 4f78df8... 7ad84c8... M info/lispref/compile.texi :100644 100644 49a6fae... f87bf85... M info/lispref/control.texi :100644 100644 a83961e... 3b4b5d4... M info/lispref/display.texi :100644 100644 9b03fb7... da12055... M info/lispref/edebug-inc.texi :100644 100644 c9f9d96... b242649... M info/lispref/ent.texi :100644 100644 60b3025... 8c8d76d... M info/lispref/eval.texi :100644 100644 f793f6f... 03e823c... M info/lispref/extents.texi :100644 100644 cc532b2... 374db66... M info/lispref/faces.texi :100644 100644 d894ae6... 5546dff... M info/lispref/ffi.texi :100644 100644 c75fd51... 279c62d... M info/lispref/files.texi :100644 100644 c12fe98... be1dd46... M info/lispref/functions.texi :100644 100644 46104ce... 172e292... M info/lispref/glyphs.texi :100644 100644 d1cc1b0... 327e326... M info/lispref/gutter.texi :100644 100644 99152b7... 137310f... M info/lispref/ldap.texi :100644 100644 a33bf7a... 3cee18d... M info/lispref/lispref.texi :100644 100644 2b43c5c... 2c3fc51... M info/lispref/lists.texi :100644 100644 63da60e... 86935a8... M info/lispref/loading.texi :100644 100644 b8f4371... 920ea39... M info/lispref/markers.texi :100644 100644 5193ce8... 4c58962... M info/lispref/media.texi :100644 100644 6347546... 752a439... M info/lispref/menus.texi :100644 100644 e75d6b7... 76b0986... M info/lispref/modes.texi :100644 100644 5744f84... a6f2127... M info/lispref/mule.texi :100644 100644 ad8ec2f... 7617548... M info/lispref/numbers.texi :100644 100644 8b56cf7... 6ea885d... M info/lispref/openssl.texi :100644 100644 63ab17c... 3c37451... M info/lispref/os.texi :100644 100644 89297d9... c56d3bd... M info/lispref/packaging.texi :100644 100644 b720847... fd65ef2... M info/lispref/positions.texi :100644 100644 a930cdb... 23ee08e... M info/lispref/postgresql.texi :100644 100644 314c862... a1b6d0e... M info/lispref/processes.texi :100644 100644 c6849a9... 9341a10... M info/lispref/range-tables.texi :100644 100644 5a45656... 8f5ced7... M info/lispref/searching.texi :100644 100644 1d35c56... 9442551... M info/lispref/symbols.texi :100644 100644 3194595... 1632540... M info/lispref/text.texi :100644 100644 f7785ab... b5a222c... M info/lispref/tips.texi :100644 100644 d2e2ccc... 372d59a... M info/lispref/variables.texi :100644 100644 260261c... 5b27fea... M info/lispref/windows.texi :100644 100644 fd899f9... 703f3ea... M info/new-users-guide/custom1.texi :100644 100644 2259277... e4bca1d... M info/new-users-guide/custom2.texi :100644 100644 f14b637... 1959608... M info/new-users-guide/edit.texi :100644 100644 cfe091d... 6a2fc9c... M info/new-users-guide/enter.texi :100644 100644 b560555... 5c075cb... M info/new-users-guide/files.texi :100644 100644 d8764c0... b7b52d3... M info/new-users-guide/help.texi :100644 100644 95658b4... 0806475... M info/new-users-guide/modes.texi :100644 100644 9d099cd... 33e8dfc... M info/new-users-guide/new-users-guide.texi :100644 100644 2a3f458... 2ab7d89... M info/new-users-guide/region.texi :100644 100644 cd6503c... 10e3de6... M info/new-users-guide/xmenu.texi :100644 100644 712d1dd... 84e6890... M info/sppm.texi :100644 100644 fb0ee5f... 4b6f796... M info/sxemacs-faq.texi :100644 100644 28a6814... 90c3cd2... M info/sxemacs/abbrevs.texi :100644 100644 8229242... 171114f... M info/sxemacs/basic.texi :100644 100644 a58710b... 824c8bc... M info/sxemacs/buffers.texi :100644 100644 5dd903e... 1fd6002... M info/sxemacs/building.texi :100644 100644 7abb460... 94a9a50... M info/sxemacs/calendar.texi :100644 100644 f58fb04... 6608988... M info/sxemacs/cmdargs.texi :100644 100644 b6d4d9a... c6bd6dd... M info/sxemacs/custom.texi :100644 100644 e47f8b9... 544e896... M info/sxemacs/display.texi :100644 100644 7fd7f43... cb795d1... M info/sxemacs/files.texi :100644 100644 9995154... caf56e1... M info/sxemacs/fixit.texi :100644 100644 fd3befd... 7b56b73... M info/sxemacs/frame.texi :100644 100644 d1152c4... a6c8e0c... M info/sxemacs/glossary.texi :100644 100644 ad9d9dc... 6df773f... M info/sxemacs/help.texi :100644 100644 7e63656... 119f0fa... M info/sxemacs/indent.texi :100644 100644 080acea... 7e0a74a... M info/sxemacs/keystrokes.texi :100644 100644 625053d... 1f32416... M info/sxemacs/killing.texi :100644 100644 17c79b6... 61a612d... M info/sxemacs/m-x.texi :100644 100644 af69380... d55ae30... M info/sxemacs/major.texi :100644 100644 01f5f8f... 9341def... M info/sxemacs/mark.texi :100644 100644 b025954... c77b542... M info/sxemacs/menus.texi :100644 100644 533f731... 05b781f... M info/sxemacs/mini.texi :100644 100644 1f36fe7... 2617148... M info/sxemacs/misc.texi :100644 100644 277d8ba... f00f298... M info/sxemacs/mouse.texi :100644 100644 2224139... 99bf5de... M info/sxemacs/mule.texi :100644 100644 16bdb46... eb84975... M info/sxemacs/new.texi :100644 100644 d9238e3... 21cd620... M info/sxemacs/packages.texi :100644 100644 a7381d2... 498ca06... M info/sxemacs/picture.texi :100644 100644 27d73bf... e04c018... M info/sxemacs/programs.texi :100644 100644 9d7f51c... a531433... M info/sxemacs/reading.texi :100644 100644 311a7ab... 44e58a5... M info/sxemacs/regs.texi :100644 100644 183c422... c9f5e83... M info/sxemacs/search.texi :100644 100644 b2d1ae9... bccefad... M info/sxemacs/sending.texi :100644 100644 84bd2d5... 2702868... M info/sxemacs/startup.texi :100644 100644 33beafd... f8338e4... M info/sxemacs/sxemacs.texi :100644 100644 a622742... 4b56722... M info/sxemacs/text.texi :100644 100644 a9c95fa... 1d4ed6c... M info/sxemacs/trouble.texi :100644 100644 eb18a04... efea8af... M info/sxemacs/undo.texi :100644 100644 c1791c3... 72be019... M info/sxemacs/windows.texi :100644 100644 876db89... c4a7866... M info/term.texi :100644 100644 86686bf... a92343d... M info/widget.texi commit 6d7aaa2c198b67189e1326d68935a905a1108e54 Author: Steve Youngs Date: Sat Jan 28 12:17:00 2012 +1000 Whitespace cleanup in etc Signed-off-by: Steve Youngs :100644 100644 6926eb0... 772d433... M etc/Makefile.am :100644 100644 28ec23c... 88a593d... M etc/custom/example-themes/europe-theme.el :100644 100644 d35221b... 33855be... M etc/custom/example-themes/example-theme.el :100755 100755 99152dd... 9e547eb... M etc/editclient.sh :100644 100644 49f76ab... 2353cf3... M etc/sample.init.el :100644 100644 8e6c0e0... c64f3b5... M etc/tests/external-widget/Makefile :100644 100644 4333c73... 34be556... M etc/tests/external-widget/test-ew-motif.c :100644 100644 84e8f4d... e0f4240... M etc/tests/external-widget/test-ew-xlib.c commit e70fb560f77563f78029bd2859781047ea291396 Author: Steve Youngs Date: Sat Jan 28 12:12:08 2012 +1000 Whitespace cleanup in contrib Signed-off-by: Steve Youngs :100755 100755 ef4d2c5... 4e82ab0... M contrib/do_builds.sh :100644 100644 4be5840... cef2077... M contrib/git-post-receive-hook.sample :100755 100755 7e59376... fbc4c21... M contrib/git-to-steve.sh :100755 100755 7f1fc36... e7615e8... M contrib/make-pkg.sh :100755 100755 ff126a4... 749156b... M contrib/report-build-failure.sh :100755 100755 45e71d8... 061de3c... M contrib/tar-build-failure.sh :100644 100644 54a6a6f... 295d321... M contrib/tty-colors.c commit 6032fe5ba29e39dae688e07780d74d5687c3dbc1 Author: Steve Youngs Date: Sat Jan 28 12:08:52 2012 +1000 Whitespace cleanup in toplevel dir Signed-off-by: Steve Youngs :100644 100644 6b48de6... a5d3e0e... M Makefile.am :100755 100755 d85faba... a3690c1... M autogen.sh :100644 100644 381e718... f25ae84... M configure.ac commit a941afbc9098decd61f411d7364c2abd493c6285 Author: Nelson Ferreira Date: Fri Jan 27 17:57:17 2012 -0500 Conditional definition of HAVE_ALLOCA to avoid meaningless HAVE_ALLOCA redefined warnings... Signed-off-by: Nelson Ferreira :100644 100644 1714608... 68c78ec... M src/m/ews4800r.h :100644 100644 bf5ed2e... ec8ef6c... M src/m/hp300bsd.h :100644 100644 62b299d... 5de8d01... M src/m/hp800.h :100644 100644 3291f63... cb4f794... M src/m/hp9000s300.h :100644 100644 90ed16e... 5eb06f6... M src/m/luna88k.h :100644 100644 bafc025... 10cb7bf... M src/m/m68k.h :100644 100644 00f34f0... 2716f5c... M src/m/news.h :100644 100644 cb81e6e... 40f09df... M src/m/pfa50.h :100644 100644 3ce797b... 637cb9b... M src/m/pmax.h :100644 100644 3253617... d21ea18... M src/m/powerpc.h :100644 100644 2d1c070... 4cee033... M src/m/pyrmips.h :100644 100644 2fc6586... 090cc2d... M src/m/vax.h :100644 100644 2410f4d... 697966a... M src/s/aix3-2.h :100644 100644 6c08564... 7b75a8c... M src/s/nextstep.h commit 657e175b1af36d06fe09afb225367546fd4be240 Author: Steve Youngs Date: Wed Jan 25 15:40:11 2012 +1000 Use head -n1 throughout Signed-off-by: Steve Youngs :100755 100755 4d5125e... d85faba... M autogen.sh commit 6a8d4492d2511f70a337216505734fdb77b9a33e Author: Nelson Ferreira Date: Tue Jan 24 23:45:59 2012 -0500 Do not confuse GIT with git (or vice-versa) * autogen.sh: Make sure to only conside one line of git describe, thus taking care of GIT (http://www.gnu.org/software/git/) being installed instead of git (http://git-scm.com) * configure.ac: ditto. Signed-off-by: Nelson Ferreira :100755 100755 5bd7a2e... 4d5125e... M autogen.sh :100644 100644 3d22865... 381e718... M configure.ac commit 3309efd48d127f36d11089ee8b554462d6c02cf0 Author: Steve Youngs Date: Wed Jan 25 10:19:53 2012 +1000 Be consistent with setting and testing for breathing_space * src/alloc.c (refill_memory_reserve): Test if breathing_space is NULL, not zero. Don't cast the malloc. * src/alloc.c (garbage_collect_1): Increase breathing_space to, erm, give us more breathing space. * src/alloc.c (reinit_alloc_once_early): Set breathing_space to NULL, not zero. Signed-off-by: Steve Youngs :100644 100644 f20c2a3... 6f33710... M src/alloc.c commit cd0349b46f73d6a7440544e703c15f61457f9079 Author: Sebastian Freundt Date: Tue Jan 24 23:45:43 2012 +0000 Summary: fix, make sure ssp actually works before using it Keywords: bldchn diagnostics This changeset hopefully resolves the issue Nelson had with ssp and -fstack-protector. Using crystal ball technology and rune readings it turns out that gcc single-handedly adds -lssp as soon as -fstack-protector is specified, regardless if it works or exists. * m4/sxe-compiler.m4 (SXE_STACK_FLAGS): check if ssp works before adding -fstack-protector Signed-off-by: Sebastian Freundt :100644 100644 12fd03b... d27ed6d... M m4/sxe-compiler.m4 commit 1283a4c65844b7495647166854ca6ffe6bf29c3a Author: Ruediger Meier Date: Tue Jan 24 12:19:57 2012 +0100 build fix, undeclared XmCR_UNKNOWN This got accidentally broken in 613c762f. :100644 100644 a74fcf4... 2d324c3... M src/ui/lwlib/xlwscrollbar.c commit dd022a0a6963696360b35ec1c50a670a7a9f95a4 Author: Nelson Ferreira Date: Mon Jan 23 18:53:36 2012 -0500 Add a bit more breathing space to alloc Signed-off-by: Nelson Ferreira :100644 100644 8613124... f20c2a3... M src/alloc.c commit 673588d5186361c939ac3eb7664bcffc41071cdc Author: Sebastian Freundt Date: Mon Jan 23 21:45:10 2012 +0000 Summary: minor, provide malldbg multiarg for MALLOC_PERTURB_ Keywords: bldchn diagnostics This changeset introduces a multiarg item to the error-checking option group, named `malldbg', that controls MALLOC_PERTURB_ and friends when dumping. This should fix the dumping procedure on MALLOC_PERTURB_ systems as our dumper reacts quite sensitively to that kind of system hardening. This changeset contains no additional intelligence to turn it off automatically, if you see crashes during the dump phase conside --with-error-checking=nomalldbg. Whether or not we can persuade (read fix) the dumper code to react more friendly to this kind of interference is subject to a different patch. * configure.ac: add `malldbg' to the error-checking multiarg * m4/sxe-compiler.m4: prepare EXTRA_BATCHENV in case malldbg is off * src/Makefile.am: extend dumping environment to EXTRA_BATCHENV Signed-off-by: Sebastian Freundt :100644 100644 4d61bbc... 12760e7... M configure.ac :100644 100644 7c39bcf... 12fd03b... M m4/sxe-compiler.m4 :100644 100644 3c2b36a... 9aab242... M src/Makefile.am commit 613c762f7488c1ce5f85bae3fa41961099addb9b Author: Nelson Ferreira Date: Mon Jan 23 14:03:28 2012 -0500 Cosmetic break Signed-off-by: Nelson Ferreira :100644 100644 0ebd01a... a74fcf4... M src/ui/lwlib/xlwscrollbar.c commit 9258ccbfb72ceae34f5cfa53ed65a365a4f56d10 Author: Nelson Ferreira Date: Mon Jan 23 14:01:57 2012 -0500 Empty merge Signed-off-by: Nelson Ferreira :100644 100644 bcb0f30... 7d2e40f... M src/regex.c commit 013143bd55b2436229422828bf75eec4eff0198b Author: Nelson Ferreira Date: Mon Jan 23 13:52:52 2012 -0500 compre on by default, no longer experimental Signed-off-by: Nelson Ferreira :100644 100644 823f010... f69bc20... M configure.ac :100644 100644 13b638b... acdfbf4... M m4/sxe-summary.m4 commit f2970661d630ca7b3c1db1b4bb5144f441d2be93 Author: Nelson Ferreira Date: Mon Jan 23 13:52:12 2012 -0500 Use the real pre-processor var: DEBUG_SXEMACS Signed-off-by: Nelson Ferreira :100644 100644 c8ca0ed... f08ddd4... M src/mule/mule-charset.h :100644 100644 e4e051b... f5d176d... M src/ui/imgproc.c commit 5aed2346e889a9f8511d6334c3ddc3094b6e5c53 Author: Nelson Ferreira Date: Mon Jan 23 04:26:35 2012 -0500 Coverity: Forward NULL: CID 607 * lib-src/etags.c (regex_tag_multiline): Really fix Forward NULL. Signed-off-by: Nelson Ferreira :100644 100644 53e8dc8... 6fd951e... M lib-src/etags.c commit 61169e18a60bb0364064883e381d381cef96d298 Author: Sebastian Freundt Date: Sun Jan 22 11:42:14 2012 +0000 Summary: minor, add stack to --with-error-checking to turn SSP on Keywords: bldchn diagnostics This changeset fixes a potential stack bashing in the mapfam permutation code by inserting proper break statements where they belong. This could be one of the reasons of bug #135 and it's yet to be shown that it fixes anything (other than pleasing coverity). * configure.ac: add `stack' to the error-checking multiarg * m4/sxe-compiler.m4: check for -fstack-protector and link with libssp Signed-off-by: Sebastian Freundt :100644 100644 823f010... 4d61bbc... M configure.ac :100644 100644 83d1634... 7c39bcf... M m4/sxe-compiler.m4 commit 3a7ea5e223c8fa88dc21b2b331620150685b7c68 Author: Nelson Ferreira Date: Sat Jan 21 01:22:07 2012 -0500 Fix crash in _ase_interval_union_boundary. Only fini tmp when ur->next becomes tmp->next Signed-off-by: Nelson Ferreira :100644 100644 f416749... b0f1cbc... M modules/ase/ase-interval.c commit 4ce502bf3c9b2a19c0fa0bde0963d02581979dc1 Author: Nelson Ferreira Date: Fri Jan 20 23:44:33 2012 -0500 Coverity: Assert side effect: CID 2 * src/extents.c (gap_array_delete_marker): Remove unnecessary volatile (we don't multithread so we should have this be interrupted. If at some point we make multi-threaded SXEmacs, this should be protected by some barrier. * src/extents.c (gap_array_delete_all_markers): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 c59e066... 7cdfed7... M src/extents.c commit 8904746582a01e0e28599691b7346828eb6cdc67 Author: Nelson Ferreira Date: Fri Jan 20 23:39:47 2012 -0500 Coverity: Checked return: CID 10 * lib-src/hexl.c (main): signal intent to ignore read char Signed-off-by: Nelson Ferreira :100644 100644 8919784... 621ed6b... M lib-src/hexl.c commit 833700b99b3797553992dcc3258143c397f2a1cf Author: Nelson Ferreira Date: Fri Jan 20 23:39:00 2012 -0500 Coverity: Checked return: CID 11 * lib-src/make-docfile.c (scan_lisp_file): Signal intent to ignore read char. Signed-off-by: Nelson Ferreira :100644 100644 c910174... e746506... M lib-src/make-docfile.c commit b63a0e0e78b7113692e7fbb6e91dbbd3782649e6 Author: Nelson Ferreira Date: Fri Jan 20 23:38:14 2012 -0500 Coverity: Checked return: CID 12 * modules/ase/ase-interval.c (_ase_interval_union_item_fini): Signal intention to ignore the return value of decref. Signed-off-by: Nelson Ferreira :100644 100644 132b5e9... f416749... M modules/ase/ase-interval.c commit 934a7c561f9d3cf24e3d08984dbfbb0328a09f40 Author: Nelson Ferreira Date: Fri Jan 20 23:36:38 2012 -0500 Coverity: Char IO: CID 7 * lib-src/make-docfile.c (read_lisp_symbol): Proper handling of cast for getc... Signed-off-by: Nelson Ferreira :100644 100644 94f6acd... c910174... M lib-src/make-docfile.c commit 6224b813fc211ebb6d1955afd24977171f6807cf Author: Nelson Ferreira Date: Fri Jan 20 23:26:55 2012 -0500 Coverity: No effect: CID 134 * src/ui/TTY/event-tty.c (emacs_tty_next_event): Change the loop variable to int to properly map the type of descriptors. Signed-off-by: Nelson Ferreira :100644 100644 4bcb849... 54bb734... M src/ui/TTY/event-tty.c commit 057eb2987cc8d99ca98a6e11d66c555c82c5b22a Author: Nelson Ferreira Date: Fri Jan 20 23:24:45 2012 -0500 Coverity: Overrun static: CID 137, 136 * src/mule/mule-charset.h (CHARSET_BY_ATTRIBUTES): Do paranoid bounds checking... * src/mule/mule-charset.h (REP_BYTES_BY_FIRST_BYTE): Make sure to not dereference in fatal crash scenario where assert flows through... Signed-off-by: Nelson Ferreira :100644 100644 31f0031... c8ca0ed... M src/mule/mule-charset.h commit cb3b0d09437256491d66846563616d8522ea8267 Author: Nelson Ferreira Date: Fri Jan 20 23:18:37 2012 -0500 Coverity: Overrun static: CID 139 * src/dumper.c (pdump_register_object): Fix of-by-one boundary and return after abort for fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 1809fb1... 6555451... M src/dumper.c commit 279c58a3c19297dc6d9598306b591eb743cdd498 Author: Nelson Ferreira Date: Fri Jan 20 23:13:10 2012 -0500 Coverity: Overrun static: CID 141 * src/ui/imgproc.c (get_histogram): Introduce paranoid histogram Signed-off-by: Nelson Ferreira :100644 100644 dea767c... e4e051b... M src/ui/imgproc.c commit f17895f80d0334664e757a53e0ffeefe1e79be1a Author: Nelson Ferreira Date: Fri Jan 20 23:04:34 2012 -0500 Coverity: Resource leak: CID 178 * lib-src/etags.c (regex_tag_multiline): Make it clear a non-null name was allocated in substitute and always free it :) Signed-off-by: Nelson Ferreira :100644 100644 4ef628d... 53e8dc8... M lib-src/etags.c commit 92651d16c6fa315df82af964d387cf1bdd9761f1 Author: Nelson Ferreira Date: Fri Jan 20 22:57:44 2012 -0500 Coverity: Resource leak: CID 180 * lib-src/movemail.c (lock_dot): free the memory Signed-off-by: Nelson Ferreira :100644 100644 66456ed... 909a7cc... M lib-src/movemail.c commit e3a01be74c0f07481e43001bfed94e0c5395d870 Author: Nelson Ferreira Date: Fri Jan 20 22:55:04 2012 -0500 Coverity: Resource leak: CID 181 * lib-src/ootags.c (Erlang_functions): free the memory Signed-off-by: Nelson Ferreira :100644 100644 0c397c4... 4ce713f... M lib-src/ootags.c commit ca6452701725d6abe64598dbbcda957030e4360e Author: Nelson Ferreira Date: Fri Jan 20 22:53:29 2012 -0500 Coverity: Resource leak: CID 181 * lib-src/ootags.c (Erlang_functions): xfree the memory Signed-off-by: Nelson Ferreira :100644 100644 6433c92... 0c397c4... M lib-src/ootags.c commit c92a719ac8e837d52a3000a45d6bd72305b358c7 Author: Nelson Ferreira Date: Fri Jan 20 22:52:05 2012 -0500 Coverity: Resource leak: CID 183 * lib-src/yow.c (yow): Free the memory... Signed-off-by: Nelson Ferreira :100644 100644 07c4ad6... 01a7c77... M lib-src/yow.c commit 046a66e11707c6e76176e3dce08fc76866aeade9 Author: Nelson Ferreira Date: Fri Jan 20 22:49:06 2012 -0500 Coverity: Resource Leak: CID 184 * modules/ase/ase-interval.c (_ase_interval_union_boundary): Properly get rid of the interval. Signed-off-by: Nelson Ferreira :100644 100644 a9f2279... 132b5e9... M modules/ase/ase-interval.c commit e87857fc24bf72612292103e92a61c675f801a69 Author: Nelson Ferreira Date: Fri Jan 20 22:44:28 2012 -0500 Coverity: Resource Leak: CID 185 * modules/ase/ase-interval.c (_ase_subtract_intr_intr): Properly get rid of the interval. Signed-off-by: Nelson Ferreira :100644 100644 8664168... a9f2279... M modules/ase/ase-interval.c commit 0057a176ea017316165f9d2a3640b05bfb70f025 Author: Nelson Ferreira Date: Fri Jan 20 22:15:40 2012 -0500 Coverity: Forward NULL: CID 605 * src/ui/X11/event-Xt.c (Xt_timeout_callback): Just return in case of fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 3dce06b... b2cadcf... M src/ui/X11/event-Xt.c commit 648931ae6ad9a545bd4ee6f987bb19200d55933d Author: Nelson Ferreira Date: Fri Jan 20 22:13:23 2012 -0500 Coverity: Missing return: CID 606 * src/ui/window.c (window_display_buffer): Return NULL for the fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 8ee614b... d679d38... M src/ui/window.c commit acc7abeec3efba40fecdc78e2626199a5b6ed963 Author: Sebastian Freundt Date: Sat Jan 21 00:03:13 2012 +0000 Summary: fix, add missing break statements in mapfam permutation code Keywords: fix bug 135 This changeset fixes a potential stack bashing in the mapfam permutation code by inserting proper break statements where they belong. This could be one of the reasons of bug #135 and it's yet to be shown that it fixes anything (other than pleasing coverity). * src/map.c (__perm_nseq): no switch fallthrough, insert breaks Signed-off-by: Sebastian Freundt :100644 100644 a771287... db4f1c7... M src/map.c commit 654c80d5b994db7452faf40ddad9f27eb3361bf5 Author: Sebastian Freundt Date: Fri Jan 20 23:58:10 2012 +0000 Summary: fix, properly expand OG_MULTIARG_ITEM indirections Keywords: bldchn This changeset expands the explanations of multiarg items in option groups properly (again), m4_text_wrap (and AS_HELP_STRING) fail to evaluate arguments that come from the temporary redefinition of OG_MULTIARG_ITEM. * m4/sxe-option-groups.m4: mimic AS_HELP_STRING in temporary expansion of OG_MULTIARG_ITEM Signed-off-by: Sebastian Freundt :100644 100644 67e960e... 68dde84... M m4/sxe-option-groups.m4 commit dab98dfe7e945cb258b3999405285c652f5bedd5 Author: Nelson Ferreira Date: Fri Jan 20 13:11:39 2012 -0500 Avoid warnings * src/ui/X11/device-x.c (x_get_visual_depth): Avoid uninitialized return in fatal crash. * src/ui/X11/frame-x.c (x_set_frame_properties): Change warn to message, just in case... Signed-off-by: Nelson Ferreira :100644 100644 e9c7b8e... 8211541... M src/ui/X11/device-x.c :100644 100644 1dffd75... 3349e88... M src/ui/X11/frame-x.c commit 74f15f2d86f0992572a33474e74142078ddc9589 Author: Nelson Ferreira Date: Fri Jan 20 12:54:38 2012 -0500 Coverity: Forward NULL: CID 32 * src/extents.c (extent_list_delete_marker): Make sure p is not dereference if NULL even in case of fatal crash. Signed-off-by: Nelson Ferreira :100644 100644 92d1c8b... c59e066... M src/extents.c commit 99b5fe2c050ea35c16082aefc58c98c77bb2b36d Author: Nelson Ferreira Date: Fri Jan 20 12:52:29 2012 -0500 Coverity: Forward NULL: CID 33 * src/alloc.c (build_string): Make sure to only dereference str if not NULL even in fatal crash case. Signed-off-by: Nelson Ferreira :100644 100644 6e1e860... 8613124... M src/alloc.c commit a859b9f6e1aabeb078447b7ade104872a29f232a Author: Nelson Ferreira Date: Fri Jan 20 12:50:42 2012 -0500 Coverity: Forward NULL: CID 34 * src/mem/ralloc.c (r_alloc_free): Make sure bloc is only dereferenced if not NULL even in fatal crash case. Signed-off-by: Nelson Ferreira :100644 100644 7185afa... 5d0b7fd... M src/mem/ralloc.c commit 9575c8397d573b59f5a8eea4b25c316c43bb0ea2 Author: Nelson Ferreira Date: Fri Jan 20 12:49:52 2012 -0500 Coverity: Forward NULL: CID 35 * src/mem/ralloc.c (r_re_alloc): Make sure bloc is only dereferenced if not NULL even in fatal crash case. Signed-off-by: Nelson Ferreira :100644 100644 bd55ca3... 7185afa... M src/mem/ralloc.c commit f716a3b0be55f94021cfedfc7d753ea0392f7573 Author: Nelson Ferreira Date: Fri Jan 20 12:47:31 2012 -0500 Coverity: Forward NULL: CID 37 * src/fns.c (concat): Make sure args_mse is not dereferenced in case of NULL even in case of fatal crash. Signed-off-by: Nelson Ferreira :100644 100644 d60e860... ed1884b... M src/fns.c commit d4926cb5411fd768b58c554e26819c5009840a03 Author: Nelson Ferreira Date: Fri Jan 20 12:45:25 2012 -0500 Coverity: Forward NULL: CID 38 * src/doprnt.c (emacs_doprnt_1): Make sure to only dereference largs if NULL even in case of a '*' format qualifier. Signed-off-by: Nelson Ferreira :100644 100644 6bf4b74... 8076a6b... M src/doprnt.c commit 32ed6a695bac107bdf8a5dc484ab8e67589e1176 Author: Nelson Ferreira Date: Fri Jan 20 12:44:04 2012 -0500 Coverity: Forward NULL: CID 39 * lib-src/etags.c (regex_tag_multiline): Make sure to abort if name is NULL Signed-off-by: Nelson Ferreira :100644 100644 cdcc73c... 4ef628d... M lib-src/etags.c commit 715ed25978e77d14d2c5aa247368da08a881dbcb Author: Nelson Ferreira Date: Fri Jan 20 12:43:14 2012 -0500 Coverity: Forward NULL: CID 42, 41 * src/ui/redisplay-output.c (redisplay_clear_region): Make sure to return from function for case of fatal crash after abort. * src/ui/redisplay.c (regenerate_window): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 9b7e357... 2dbefa3... M src/ui/redisplay-output.c :100644 100644 839d9fd... fc7d520... M src/ui/redisplay.c commit 2f7cadd290b9973d8db079be2581173407a2f181 Author: Nelson Ferreira Date: Fri Jan 20 12:41:16 2012 -0500 Coverity: Forward NULL: CID 44, 43, 36 * src/ui/window.c (window_display_buffer): Make sure t is only dereference if not NULL even in case of fatal crash. * src/ui/window.c (set_window_display_buffer): Ditto. * src/ui/window.c (window_display_lines): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 287b1c8... 8ee614b... M src/ui/window.c commit e07adc7d56a903c846f5c5e55e2f70757f20db1a Author: Nelson Ferreira Date: Fri Jan 20 12:39:01 2012 -0500 Coverity: Forward NULL: CID 48 * src/ui/X11/device-x.c (x_get_visual_depth): make sure vi_out is only dereference is not NULL, even in fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 ccb39bd... e9c7b8e... M src/ui/X11/device-x.c commit a87437524e64742c929b0c86232067055c1b540d Author: Nelson Ferreira Date: Fri Jan 20 12:35:49 2012 -0500 Coverity: Forward NULL: CID 49 * src/ui/lwlib/lwlib.c (instantiate_widget_instance): Make sure function is not dereferenced as NULL even in fatal crash case. Signed-off-by: Nelson Ferreira :100644 100644 8730a4e... b66dcb1... M src/ui/lwlib/lwlib.c commit 1856695aa7efb60b70258641d01fa6cd7074c906 Author: Nelson Ferreira Date: Fri Jan 20 12:34:43 2012 -0500 Coverity: Forward NULL: CID 50 * src/ui/lwlib/lwlib-Xlw.c (xlw_update_tab_control): Make sure cur is not dereference when NULL. Signed-off-by: Nelson Ferreira :100644 100644 d4777d6... 26e7d73... M src/ui/lwlib/lwlib-Xlw.c commit 933b1b9038a375cdac9c276434d3dd52abee777d Author: Nelson Ferreira Date: Fri Jan 20 12:33:00 2012 -0500 Coverity: Forward NULL: CID 51 * src/ui/X11/event-Xt.c (Xt_timeout_callback): Make sure possible NULL are not dereference, even in fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 236ecce... 3dce06b... M src/ui/X11/event-Xt.c commit 8768c972136b853ceb2e811c56de5c8d996f592f Author: Nelson Ferreira Date: Fri Jan 20 12:31:22 2012 -0500 Coverity: Forward NULL: CID 54, 53, 52 * src/ui/X11/xgccache.c (gc_cache_lookup): Make sure not to derefence possible NULL pointers. Signed-off-by: Nelson Ferreira :100644 100644 9f350c2... 068ce4b... M src/ui/X11/xgccache.c commit 8bd015f04a63b254d8e27b7b0cb2ac9e267a8d2f Author: Nelson Ferreira Date: Fri Jan 20 12:28:05 2012 -0500 Fix additional transcoding assertions * src/buffer.h (TO_EXTERNAL_FORMAT): Remove the bad assert (ie not valid in all conditions). * src/buffer.h (TO_INTERNAL_FORMAT): Ditto. * src/buffer.h (DFC_SOURCE_DATA_TO_ARGS): Do the proper assert to the source conversion. * src/buffer.h (DFC_SOURCE_C_STRING_TO_ARGS): Ditto. * src/buffer.h (DFC_SOURCE_LISP_OPAQUE_TO_ARGS): Ditto. * src/buffer.h (DFC_ALLOCA_USE_CONVERTED_DATA): Do the proper assert to the converted data. * src/buffer.h (DFC_MALLOC_USE_CONVERTED_DATA): Ditto. * src/buffer.h (DFC_C_STRING_ALLOCA_USE_CONVERTED_DATA): Ditto. * src/buffer.h (DFC_C_STRING_MALLOC_USE_CONVERTED_DATA): Ditto. * src/buffer.h (DFC_LISP_STRING_USE_CONVERTED_DATA): Ditto. * src/buffer.h (DFC_LISP_OPAQUE_USE_CONVERTED_DATA): Ditto. * src/alloc.c (ALLOCATE_FIXED_TYPE): Make sure to detect failed allocations. * src/alloc.c (ALLOCATE_ATOMIC_FIXED_TYPE): Ditto. * src/alloc.c (make_uninit_string): Make sure the uninit string is valid after construction. * src/opaque.c (make_opaque): Make sure to detect failed allocations even in the fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 55af853... 6e1e860... M src/alloc.c :100644 100644 64ad7f8... 0492730... M src/buffer.h :100644 100644 1901c3a... 80f6472... M src/opaque.c commit 60721b3e75269648a0113d5ccb30979bd6ea9f8c Author: Nelson Ferreira Date: Fri Jan 20 10:38:36 2012 -0500 Coverity: Negative returns: CID 121 * src/ui/TTY/objects-tty.c (tty_font_spec_matches_charset): Actually fix the negative return issue, for the fatal crash case. Signed-off-by: Nelson Ferreira :100644 100644 636dcfc... 026a5d3... M src/ui/TTY/objects-tty.c commit 6983c7712aba1a34051d979acb04c5c82cf41805 Author: Nelson Ferreira Date: Fri Jan 20 10:35:51 2012 -0500 Update link to newest compface in INSTALL Signed-off-by: Nelson Ferreira :100644 100644 0897915... 36042e5... M INSTALL commit 9879986b3e8eb46c632aad42605bbdf46fe85a93 Author: Nelson Ferreira Date: Fri Jan 20 10:35:23 2012 -0500 Coverity: Missing return: CID 604 * src/ui/glyphs.c (Fglyph_type): Tidy up a missing return caused by a previous missing break... Signed-off-by: Nelson Ferreira :100644 100644 a7a9ab8... c6a3edc... M src/ui/glyphs.c commit 09e0c4e2ff3aca97ffa37fae98533cc90f2848b0 Author: Nelson Ferreira Date: Thu Jan 19 23:30:08 2012 -0500 Coverity: Missing break: CID 67 * src/chartab.c (char_table_type_to_symbol): Add break to account for fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 00640b1... 8e9267e... M src/chartab.c commit 39038c4fd609c44d36790a477429d19225b46eb7 Author: Nelson Ferreira Date: Thu Jan 19 23:29:29 2012 -0500 Coverity: Missing break: CID 68 * src/events/events.c (Fevent_properties): Add break to account for fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 a2db6f3... 40a6b19... M src/events/events.c commit 100ad3638f523f39cff1f19081b2e357b9370204 Author: Nelson Ferreira Date: Thu Jan 19 23:28:46 2012 -0500 Coverity: Missing break: CID 69 * src/events/events.c (event_equal): Add break to account for fatal crash scenario. Signed-off-by: Nelson Ferreira :100644 100644 05c719b... a2db6f3... M src/events/events.c commit eef3d3bac8c27c6a4f8f16d7579a69834c8200f3 Author: Nelson Ferreira Date: Thu Jan 19 23:18:18 2012 -0500 Coverity: Missing break: CID 72 * src/mule/file-coding.c (Fcoding_system_type): Add break to account with fatal crash situation. Signed-off-by: Nelson Ferreira :100644 100644 5893ed3... b6241eb... M src/mule/file-coding.c commit 0c0a6fa65571b27b09b9fcaf2a554a34a8a25244 Author: Nelson Ferreira Date: Thu Jan 19 23:17:16 2012 -0500 Coverity: Missing break: CID 73 * src/mule/file-coding.c (eol_type_to_symbol): Add break to account with fatal crash situation. Signed-off-by: Nelson Ferreira :100644 100644 214d447... 5893ed3... M src/mule/file-coding.c commit 3aabea71e53bcea08699adac7b3c3a1bf44e8fc5 Author: Nelson Ferreira Date: Thu Jan 19 23:15:36 2012 -0500 Coverity: Missing Break: CID 76 * src/ui/glyphs.c (Fglyph_type): Add break to account for fatal crash situation. Signed-off-by: Nelson Ferreira :100644 100644 57d4268... a7a9ab8... M src/ui/glyphs.c commit 4bee0216b68e14499c828f154e8d0bb61a7cbb37 Author: Nelson Ferreira Date: Thu Jan 19 23:08:10 2012 -0500 Coverity: Missing lock: CID 81 * src/semaphore.h (sxe_refcounter_finish): Be "correct" and pedantic about locking in refcounter_init Signed-off-by: Nelson Ferreira :100644 100644 f0b6e2e... 81989d6... M src/semaphore.h commit 72f2e2df54ee12e09f8e780bc6709aa9ac77a8e9 Author: Nelson Ferreira Date: Thu Jan 19 23:07:05 2012 -0500 Coverity: Missing Lock: CID 82 * src/semaphore.h (sxe_refcounter_new): Fix the refcounter finish locking Signed-off-by: Nelson Ferreira :100644 100644 01c0d01... f0b6e2e... M src/semaphore.h commit 33d8973d9c98fbdfcab69951c55a472d0383d7ee Author: Nelson Ferreira Date: Thu Jan 19 22:46:00 2012 -0500 Fix build * src/ui/X11/xgccache.c (gc_cache_lookup): Fix build (missing } ) Signed-off-by: Nelson Ferreira :100644 100644 4de5df1... 9f350c2... M src/ui/X11/xgccache.c commit 9cca0d8d68367c00f023ea3f21e7d4a5027a0ffb Author: Nelson Ferreira Date: Thu Jan 19 22:43:57 2012 -0500 Coverity: Negative returns: CID 91 * lib-src/gnuserv.c (handle_unix_request): Handle error in accept... Signed-off-by: Nelson Ferreira :100644 100644 be45a61... 3c6d126... M lib-src/gnuserv.c commit b1295cda5c773a2cd3114928bc77d8b6a1d98fd8 Author: Nelson Ferreira Date: Thu Jan 19 22:42:32 2012 -0500 Coverity: Negative RETURNS: CID 106 * src/indent.c (vpix_motion): Try to handle more safely the crashing fatally scenario... Signed-off-by: Nelson Ferreira :100644 100644 290386e... d0c303b... M src/indent.c commit a491fd4b1aade2921020c5cf52472f21ef279b9f Author: Nelson Ferreira Date: Thu Jan 19 22:36:59 2012 -0500 Coverity: Negative returns: CID 107 * src/dumper.c (pdump): Make sure not to take invalid paths even when abort is a no-op... Signed-off-by: Nelson Ferreira :100644 100644 8987436... 1809fb1... M src/dumper.c commit 42ae112d4a21d883369d69c45efbadcf157db234 Author: Nelson Ferreira Date: Thu Jan 19 22:34:49 2012 -0500 Coverity: Negative Returns: CID 121 * src/ui/TTY/objects-tty.c (tty_font_spec_matches_charset): Make sure to abort in case of invariant violation. Signed-off-by: Nelson Ferreira :100644 100644 0be74fa... 636dcfc... M src/ui/TTY/objects-tty.c commit 93c6246197ce7e1b0e51323c7767828b51f8e090 Author: Nelson Ferreira Date: Thu Jan 19 22:26:32 2012 -0500 Coverity: Reverse INULL: CID 202 * src/mem/ralloc.c (update_heap_bloc_correspondence): Be extra safe and do "abort" on violation of stated (in comment) invariant. Signed-off-by: Nelson Ferreira :100644 100644 c78bf2b... bd55ca3... M src/mem/ralloc.c commit f157312d437fa486a6aac0496228a142fe0955d8 Author: Nelson Ferreira Date: Thu Jan 19 22:22:37 2012 -0500 Coverity: Reverse INULL: CID 130 * src/media/sound.c (audio_device_finalise): Do nothing if header is NULL Signed-off-by: Nelson Ferreira :100644 100644 6b941f5... 704fd59... M src/media/sound.c commit 66cee2ac0273308a5b5f8a537ce3ab5aba7a5270 Author: Nelson Ferreira Date: Thu Jan 19 22:19:45 2012 -0500 Coverity: Reverse Negative: CID 210 * src/process-unix.c (unix_kill_child_process): Make sure to test for subtty non negative before calling process_signal_char. * src/process-unix.c (process_signal_char): Make sure fd is non negative. Signed-off-by: Nelson Ferreira :100644 100644 6cdab37... f122cc5... M src/process-unix.c commit 621c404bfe5acd8cff03ad93fd6997433d78f5f3 Author: Nelson Ferreira Date: Thu Jan 19 22:10:06 2012 -0500 Coverity: UNINIT: CID 395 * src/extents.c (extent_fragment_update): Make sure the glyph_bloc is initialized. Signed-off-by: Nelson Ferreira :100644 100644 226a17c... 92d1c8b... M src/extents.c commit b0ff2d2fad4141191f1eac49c4fef87203288f7c Author: Nelson Ferreira Date: Thu Jan 19 22:08:33 2012 -0500 Coverity: Uninit: CID 396 * src/fileio.c (file-truename) Make sure path is initialized before use. Signed-off-by: Nelson Ferreira :100644 100644 9f4ba2e... 63b1959... M src/fileio.c commit 5e0a19884011fbc2e981a050b8ed237f046fbba3 Author: Nelson Ferreira Date: Thu Jan 19 21:56:49 2012 -0500 Coverity: UNINIT: CID 602 * src/ui/X11/xgccache.c: More UNINIT cleanup Signed-off-by: Nelson Ferreira :100644 100644 2f24105... 4de5df1... M src/ui/X11/xgccache.c commit 75c6f9971dcd7cd46b12a24f37adeb2839f880fd Author: Nelson Ferreira Date: Thu Jan 19 21:51:25 2012 -0500 Coverity: Uninit: CID 603 * src/ui/lwlib/lwlib-Xaw.c (xaw_generic_callback): Make sure user_data is either initialized or not used :) Signed-off-by: Nelson Ferreira :100644 100644 fdfe288... 7cd1c4e... M src/ui/lwlib/lwlib-Xaw.c commit 2362ded7507a973f35649a22f03f9720441085a9 Author: Aidan Kehoe Date: Wed Jan 18 22:04:17 2012 +1000 Improve conformance with usual coding style in effi.c. Qabcdef should hold the perfectly normal, interned symbol abcdef, its C variable should not be named Q_abcdef, that would imply the keyword :abcdef. * effi.c: Only declare the symbols corresponding to foreign types if they're not declared elsewhere. Follow the usual convention as above. * effi.c (FFI_TPTR): Change symbol names here. * effi.c (Fffi_basic_type_p): Ditto. * effi.c (ffi_canonicalise_type): Ditto. * effi.c (Fffi_size_of_type): Ditto. * effi.c (Fmake_ffi_object): Ditto. * effi.c (Fffi_make_pointer): Ditto. * effi.c (Fffi_load_library): Ditto. * effi.c (ffi_type_align): Ditto. * effi.c (ffi_fetch_foreign): Ditto. * effi.c (Fffi_fetch): Ditto. * effi.c (Fffi_aref): Ditto. * effi.c (Fffi_store): Ditto. * effi.c (Fffi_aset): Ditto. * effi.c (Fffi_address_of): Ditto. * effi.c (Fffi_lisp_object_to_pointer): Ditto. * effi.c (extffi_setup_argument): Ditto. * effi.c (Fx_device_display): Ditto. * effi.c (ffi_callback_call_x86): Ditto. * effi.c (Fffi_make_callback): Ditto. * effi.c (syms_of_ffi): Use DEFSYMBOL where appropriate, document an oddity with Qffiobjectp. * general-slots.h: Move Qshort, Qvoid here. * lisp.h: Remove Qshort, Qvoid from here. * map.c: Ditto. * map.c (map_LTX_init): Ditto. * mule/file-coding.c: Ditto. * mule/file-coding.c (syms_of_file_coding): Ditto. * mule/file-coding.h: Ditto. Signed-off-by: Aidan Kehoe Signed-off-by: Steve Youngs :100644 100644 8f68d50... 8859a04... M src/effi.c :100644 100644 27a949f... d5b194c... M src/general-slots.h :100644 100644 2afac73... e41c4c8... M src/lisp.h :100644 100644 2417209... a771287... M src/map.c :100644 100644 eeb28a1... 214d447... M src/mule/file-coding.c :100644 100644 1f00cf3... b42ab15... M src/mule/file-coding.h commit f92fd21ab4ce4207d433d88da21d08eb9244616d Author: Nelson Ferreira Date: Wed Jan 18 15:34:07 2012 -0500 Coverity: FORWARD NULL: CID 54, 53, 52 * src/ui/X11/xgccache.c (gc_cache_lookup): Refactor abort() flow through to shut up coverity. Signed-off-by: Nelson Ferreira :100644 100644 f6fbaaf... 2f24105... M src/ui/X11/xgccache.c commit 84530dd18aae423c71530024138d6efdd49e9c1b Author: Nelson Ferreira Date: Wed Jan 18 15:29:11 2012 -0500 Coverity: Forward NULL: CID 59, 58, 56 * src/ui/lwlib/lwlib-Xaw.c (xaw_generic_callback): Make sure you do not dereference possible NULL val. * src/ui/lwlib/lwlib-Xaw.c (wm_delete_window): Make sure widget and kids are only used when valid. * src/ui/lwlib/lwlib.c (replace_widget_value_tree): Make sure node is only used if != NULL. * src/ui/lwlib/lwlib.c (lw_map_widget_values): Make sure info is only used if != NULL. Signed-off-by: Nelson Ferreira :100644 100644 acdae40... fdfe288... M src/ui/lwlib/lwlib-Xaw.c :100644 100644 f0d257b... 8730a4e... M src/ui/lwlib/lwlib.c commit 04a8b7880c5fa9ccdc8c8a11af65c2abdf10f184 Author: Nelson Ferreira Date: Wed Jan 18 14:51:21 2012 -0500 Coverity: CHAR_IO: CID 5,6,7,9 * lib-src/make-docfile.c (skip_white): Use proper return type of getc * lib-src/make-docfile.c (read_lisp_symbol): Ditto * src/signal.c (interrupt_signal): Ditto * lib-src/make-docfile.c (scan_c_file): Do proper casting * lib-src/make-docfile.c (get_dyna_doc): Let the casting implementation do the truncation. Signed-off-by: Nelson Ferreira :100644 100644 f00ea33... 94f6acd... M lib-src/make-docfile.c :100644 100644 9251a0a... 9f9940a... M src/signal.c commit da4b7ebceb52467c7b4aad9e0bda5d974bb623cc Author: Nelson Ferreira Date: Wed Jan 18 13:11:14 2012 -0500 Coverity: UNINIT: CID 393 * src/print.c (write_string_to_stdio_stream): handle the case where the transcoding fails. Signed-off-by: Nelson Ferreira :100644 100644 ac733f2... 5ce5549... M src/print.c commit c67a873ae6b29bd63d3f7dd8de578eb301d1d6fb Author: Nelson Ferreira Date: Wed Jan 18 13:06:23 2012 -0500 Coverity: UNINIT: CID 397 * src/buffer.c (directory_is_current_directory): Handle the case of failed transcoding by attempting to use the non-transcoded version. There is a high chance it is proper. Worst case it will also fail, like the bad conversion would have prompted. Signed-off-by: Nelson Ferreira :100644 100644 734cb7b... 5a8fd89... M src/buffer.c commit 8e26fe35b671025c55641b6b9bdc04e516f408fc Author: Nelson Ferreira Date: Wed Jan 18 13:02:11 2012 -0500 Coverity: UNINIT: CID 398 * src/effi.c (Fffi_store): Make sure tmp is only used in the mule case if transcoding was proper. Signed-off-by: Nelson Ferreira :100644 100644 496e9b9... 8f68d50... M src/effi.c commit 5e2d1c41c90e747177da164e89af6d03adc0c17d Author: Nelson Ferreira Date: Wed Jan 18 13:00:56 2012 -0500 Coverity: UNINIT: CID 399 * src/effi.c (Fffi_store): Make sure val_ext is only used if transcoding was successful. Signed-off-by: Nelson Ferreira :100644 100644 ded16d4... 496e9b9... M src/effi.c commit 7de0f0c6b7b8237b80cd7ad619e72b4a56924280 Author: Nelson Ferreira Date: Wed Jan 18 12:58:57 2012 -0500 Coverity: Uninit: CID 400 * src/emacs.c (decode_path): make sure to return Qnil if transcoding failed. Signed-off-by: Nelson Ferreira :100644 100644 b4fd41f... 3ac6f2e... M src/emacs.c commit dbeb4e4fa479be0ee96460a47f22f4de811f2380 Author: Nelson Ferreira Date: Wed Jan 18 12:57:36 2012 -0500 Coverity: UNINIT: CID 401 * src/media/media.c (Fmake_media_stream): make sure the stream is only created if transcoding was ok. Signed-off-by: Nelson Ferreira :100644 100644 a5d06c5... 386026c... M src/media/media.c commit 65f8ed4bdb713c8b4db7bddd9b168678305abf73 Author: Nelson Ferreira Date: Wed Jan 18 12:35:32 2012 -0500 Fix build Signed-off-by: Nelson Ferreira :100644 100644 2dc6755... 457f7b3... M src/ui/X11/select-x.c commit 594ea6d9dbd9971d84ec4bedd70f71aef66ded62 Author: Nelson Ferreira Date: Wed Jan 18 12:34:57 2012 -0500 Fix build Signed-off-by: Nelson Ferreira :100644 100644 324dfa2... 2dc6755... M src/ui/X11/select-x.c commit c5efdef56f685686524978f79f045c125e6dbcd3 Author: Nelson Ferreira Date: Wed Jan 18 12:26:44 2012 -0500 Coverity: UNINIT: CID 402 * src/print.c (Falternate_debugging_output): Make sure to handle the case where transcoding failed. Signed-off-by: Nelson Ferreira :100644 100644 d024013... ac733f2... M src/print.c commit 1fb5a570506f1e840244607344c83fc13f42f54b Author: Nelson Ferreira Date: Wed Jan 18 12:23:45 2012 -0500 Coverity: UNINIT: CID 403 * src/ui/X11/gui-x.c (button_item_to_widget_value): Make sure intname is only used if properly transcoded. Signed-off-by: Nelson Ferreira :100644 100644 1483785... 33d1217... M src/ui/X11/gui-x.c commit 44ef07bf010ea6d6458e656536d6d27052229a50 Author: Nelson Ferreira Date: Wed Jan 18 12:22:43 2012 -0500 Coverity: UNINIT: CID 405, 404 * src/ui/X11/frame-x.c (x_set_frame_properties): Make sure extval is only used if properly transcoded. * src/ui/X11/select-x.c (lisp_data_to_selection_data): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 d709600... 1dffd75... M src/ui/X11/frame-x.c :100644 100644 5a2ce55... 324dfa2... M src/ui/X11/select-x.c commit 08216bc53daf097dec8b5007a7936dad62309c49 Author: Nelson Ferreira Date: Wed Jan 18 12:00:24 2012 -0500 Coverity: UNUSED: CID 427 * src/ui/insdel.c (init_buffer_text): Get rid of unused Signed-off-by: Nelson Ferreira :100644 100644 6459f7c... bd71546... M src/ui/insdel.c commit 43673e8ac4bdc0233c3fdc05e157565c8753e584 Author: Nelson Ferreira Date: Wed Jan 18 11:57:17 2012 -0500 Coverity: Forward NULL: CID 439 * src/fns.c (concat): Manually skip and abort when string_result_ptr is NULL. Coverity is actually right here, because when we are in a fatal error handling, assert will be a no-op, so we better just put an abort for the other cases and not try to dereference... Signed-off-by: Nelson Ferreira :100644 100644 fbde501... d60e860... M src/fns.c commit 55b0ffb0d07dafe1a954edd6f297c2640fd27ae6 Author: Nelson Ferreira Date: Wed Jan 18 11:42:58 2012 -0500 Coverity: UNINIT: CID 599 * src/emacs.c (run_emacs_from_temacs): Make sure the arguments were really transcoded before using them Signed-off-by: Nelson Ferreira :100644 100644 7d94271... b4fd41f... M src/emacs.c commit 279da956ca93015b9d058922416626cccedd745e Author: Nelson Ferreira Date: Wed Jan 18 11:39:21 2012 -0500 Coverity: UNINIT: CID 600 * src/ui/X11/objects-x.c (x_find_charset_font): Make sure intname is only used if transcoding worked properly. Signed-off-by: Nelson Ferreira :100644 100644 6419630... f288b16... M src/ui/X11/objects-x.c commit 6222a6574476848e1358c8d880cb01be1da2094b Author: Nelson Ferreira Date: Wed Jan 18 11:37:32 2012 -0500 Coverity: UNINIT: CID 601 * src/ui/glyphs-eimage.c (jpeg_instantiate): Make sure bytes is only used if properly transcoded. Signed-off-by: Nelson Ferreira :100644 100644 8f60fa0... 2704f1d... M src/ui/glyphs-eimage.c commit b2cd5d5c18992a1eb3015b07a62aa853bd750ed2 Author: Nelson Ferreira Date: Sat Jan 14 22:48:58 2012 -0500 Add a couple of missing semicolons on last commit Signed-off-by: Nelson Ferreira :100644 100644 86fbad2... 64ad7f8... M src/buffer.h commit abd5ba930f3eff1a60d7a1380a1fa3760e2ed94c Author: Nelson Ferreira Date: Sat Jan 14 22:45:25 2012 -0500 Fix build * src/buffer.h (TO_EXTERNAL_FORMAT): Move assertion up so that macro can be used as single statement. * src/buffer.h (TO_INTERNAL_FORMAT): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 4c5a81e... 86fbad2... M src/buffer.h commit d68824ecf59c0729731cc36644d220a3a0435d73 Author: Nelson Ferreira Date: Sat Jan 14 22:32:04 2012 -0500 Add some sanity assertions to format conversions. * src/buffer.h (TO_EXTERNAL_FORMAT): Add additional assert of validity after conversion. * src/buffer.h (TO_INTERNAL_FORMAT): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 4fab508... 4c5a81e... M src/buffer.h commit cbc25b994b0083d3a224a40997ca3c7b83b7f396 Author: Nelson Ferreira Date: Sat Jan 14 22:26:00 2012 -0500 Coverity: UNINIT: CID 409,408,407,406 * src/ui/glyphs-eimage.c (rawrgb_instantiate): Only instantiate image if the data was properly transcoded. * src/ui/glyphs-eimage.c (png_instantiate): Ditto. In this case, signal_image_error is best due to complexity. * src/ui/glyphs-eimage.c (gif_instantiate): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 90bad38... 8f60fa0... M src/ui/glyphs-eimage.c commit 911f959f5b57ac2f6aa040a445b9087ee36d313c Author: Nelson Ferreira Date: Sat Jan 14 22:12:48 2012 -0500 Coverity: UNINIT: CID 410 * src/ui/glyphs-eimage.c (rawrgba_instantiate): Make sure data is only used if conversion was proper. Signed-off-by: Nelson Ferreira :100644 100644 2b7e129... 90bad38... M src/ui/glyphs-eimage.c commit b8dfdeb05644f538a164c351d652efbf30225ca2 Author: Nelson Ferreira Date: Sat Jan 14 22:05:53 2012 -0500 Coverity: UNREACHABLE: CID 426, 425, 424, 423, 422, 421 * src/openssl.c (ossl_digest_fun): Just appease Coverity and add do the while(0)... * src/openssl.c (ossl_cipher_fun): Ditto. * src/openssl.c (OSSL_CHECK_PROCESS): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 5ad630b... 6c59082... M src/openssl.c commit cc4843fb8ee352c9cb5ae52398edc4e4f7577fb7 Author: Nelson Ferreira Date: Sat Jan 14 21:56:20 2012 -0500 Coverity: UNINIT: CID 453 * src/ui/glyphs-eimage.c (tiff_instantiate): Make sure file is properly encoded before using it. This one is a bit uglier due to the custom unwind here for error handling. Signed-off-by: Nelson Ferreira :100644 100644 18f2153... 2b7e129... M src/ui/glyphs-eimage.c commit f85a86969739ee375c9d9f18a1791c85a9a51fae Author: Nelson Ferreira Date: Sat Jan 14 21:47:51 2012 -0500 Coverity: Uninit: CID 473 * src/media/media-sndfile.c (media_sndfile_open): Make sure to only call sf_open if file name was properly converted. Signed-off-by: Nelson Ferreira :100644 100644 5bf16bb... d6e86da... M src/media/media-sndfile.c commit 488e58bd0bb3f3af02c08fbe36a49a4ecf6afb26 Author: Nelson Ferreira Date: Sat Jan 14 21:43:54 2012 -0500 Coverity: Char IO: CID 595 * lib-src/make-docfile.c (get_dyna_doc): Make sure to properly downcast the result of getc to char, after checking for its validity (ie != -1). Signed-off-by: Nelson Ferreira :100644 100644 5ddd801... f00ea33... M lib-src/make-docfile.c commit 93104f52834252c256cd3333dcb75b3e72e8449e Author: Nelson Ferreira Date: Sat Jan 14 21:37:21 2012 -0500 Coverity: No effect: CID 598 * src/media/media-mad.c (media_mad_open): Use long for result of ftell. Previous use of size_t could cause a bad ftell to be considered a maximum size media file... Later the positive size has to be cast to size_t for storage in the structure. Signed-off-by: Nelson Ferreira :100644 100644 a4b4a4c... ea6a5c7... M src/media/media-mad.c commit d476f814788a4e1330bf7142c57ba58918590c97 Author: Nelson Ferreira Date: Sat Jan 14 21:27:31 2012 -0500 Coverity: LOCK: CID 597 * src/media/sound-esd.c (sound_esd_play): Add missing unlock Signed-off-by: Nelson Ferreira :100644 100644 262b351... 89e70e7... M src/media/sound-esd.c commit 0c0a25eede944b4401748984e6f126c6aaf54afb Author: Steve Youngs Date: Sun Jan 15 11:56:36 2012 +1000 Get rid of crusty old stuff from lib-src. We inherited a boat load of stuff in lib-src when we forked from XEmacs, it's high time we got rid of all that cave-man bit-rot. This changeset gets rid of the stuff in lib-src that nobody under the age of 30 has even heard of, let alone ever used. * lib-src/Makefile.am (dist_bin_SCRIPTS): Removed. * lib-src/Makefile.am (dist_archlib_SCRIPTS): Removed. * lib-src/Makefile.am (stage1): Remove $dist_bin_SCRIPTS. * etc/Makefile.am (dist_manone_DATA): Remove gnuattach.1, gnudoit.1. * etc/gnuserv.1: Remove mention of gnudoit/gnuattach * lib-src/gnuserv.c (permitted): Don't call it 'gnudoit' in error string, it's 'gnuclient'. * lib-src/gnuserv.c (handle_internet_request): Ditto. * lib-src/gnuclient.c (pass_signal_to_emacs): Call it 'gnuclient' in error string. * lisp/gnuserv.el: Remove mention of gnudoit. * lisp/menubar-items.el (default-menubar): Call it gnuclient for remote Emacs-W3 entry. * etc/README: Remove mention of gnudoit, gnuattach Signed-off-by: Steve Youngs :100644 100644 d24b572... 6926eb0... M etc/Makefile.am :100644 100644 17290c8... 61a9c83... M etc/README :100644 000000 bbe2227... 0000000... D etc/gnuattach.1 :100644 000000 bbe2227... 0000000... D etc/gnudoit.1 :100644 100644 f649172... 8220732... M etc/gnuserv.1 :100644 100644 dd9ff47... 9a2788a... M lib-src/Makefile.am :100644 100644 f6ac391... 1fdc26b... M lib-src/gnuclient.c :100755 000000 bfeff77... 0000000... D lib-src/gnudoit :100644 100644 3330e2a... be45a61... M lib-src/gnuserv.c :100755 000000 ac1dc02... 0000000... D lib-src/gzip-el.sh :100644 000000 cf048df... 0000000... D lib-src/leditcfns.c :100755 000000 f954e54... 0000000... D lib-src/rcs-checkin :100755 000000 30e898d... 0000000... D lib-src/rcs2log :100755 000000 3ebee50... 0000000... D lib-src/vcdiff :100644 100644 42a1657... 39c84f5... M lisp/gnuserv.el :100644 100644 1c1accd... a1c106d... M lisp/menubar-items.el commit 7cd2ebb853e2f193637f4f803894d3745d3d0eda Author: Nelson Ferreira Date: Sat Jan 14 00:29:29 2012 -0500 Update README. Give novice advice in git-to-steve.sh Signed-off-by: Nelson Ferreira :100644 100644 b99a846... 0999b12... M contrib/README :100755 100755 5876eeb... 7e59376... M contrib/git-to-steve.sh commit baa7fa3e41833f51af3cca3efdc316bcd72eb41a Author: Nelson Ferreira Date: Sat Jan 14 00:04:35 2012 -0500 Add the sample git post-receive hook and update README Signed-off-by: Nelson Ferreira :100644 100644 35ed106... b99a846... M contrib/README :000000 100644 0000000... 4be5840... A contrib/git-post-receive-hook.sample commit 520872584ecd6dc7d363f8033c62b8c033d58668 Author: Nelson Ferreira Date: Fri Jan 13 23:45:45 2012 -0500 Add clear copyright notices to the scripts I contributed Signed-off-by: Nelson Ferreira :100755 100755 2b7f9d2... ef4d2c5... M contrib/do_builds.sh :100755 100755 88db014... 5876eeb... M contrib/git-to-steve.sh :100755 100755 75027a0... 7f1fc36... M contrib/make-pkg.sh :100755 100755 9b2df67... ff126a4... M contrib/report-build-failure.sh :100755 100755 9943136... 45e71d8... M contrib/tar-build-failure.sh :100644 100644 0767bfe... 54a6a6f... M contrib/tty-colors.c commit 5849acc988c15c8666a6a7121e8045c0cb0ea47c Author: Steve Youngs Date: Sat Jan 14 11:00:12 2012 +1000 missing paren Signed-off-by: Steve Youngs :100644 100644 79ef424... 6d3482f... M src/media/media-sox.c commit 5b049304111136c249b6f95e3d07b4eb526d0621 Author: Nelson Ferreira Date: Fri Jan 13 19:51:20 2012 -0500 Fix build * src/media/media-sox.c (media_sox_open): Fix stupid typo Signed-off-by: Nelson Ferreira :100644 100644 79ef424... 6d3482f... M src/media/media-sox.c commit aa898d17f74bf5c6d4b1879aa27d26da73347ed0 Author: Nelson Ferreira Date: Fri Jan 13 17:59:37 2012 -0500 Coverity: UNINIT: CID 474 * src/media/media-sox.c: make sure file conversion is proper Signed-off-by: Nelson Ferreira :100644 100644 0237366... 79ef424... M src/media/media-sox.c commit a99b8a18c91d9418b83594688c8097278eb2ea2b Author: Nelson Ferreira Date: Fri Jan 13 17:56:57 2012 -0500 Coverity: DEADCODE: CID 578 * src/print.c (SXE_VSNPRINT_VA): Fix the macro so that error in snprintf is actually detected, instead of masked because of the buffer growth loop. Signed-off-by: Nelson Ferreira :100644 100644 4f8e3bc... d024013... M src/print.c commit 0de636e8153fc7bb650f1e057e1bb91d4abf4f6d Author: Nelson Ferreira Date: Fri Jan 13 17:51:16 2012 -0500 Coverity: Checked return: CID 582 * src/media/media-internal.c (parsewave): Check the return of waverequire, because we are trying to align the stream, but it may still be fatal. Also fix the "flow" through of fatal error parsing WAVE file in case wvSoundChuck which do not sound proper. Signed-off-by: Nelson Ferreira :100644 100644 5ef4249... 8d393aa... M src/media/media-internal.c commit c74531d9fa58ced7de98c967c4740d66ce9a0740 Author: Nelson Ferreira Date: Fri Jan 13 17:43:25 2012 -0500 Coverity: Missing lock: CID 584 * src/media/sound-esd.c (sound_esd_play): Surround play_state change with the necessary lock. Signed-off-by: Nelson Ferreira :100644 100644 110f5af... 262b351... M src/media/sound-esd.c commit ae278c4b0ca9b2066113e45c851fc48f3b9095dc Author: Nelson Ferreira Date: Fri Jan 13 17:41:25 2012 -0500 Coverity: Negative Returns: CID 585 * src/media/media-internal.c (media_internal_analyse_stream): Only close the fd if it is valid, ie >= 0. Signed-off-by: Nelson Ferreira :100644 100644 80455ef... 5ef4249... M src/media/media-internal.c commit 11604970de6fee07e0173c26e46470485e47ba61 Author: Nelson Ferreira Date: Fri Jan 13 17:37:14 2012 -0500 Coverity: UNINIT: CID 592 * src/media/media-internal.c (media_internal_analyse_stream): Make sure that only if conversion to external format is successful we try to open the file otherwise return as if file open failed. Signed-off-by: Nelson Ferreira :100644 100644 e7a5c92... 80455ef... M src/media/media-internal.c commit 9c156689743b4369a9f54b15dc07f6b774d60817 Author: Nelson Ferreira Date: Fri Jan 13 17:24:14 2012 -0500 Coverity: NO_EFFECT: CID 594 * lib-src/gnuslib.c (connect_to_unix_server): Use int for sz which is the proper return type of snprintf. Signed-off-by: Nelson Ferreira :100644 100644 e6d3ec8... c15520f... M lib-src/gnuslib.c commit ab8548447474d7caf9924345787de22bdb3f45cd Author: Nelson Ferreira Date: Fri Jan 13 17:22:09 2012 -0500 Coverity: UNINIT: CID 593 Make sure file name is not used uninitialized. : Negative Returns: CID 586: Make sure file size is proper * src/media/media-mad.c (media_mad_open): Guard fopen against bad EXTERNAL_FORMAT conversion. Also make sure that if ftell is not successful the function terminates Signed-off-by: Nelson Ferreira :100644 100644 07a74f9... a4b4a4c... M src/media/media-mad.c commit 66e90621df7d29616f7a8b0c843af51d1de48c15 Author: Nelson Ferreira Date: Fri Jan 13 00:48:40 2012 -0500 Coverity: CHAR_IO: CID 595 * lib-src/make-docfile.c (get_dyna_doc): Make explicit the discard of non existing bits on the getc call assignment to the saved string. Signed-off-by: Nelson Ferreira :100644 100644 5ddd801... a45e496... M lib-src/make-docfile.c commit 280ebe60c41fedd465fb7fc67da669cfdc6216f1 Author: Nelson Ferreira Date: Thu Jan 12 10:23:40 2012 -0500 Coverity: NEGATIVE_RETURNS: CID 588 * src/ui/TTY/gpmevent.c (restore_gpm_state): Make sure that fd is >= 0 before accesing the state array. * src/ui/TTY/gpmevent.c (store_gpm_state): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 41890bd... 2916ce2... M src/ui/TTY/gpmevent.c commit e2496c1aebecd9c86233d51b94c6c194e4a91a19 Author: Nelson Ferreira Date: Thu Jan 12 10:19:15 2012 -0500 Coverity: NULL returns: CID 589 * src/process-unix.c (allocate_pty): Make sure slave_name is not NULL, since that is a possible return from ttyname. Signed-off-by: Nelson Ferreira :100644 100644 a9a1296... 6cdab37... M src/process-unix.c commit 268eb13c36ffec77dba8766e551827dcc1308f72 Author: Nelson Ferreira Date: Thu Jan 12 10:14:34 2012 -0500 Coverity: Resource leak: CID 590 * src/media/media-internal.c (media_internal_analyse_stream): free data in the case of failed open. Signed-off-by: Nelson Ferreira :100644 100644 ac6c32a... e7a5c92... M src/media/media-internal.c commit 24394f1bb21f7dd43606cd2c3c3af6be9bd10d79 Author: Nelson Ferreira Date: Thu Jan 12 10:12:50 2012 -0500 Coverity: Resource leak: CID 591 * src/media/media-mad.c (media_mad_open): free sd on unknown driver. Signed-off-by: Nelson Ferreira :100644 100644 4fd041a... 07a74f9... M src/media/media-mad.c commit cc0dd2038afaee5c90db731bbfe110745ed3f1d7 Author: Nelson Ferreira Date: Thu Jan 12 08:29:59 2012 -0500 Fix switch warnings in xlwscrollbar * src/ui/lwlib/xlwscrollbar.c (call_callbacks): Add default to switch. * src/ui/lwlib/xlwscrollbar.c (timer): Init reason to XmCR_NONE. Assert that ARM_NONE cannot happen in switch. * src/ui/lwlib/xlwscrollbar.c (Select): Add fall-through case for BUTTON_NONE. Add default case for another switch. Signed-off-by: Nelson Ferreira :100644 100644 52bd7fc... 0ebd01a... M src/ui/lwlib/xlwscrollbar.c commit 7f35191af2879c1993a1cde9780863bd5ba2cf9c Author: Nelson Ferreira Date: Thu Jan 12 08:27:26 2012 -0500 Fix switch warnings in media * src/media/media.c: New Qunavailable symbol. * src/media/media.c (Fmedia_properties): Default driver to Qunavailable. Add case labels for Xine and Gstreamer. * src/media/media.c (syms_of_media): init Qunavailable. Signed-off-by: Nelson Ferreira :100644 100644 7840979... a5d06c5... M src/media/media.c commit eb70212d83e1dfaf69f7120ebf8a7d17919b5646 Author: Nelson Ferreira Date: Thu Jan 12 08:25:00 2012 -0500 Remove warnings * src/regex.c (POP_FAILURE_POINT): Move DEBUG_STATEMENT to comply with C variable declaration rules. Cast the POP_FAILURE_POINTER return to proper const-ness. * src/regex.c (re_match_2_internal): Make re_char *'s d and dend const. Make scope p2 char* const. Make pdummy and sdummy const. Remove old comment. Signed-off-by: Nelson Ferreira :100644 100644 84d21f3... bcb0f30... M src/regex.c commit e8a65cc0df0ae4dcf2f331b816eece8f8a26fd53 Author: Nelson Ferreira Date: Wed Jan 11 22:54:57 2012 -0500 Coverity: Reverse INULL: CID 204 * modules/ase/ase-interval.c (_ase_unite_intervals_intr): Defer the call to ase_cartesion_dimension so that it does not try to derefence an invalid argument. As a side benefit, it will be faster in the trivial cases. Signed-off-by: Nelson Ferreira :100644 100644 f8e2c71... 8664168... M modules/ase/ase-interval.c commit 1316a38e35da93d9e4ccc495a64bea558e1b087b Author: Nelson Ferreira Date: Wed Jan 11 22:52:48 2012 -0500 Coverity: Reverse INULL: CID:207 * src/media/media.c (media_stream_finalise): Return immediately if the stream is NULL Signed-off-by: Nelson Ferreira :100644 100644 4ce4417... 7840979... M src/media/media.c commit 87bf09c82cea7b63cb51d3b72581c3df742bf7ce Author: Nelson Ferreira Date: Wed Jan 11 22:51:06 2012 -0500 Coverity: Reverse Negative: CID:209 * src/mule/file-coding.c (coding_system_from_mask): Make sure cat is >=0 before dereferencing in the loop. Signed-off-by: Nelson Ferreira :100644 100644 79c6fae... eeb28a1... M src/mule/file-coding.c commit 5639e154abedc4fdf8ed9632b770817e1c7e800e Author: Nelson Ferreira Date: Wed Jan 11 22:46:37 2012 -0500 COVERITY: Forward NULL: CID:40 * lib-src/ootags.c (analyse_regex): Return if regex_arg is NULL Signed-off-by: Nelson Ferreira :100644 100644 c2b6151... 6433c92... M lib-src/ootags.c commit a6c5fd2c1bc5958be16f82d057ebe6dbee1cae18 Author: Nelson Ferreira Date: Wed Jan 11 22:38:35 2012 -0500 Improved assert messages * src/emacs.c: make the assertions_dont_abort a variable instead of define. * src/emacs.c (assert_failed): Make the 3rd nested assertion abort instead of exit. Add an extra newline in the 2nd nested assertion. Add a short backtrace of up to 32767 entries to the 2nd nested assertion. Add a backtrace to to the 1st assert_failed. Signed-off-by: Nelson Ferreira :100644 100644 21a46ab... 7d94271... M src/emacs.c commit 59d506629cd290206ded3a27c1c267beed0c24cc Author: Nelson Ferreira Date: Wed Jan 11 22:23:56 2012 -0500 COVERITY: Forward NULL CID:46 * src/print.c (write_string_to_stdio_stream): Add appropriate diagnostics if no console nor stream provided... * src/print.c (Fexternal_debugging_output): Explict NULL initialization. Signed-off-by: Nelson Ferreira :100644 100644 9b95721... 4f8e3bc... M src/print.c commit 97f162eb6e0cb15cc5948ed728f8c4dc72cb9db3 Author: Nelson Ferreira Date: Wed Jan 11 20:57:09 2012 -0500 COVERITY: SECURE_TEMP - CID:345 * lib-src/movemail.c (lock_dot): Force umask to a sensible default, ie remove all group and other permissions Signed-off-by: Nelson Ferreira :100644 100644 b3fe1a8... 66456ed... M lib-src/movemail.c commit 934cf535c14287975b1d884c8961783ebb2b3433 Author: Nelson Ferreira Date: Wed Jan 11 20:37:50 2012 -0500 Small docstring update Signed-off-by: Nelson Ferreira :100644 100644 588df6e... 03a71d2... M lisp/lisp-initd.el commit bef8b64eba814c06190d31131d7e31e13874e463 Author: Steve Youngs Date: Wed Jan 11 14:50:11 2012 +1000 Ensure lisp-initd-dir is set early enough -- Closes bug #134 * lisp/lisp-initd.el (lisp-initd-dir): Move to startup.el to ensure it is set early enough to take affect. * lisp/startup.el (lisp-initd-dir): Moved here from lisp-initd.el. Signed-off-by: Steve Youngs :100644 100644 90b1579... bb408d9... M lisp/lisp-initd.el :100644 100644 6a878b8... 87f0643... M lisp/startup.el commit ec08ce0c5bf97f13ce2ace66c6559e4f1fe58e91 Author: Nelson Ferreira Date: Tue Jan 10 19:13:08 2012 -0500 Fix bug 134: * lisp/lisp-initd.el (lisp-initd-basename): replaces lisp-initd-prefix, it is the basename of .el, .elc and dirnames for the initd. * lisp/lisp-initd.el (lisp-initd-dir): Delay file expansion, and as such, just put as default the concat of user-init-directory and lisp-initd-basename. * lisp/lisp-initd.el (lisp-initd-compile): update argument names. Do the proper directory filename expansion here. Use lisp-initd-basename instead of the literal "init.d" * lisp/lisp-initd.el (lisp-initd-compile): Issue warning when a file was not included in compiled initd.el instead of the almost unnoticeable message in the lossage. * lisp/lisp-initd.el (lisp-initd-compile-and-load): Update argument names and interactive usage. Signed-off-by: Nelson Ferreira :100644 100644 90b1579... 510eb0d... M lisp/lisp-initd.el commit 25429252abf8a977df3b8f6a105c623dd5d7037e Author: Sebastian Freundt Date: Tue Jan 10 23:00:02 2012 +0000 Summary: fix, exec elisp in right thread context, closes bug #131 Keywords: bug fix #131 This changeset now most definitely fixes the sentinel issue of bug #131, this time the elisp is even executed in the main thread. * src/events/event-stream.c: move asyneq events (work started, ...) to execute_internal_event(), was in Fdispatch_event() Signed-off-by: Sebastian Freundt :100644 100644 66d4d02... c1f76f3... M src/events/event-stream.c commit fe31af04a24d98110ce27d96102c3296721cea3e Author: Steve Youngs Date: Wed Jan 11 00:18:05 2012 +1000 Fix a couple of byte-compiler warnings. * lisp/package-get.el (pui-bootstrap): Call #'pui-list-packages via #'declare-fboundp to silence byte-compiler. Also remove fake version hack. * lisp/ffi/ffi-wand.el (liquid-rescale): Call #'Wand:liquid-rescale via #'declare-fboundp to silence byte-compiler. Signed-off-by: Steve Youngs :100644 100644 50af716... 45819cb... M lisp/ffi/ffi-wand.el :100644 100644 1ea1f28... 4b4a2db... M lisp/package-get.el commit ccfa00554145c9e5fae8e2432086d3b01ea13faf Author: Sebastian Freundt Date: Tue Jan 10 11:18:18 2012 +0000 Summary: revert, bring asyneq handling of job events to original state Keywords: bug unfix #131 This effectively reverts all the changes made to the asyneq handling of job events, and also brings back bug #131. * src/events/worker-asyneq.c: revert Signed-off-by: Sebastian Freundt :100644 100644 c8f2c1c... 53fb356... M src/events/worker-asyneq.c commit 0383856c492695b6b79ad705e95f02b9d70a67ff Author: Steve Youngs Date: Tue Jan 10 20:48:15 2012 +1000 GTK eradication -- plug the holes left from removing gtk files. This changeset fixes all the problems that were the by-product of removing all the gtk related files from the repo. * configure.ac: Remove spurious gtk comment * etc/Makefile.am (dist_etc_DATA): Remove gtkrc. * lib-src/gnuclient.c (main): No more gtk. * lisp/cus-edit.el (custom-display): No more gtk. * lisp/device.el (device-type): Remove spurious gtk comment. * lisp/device.el (make-gtk-device): Removed. * lisp/dragdrop.el (gtk-start-drag): Removed. * lisp/dragdrop.el (gtk-start-drag-region): Removed. * lisp/faces.el (face-equal): Don't check for gtk device type. * lisp/faces.el (make-face-bold): Remove gtk case. * lisp/faces.el (make-face-italic): Ditto. * lisp/faces.el (make-face-bold-italic): Ditto. * lisp/faces.el (make-face-unbold): Ditto. * lisp/faces.el (make-face-unitalic): Ditto. * lisp/faces.el (init-device-faces): Don't init gtk, it's not there. * lisp/faces.el (init-frame-faces): Ditto. * lisp/faces.el (init-global-faces): Ditto. * lisp/font-menu.el (font-menu-preferred-resolution): Remove gtk * lisp/font-menu.el (font-menu-size-scaling): Ditto. * lisp/font.el (font-window-system-mappings): Ditto. * lisp/frame.el (make-frame-on-device): Remove spurious gtk doc string. * lisp/gnuserv.el (gnuserv-main-frame-function): No more gtk. * lisp/gnuserv.el (gnuserv-visible-frame-function): Ditto. * lisp/gnuserv.el (make-x-device-with-gtk-fallback): Removed. * lisp/gnuserv.el (gnuserv-edit-files): Remove gtk stuff. * lisp/menubar-items.el (default-menubar): Remove sample.gtkrc * lisp/minibuf.el (read-color-completion-table): No gtk. * lisp/specifier.el: Ditto. * src/emacs.c (console_type_create_select_gtk): Removed. * src/emacs.c (main_1): No gtk. * src/events/event-stream.c (init_event_stream): No gtk. * src/events/events.c: Don't #include console-gtk.h * src/events/events.c (event_equal): No gtk. * src/events/events.c (event_hash): Ditto. * src/events/events.c (format_event_object): Ditto. * src/general-slots.h: Remove gtk. * src/inline.c: Don't #include gtk headers. * src/lisp.h: No gtk. * src/lrecord.h: Remove gtk types. * src/symsinit.h: Remove gtk. * src/ui/console.c (select_console_1): No gtk. * src/ui/console.h: Ditto. * src/ui/console.h (CONSOLE_TYPESYM_WIN_P): No gtk. * src/ui/device.c (Fmake_device): No gtk. * src/ui/device.c (delete_device_internal): Ditto. * src/ui/device.h (DEVICE_GTK_P): Removed. * src/ui/device.h (CHECK_GTK_DEVICE): Removed. * src/ui/device.h (CONCHECK_GTK_DEVICE): Removed. * src/ui/device.h (DEVICE_MSWINDOWS_P): What the? REEEEMOOOOOVED!!! * src/ui/device.h (CHECK_MSWINDOWS_DEVICE): Gah! Gone! * src/ui/device.h (CONCHECK_MSWINDOWS_DEVICE): Sheesh! Outta here! * src/ui/faces.c (complex_vars_of_faces): No gtk. * src/ui/frame.h (FRAME_GTK_P): Removed. * src/ui/frame.h (CHECK_GTK_FRAME): Removed. * src/ui/frame.h (CONCHECK_GTK_FRAME): Removed. * src/ui/gutter.c (specifier_vars_of_gutter): No gtk. * src/ui/redisplay.c (init_redisplay): No gtk. * src/ui/toolbar.c: No gtk. * src/ui/window.c (specifier_vars_of_window): Ditto. * tests/Makefile.am (gtk_tests): Removed. * tests/Makefile.am (EXTRA_DIST): Removed gtk tests * src/events/events.h: Don't #include gdk stuff. * m4/sxe-aux.m4 (__SXE_MAKE_ADDER): Nuke gtk. * src/sysfile.h: No gtk. * src/ui/glyphs.c (pixmap_to_lisp_data): Remove gtk version. Signed-off-by: Steve Youngs :100644 100644 dae2446... 823f010... M configure.ac :100644 100644 285ef80... d24b572... M etc/Makefile.am :100644 100644 828cece... f6ac391... M lib-src/gnuclient.c :100644 100644 43c4b03... 8024079... M lisp/cus-edit.el :100644 100644 c00c23d... fcb1793... M lisp/device.el :100644 100644 1b17531... d763ab0... M lisp/dragdrop.el :100644 100644 247ea31... 63ae037... M lisp/faces.el :100644 100644 31fca37... 4f55c8a... M lisp/font-menu.el :100644 100644 011b224... 5829c68... M lisp/font.el :100644 100644 38c5a33... 6636a66... M lisp/frame.el :100644 000000 a778795... 0000000... D lisp/generic-widgets.el :100644 100644 a3d737c... 42a1657... M lisp/gnuserv.el :100644 100644 56388a3... 1c1accd... M lisp/menubar-items.el :100644 100644 e9974f1... 9cf418e... M lisp/minibuf.el :100644 100644 927890f... fade7c3... M lisp/specifier.el :100644 100644 4331e9c... bf34396... M m4/sxe-aux.m4 :100644 100644 555fa35... 21a46ab... M src/emacs.c :100644 100644 66d4d02... b659a4b... M src/events/event-stream.c :100644 100644 ee07e4f... 05c719b... M src/events/events.c :100644 100644 0ccc853... 87331da... M src/events/events.h :100644 100644 c03f280... 27a949f... M src/general-slots.h :100644 100644 da97660... dec2a64... M src/inline.c :100644 100644 a2280c1... 2afac73... M src/lisp.h :100644 100644 1435aba... b909267... M src/lrecord.h :100644 100644 be16cc8... 71e52bc... M src/symsinit.h :100644 100644 16a86b4... 86e4cf1... M src/sysfile.h :100644 100644 3f68aad... 952fa83... M src/ui/console.c :100644 100644 75ec3c6... 6c3ca0f... M src/ui/console.h :100644 100644 fc40164... 04d7a8b... M src/ui/device.c :100644 100644 6971a22... 51a8742... M src/ui/device.h :100644 100644 b10da46... 4beca9c... M src/ui/faces.c :100644 100644 f68765d... 5036d57... M src/ui/frame.h :100644 100644 ac2586e... 57d4268... M src/ui/glyphs.c :100644 100644 fd7ef01... b596bf2... M src/ui/gutter.c :100644 100644 dc8c3ba... 9b7e357... M src/ui/redisplay-output.c :100644 100644 0abf104... 839d9fd... M src/ui/redisplay.c :100644 100644 4714236... b531297... M src/ui/toolbar.c :100644 100644 8053a62... 287b1c8... M src/ui/window.c :100644 100644 ee2a3eb... 4edf25d... M tests/Makefile.am commit ff9432d976018199ca98ca9f2ef85b47ad0d9de6 Author: Sebastian Freundt Date: Tue Jan 10 09:23:10 2012 +0000 Summary: fix, another bug 131 attempt, dispatch the Keywords: bug fix #131 * src/events/worker-asyneq.c: dispatch directly Signed-off-by: Sebastian Freundt :100644 100644 faff894... c8f2c1c... M src/events/worker-asyneq.c commit 5b4e9ea98335fbc609a65805121c58354f52cc58 Author: Steve Youngs Date: Tue Jan 10 18:23:16 2012 +1000 GTK eradication -- file removal Signed-off-by: Steve Youngs :100644 000000 a860cf9... 0000000... D etc/gtkrc :100644 000000 2bc64d9... 0000000... D lisp/dialog-gtk.el :100644 000000 1b0764c... 0000000... D lisp/gdk.el :100644 000000 c5029e5... 0000000... D lisp/glade.el :100644 000000 464cfdc... 0000000... D lisp/gnome-widgets.el :100644 000000 1d6e9d2... 0000000... D lisp/gnome.el :100644 000000 003169d... 0000000... D lisp/gtk-compose.el :100644 000000 388f2d6... 0000000... D lisp/gtk-extra.el :100644 000000 c22445c... 0000000... D lisp/gtk-faces.el :100644 000000 318510c... 0000000... D lisp/gtk-ffi.el :100644 000000 f9135a6... 0000000... D lisp/gtk-file-dialog.el :100644 000000 5082922... 0000000... D lisp/gtk-font-menu.el :100644 000000 e3d11ec... 0000000... D lisp/gtk-glyphs.el :100644 000000 d8e4e48... 0000000... D lisp/gtk-init.el :100644 000000 4e3190b... 0000000... D lisp/gtk-iso8859-1.el :100644 000000 2a1a81e... 0000000... D lisp/gtk-marshal.el :100644 000000 af7aaaf... 0000000... D lisp/gtk-mouse.el :100644 000000 1dea854... 0000000... D lisp/gtk-package.el :100644 000000 f502cee... 0000000... D lisp/gtk-password-dialog.el :100644 000000 b5aded6... 0000000... D lisp/gtk-select.el :100644 000000 37f1068... 0000000... D lisp/gtk-widget-accessors.el :100644 000000 331c8e9... 0000000... D lisp/gtk-widgets.el :100644 000000 0272626... 0000000... D lisp/gtk.el :100644 000000 8f593ea... 0000000... D lisp/widgets-gtk.el :100644 000000 acec247... 0000000... D src/emacs-marshals.c :100644 000000 4fa40d9... 0000000... D src/emacs-widget-accessors.c :100644 000000 14bef31... 0000000... D src/glade.c :100644 000000 9bce485... 0000000... D src/gtk-glue.c :100644 000000 40dfb69... 0000000... D src/ui/Gtk/Makefile.am :100644 000000 2ef9eb7... 0000000... D src/ui/Gtk/console-gtk.c :100644 000000 c09df81... 0000000... D src/ui/Gtk/console-gtk.h :100644 000000 a0f7ebb... 0000000... D src/ui/Gtk/device-gtk.c :100644 000000 4fc8232... 0000000... D src/ui/Gtk/dialog-gtk.c :100644 000000 8c3057a... 0000000... D src/ui/Gtk/event-gtk.c :100644 000000 aabbe66... 0000000... D src/ui/Gtk/frame-gtk.c :100644 000000 4ed5509... 0000000... D src/ui/Gtk/gccache-gtk.c :100644 000000 1c27a8d... 0000000... D src/ui/Gtk/gccache-gtk.h :100644 000000 f771092... 0000000... D src/ui/Gtk/glyphs-gtk.c :100644 000000 8bdca71... 0000000... D src/ui/Gtk/glyphs-gtk.h :100644 000000 c04c274... 0000000... D src/ui/Gtk/gtk-xemacs.c :100644 000000 e35586a... 0000000... D src/ui/Gtk/gtk-xemacs.h :100644 000000 643a1c1... 0000000... D src/ui/Gtk/gui-gtk.c :100644 000000 06773db... 0000000... D src/ui/Gtk/gui-gtk.h :100644 000000 93a4c30... 0000000... D src/ui/Gtk/menubar-gtk.c :100644 000000 ee75350... 0000000... D src/ui/Gtk/native-gtk-toolbar.c :100644 000000 a4533b9... 0000000... D src/ui/Gtk/objects-gtk.c :100644 000000 bdbefe1... 0000000... D src/ui/Gtk/objects-gtk.h :100644 000000 e141605... 0000000... D src/ui/Gtk/redisplay-gtk.c :100644 000000 3f1be2b... 0000000... D src/ui/Gtk/scrollbar-gtk.c :100644 000000 b35a6a3... 0000000... D src/ui/Gtk/scrollbar-gtk.h :100644 000000 89e3ec0... 0000000... D src/ui/Gtk/select-gtk.c :100644 000000 518684b... 0000000... D src/ui/Gtk/toolbar-gtk.c :100644 000000 9b2da91... 0000000... D src/ui/Gtk/ui-byhand.c :100644 000000 e80ab33... 0000000... D src/ui/Gtk/ui-gtk.c :100644 000000 181a6d6... 0000000... D src/ui/Gtk/ui-gtk.h :100644 000000 5b8dd29... 0000000... D tests/gtk/UNIMPLEMENTED :100644 000000 3cdaf8e... 0000000... D tests/gtk/event-stream-tests.el :100644 000000 8b0faf9... 0000000... D tests/gtk/gnome-test.el :100644 000000 3752dd6... 0000000... D tests/gtk/gtk-embedded-test.el :100644 000000 5e7b00e... 0000000... D tests/gtk/gtk-extra-test.el :100644 000000 58690a8... 0000000... D tests/gtk/gtk-test.el :100644 000000 0e2760c... 0000000... D tests/gtk/gtk-test.glade :100644 000000 457e5d8... 0000000... D tests/gtk/statusbar-test.el :100644 000000 f006bd4... 0000000... D tests/gtk/toolbar-test.el :100644 000000 eef5265... 0000000... D tests/gtk/xemacs-toolbar.el commit a2f777bd44b2f19f02cc9fcb5e1bb40fe8c90be6 Author: Steve Youngs Date: Tue Jan 10 17:43:57 2012 +1000 GTK eradication -- the build chain. The GTK code in SXEmacs has been stagnating since 2000, 4 years before SXEmacs even came into existance. It was GTK version 1. Nobody, nowhere uses GTKv1 any more, so this stuff is going to /dev/null hell! * src/ui/Makefile.am: Don't add `Gtk' to SUBDIRS * src/Makefile.am: Don't add gtk to pdumplibs. * lisp/Makefile.am (corelispels): Remove all the gtk/gnome elisp. * lisp/dumped-lisp.el: Don't dump any gtk lisp. * m4/sxe-summary.m4: No more gtk. * m4/sxe-gui.m4 (SXE_CHECK_XT_DEPENDENCIES): Remove gtk stuff. * m4/sxe-gui.m4 (SXE_CHECK_GTK_DEPENDENCIES): Removed. * m4/sxe-gui.m4 (SXE_CHECK_UI_SUFFICIENCY): Don't subst gtk obj's * configure.ac: Remove all gtk nonsense. Signed-off-by: Steve Youngs :100644 100644 0cfe3e9... dae2446... M configure.ac :100644 100644 01e5fda... 95e46e1... M lisp/Makefile.am :100644 100644 c57c71a... c775066... M lisp/dumped-lisp.el :100644 100644 864b479... 390eb5c... M m4/sxe-gui.m4 :100644 100644 cf2ca67... 13b638b... M m4/sxe-summary.m4 :100644 100644 a7bb58a... 3c2b36a... M src/Makefile.am :100644 100644 b946f05... 4db4ea1... M src/ui/Makefile.am commit 4835c9e2f5a2cfb7a55c6e62485c6cbcf8d4fb80 Author: Steve Youngs Date: Tue Jan 10 10:43:58 2012 +1000 Fix the fix that fixes the fix to fix bug 131 * src/events/worker-asyneq.c (eq_worker_eaten_myself): Don't call asyneq_handle_event() * src/events/worker-asyneq.c (eq_worker_work_started): Ditto. Signed-off-by: Steve Youngs :100644 100644 cdb3b2e... faff894... M src/events/worker-asyneq.c commit feb9baff29a7088175056a2d7038e27db5448952 Author: Sebastian Freundt Date: Mon Jan 9 15:12:36 2012 +0000 Summary: cosmetics, clean up event-stream code Keywords: code hygiene This changeset brings event-stream.c to 21st century coding style and our 80 cols rule. * src/events/event-stream.c: big refactoring Signed-off-by: Sebastian Freundt :100644 100644 1a54fad... 66d4d02... M src/events/event-stream.c commit 4221196cf5d5defbc216c346ad83d37654ff7d6e Author: Sebastian Freundt Date: Mon Jan 9 13:13:55 2012 +0000 Summary: fix, actually dispatch events, fixes bug #131 Keywords: bug fix #131 This changeset makes sure that the communication between REPL event queue and delegation event queue (the one for the worker threads) actually work in both directions. Events put on the REPL event queue from within jobs that have been delegated are now announced to the event queue handler and hence executed, which in particular was the reason the sentinel wasn't invoked as described in bug #131. * src/events/worker-asyneq.c: call asyneq_handle_event() after enqueuing Signed-off-by: Sebastian Freundt :100644 100644 53fb356... cdb3b2e... M src/events/worker-asyneq.c commit bdaeea4bd8663e24ce6f6c2e841d397605353706 Author: Sebastian Freundt Date: Sun Jan 8 21:43:08 2012 +0000 Summary: cosmetics, conditionalise seemingly unused vars in movemail.c Keywords: refactor warn-fix This changeset conditionalises on MAIL_USE_POP to fix warnings that arise from writing to unused variables. * lib-src/movemail.c: put MAIL_USE_POP guards around poppass var Signed-off-by: Sebastian Freundt :100644 100644 86b6935... b3fe1a8... M lib-src/movemail.c commit 88f338097282449e9475451c32ff91f2963d03e0 Author: Sebastian Freundt Date: Sun Jan 8 11:09:53 2012 +0000 Summary: cosmetics, refactor large parts of make-docfile.c Keywords: refactor warn-fix This changeset refactors large parts of make-docfile.c, i.e. kill unused code and kludges, adhere to our 80 column policy and maintain our coding style throughout the file. * lib-src/make-docfile.c: refactor Signed-off-by: Sebastian Freundt :100644 100644 3d79747... 5ddd801... M lib-src/make-docfile.c commit 48f4b7f40665030b0e1a519175f3b7d7675bcad9 Author: Sebastian Freundt Date: Sun Jan 8 00:59:50 2012 +0000 Summary: fix, -Winline -> only if maximum warning output Keywords: bldchn code hygiene warn-fix This changeset fixes some inline related warnings by turning them off. * m4/sxe-acx_pthread.m4: enable -Winline only with_maximum_warning_output Signed-off-by: Sebastian Freundt :100644 100644 4648ac4... 83d1634... M m4/sxe-compiler.m4 commit d4d6b69d7c4117da88d4fad0f6a8ffd43319917a Author: Sebastian Freundt Date: Sun Jan 8 00:40:51 2012 +0000 Summary: fix, unused warnings in gnuserv.c Keywords: bldchn code hygiene warn-fix This changeset brings gnuserv.c to 21st century coding style and fixes warnings along. Note to myself: gnuserv is not v6-ready! Several locations assume for inet addresses to fit in an unsigned long which is so 1980. * lib-src/gnuserv.c: fix warnings and ennicen syntax Signed-off-by: Sebastian Freundt :100644 100644 85459b6... 3330e2a... M lib-src/gnuserv.c commit 86b9732336b4d7f711abb5e5004ca7ca4f98bd12 Author: Sebastian Freundt Date: Sat Jan 7 23:53:28 2012 +0000 Summary: fix, signedness and unused warnings in gnuserv et al. Keywords: bldchn code hygiene warn-fix This changeset brings some of the stuff in gnuclient.c to 21st century coding style and fixes warnings along. * lib-src/gnuclient.c: fix warnings and ennicen syntax Signed-off-by: Sebastian Freundt Conflicts: lib-src/gnuclient.c Signed-off-by: Sebastian Freundt :100644 100644 c6f28d5... 828cece... M lib-src/gnuclient.c commit 01a938e9216db247714c561a09ba692a50cabb31 Author: Sebastian Freundt Date: Sat Jan 7 23:46:38 2012 +0000 Summary: fix, clean up signedness problem in gnuserv and friends Keywords: bldchn code hygiene warn-fix This changeset introduces SNPRINTF, a macro that also ascertains that its result is >=0 and < than the size of the buffer printed into. * lib-src/gnuclient.c: migrate to SNPRINTF * lib-src/gnuserv.c: migrate to SNPRINTF * lib-src/gnuserv.h: provide SNPRINTF macro * lib-src/gnuslib.c: migrate to SNPRINTF Signed-off-by: Sebastian Freundt Conflicts: lib-src/gnuclient.c lib-src/gnuserv.c Signed-off-by: Sebastian Freundt :100644 100644 576581e... c6f28d5... M lib-src/gnuclient.c :100644 100644 25a6d3c... 85459b6... M lib-src/gnuserv.c :100644 100644 9ed0cb7... a112310... M lib-src/gnuserv.h :100644 100644 11ad8e2... e6d3ec8... M lib-src/gnuslib.c commit bdee0850bdf8134b322d768b12c45da3338b37f3 Author: Sebastian Freundt Date: Fri Jan 6 19:34:52 2012 +0000 Summary: cosmetics, declare yow internal functions static Keywords: bldchn * lib-src/yow.c: make local things static Signed-off-by: Sebastian Freundt :100644 100644 8f7df31... a644f07... M lib-src/yow.c commit eb09db8c9d9bce93f127386630632428e0f81619 Author: Sebastian Freundt Date: Fri Jan 6 19:33:27 2012 +0000 Summary: cosmetics, fix some signedness and shadow warnings in gnuclient Keywords: bldchn * lib-src/gnuclient.c: fix signedness warnings fix shadow warnings adhere to our coding style Signed-off-by: Sebastian Freundt Conflicts: lib-src/gnuclient.c Signed-off-by: Sebastian Freundt :100644 100644 f95a337... 576581e... M lib-src/gnuclient.c commit 1e2a299f11fc2d01113604dab2f403687e902a4d Author: Sebastian Freundt Date: Fri Jan 6 19:06:26 2012 +0000 Summary: cosmetics, fix some warnings about signedness Keywords: bldchn * lib-src/gnuslib.c: treat ints returned by snprintf() as size_t for assertions * src/regex.c: strictly return values from the enum as declared Signed-off-by: Sebastian Freundt Conflicts: lib-src/gnuslib.c lib-src/profile.c Signed-off-by: Sebastian Freundt :100644 100644 d665b30... 11ad8e2... M lib-src/gnuslib.c :100644 100644 f96f436... c8fa369... M lib-src/profile.c :100644 100644 a3da58b... 84d21f3... M src/regex.c commit 21837e38fadd0720e55a8270a76644c5ea3d5dba Author: Sebastian Freundt Date: Fri Jan 6 18:58:51 2012 +0000 Summary: chore, deactivate some warnings again (if not aggressive) Keywords: bldchn This changeset demotes some of the warning flags again to the special --with-maximum-warning-output option. * m4/sxe-compiler.m4: conditionalise on some warning switches again Signed-off-by: Sebastian Freundt :100644 100644 dac0909... 4648ac4... M m4/sxe-compiler.m4 commit ff28e1fc14a20224ad8fc0c643f1d9aaaaf5a995 Author: Sebastian Freundt Date: Sun Jan 8 02:42:39 2012 +0000 Summary: fix, bug 133, for real now Keywords: bug fix This changeset fixes 133 by doing everything right. * src/ui/X11/event-Xt.c: actually reset the old modifier to the bit it represents, this should fix 133 once and forever Signed-off-by: Sebastian Freundt :100644 100644 7650a8c... 236ecce... M src/ui/X11/event-Xt.c commit 28d20ac876ef18de2be73de507b3a13bde29f4e6 Author: Ruediger Meier Date: Sat Jan 7 19:53:16 2012 +0100 fix yow.c, include assert.h (was missing since cb837c1c) :100644 100644 f2cd154... 699d408... M lib-src/yow.c commit 8f8568a46c509b49fca34780b50acf720c3e3abe Author: Ruediger Meier Date: Sat Jan 7 19:45:31 2012 +0100 fix yow.c, correct else scope (broken since cb837c1c) :100644 100644 8f7df31... f2cd154... M lib-src/yow.c commit c6a3cb8dc768215cad36a4411a86c4fbbfae745e Author: Sebastian Freundt Date: Sat Jan 7 16:10:28 2012 +0000 Summary: cosmetics, prescind from using inlines for trivial one-off stuff Keywords: bldchn code hygiene * src/ui/X11/event-Xt.c: superfluous inlines are removed Signed-off-by: Sebastian Freundt :100644 100644 57159d5... 7650a8c... M src/ui/X11/event-Xt.c commit 78b88150cbef1b1230f98d26476c986c49cecbe7 Author: Sebastian Freundt Date: Sat Jan 7 16:07:36 2012 +0000 Summary: fix, final, use unsigned ints in modifier setup, fixes bug #133 Keywords: bug fix This fixes bug 133 finally. * src/ui/X11/event-Xt.c: make the bit set a bit wider Signed-off-by: Sebastian Freundt :100644 100644 3784b79... 57159d5... M src/ui/X11/event-Xt.c commit d2255f13c5b5d51c6ada55f61352f12d161d6641 Author: Sebastian Freundt Date: Sat Jan 7 10:19:37 2012 +0000 Summary: fix, tentative, use unsigned int:1 to avoid overflows, fixes bug #133 Keywords: bug fix This fixes bug 133 tentatively, a problem with the bitset seems to spoil the big de-nestification. However, it appears the bits have to be wider than I planned them to be, this is up to investigation, could be an alignment issue. * src/ui/X11/event-Xt.c: make the bit set a bit wider Signed-off-by: Sebastian Freundt :100644 100644 4670184... c3021a5... M src/ui/X11/event-Xt.c commit 369bfdd8e656c0963924f8ae8793e11b60220be1 Author: Sebastian Freundt Date: Fri Jan 6 12:24:45 2012 +0000 Summary: chore, kick ase extern inline Keywords: code hygiene build clang This changeset reviews ase code that erroneously used extern inlines directly, transform them to static inlines. * modules/ase/ase-cartesian.h: extern inline -> static inline * modules/ase/ase-heap.h: extern inline -> static inline * modules/ase/ase-neighbourhood.h: extern inline -> static inline * modules/ase/ase.h: extern inline -> static inline Signed-off-by: Sebastian Freundt :100644 100644 4a89750... 424e09e... M modules/ase/ase-cartesian.h :100644 100644 aa86f3e... 5dbc8e1... M modules/ase/ase-heap.h :100644 100644 ffe3582... f39a194... M modules/ase/ase-neighbourhood.h :100644 100644 8929e17... 27ec6dc... M modules/ase/ase.h commit 5e24af63ade2bfc5e5dfff588a06b4810a19e24f Author: Sebastian Freundt Date: Fri Jan 6 10:34:52 2012 +0000 Summary: chore, don't check for extern inline support anymore Keywords: code hygiene build clang This changeset drops the check for extern inline support (and compiler allergies to it) altogether, resorting instead to static inlines. * m4/sxe-compiler.m4: do not check for extern inline compiler allergies Signed-off-by: Sebastian Freundt :100644 100644 4cce877... dac0909... M m4/sxe-compiler.m4 commit 9f2372ef98f1bcf4c629d9fd79fe405d8bafa2ae Author: Sebastian Freundt Date: Fri Jan 6 09:03:48 2012 +0000 Summary: chore, crunch the number of extern_inline definitions Keywords: code hygiene build clang This changeset drops transitional extern_inline definitions so only pure C99 static inlines are used from now on. * src/sxe-utils.h: drop conditional extern_inline definitions leaving only static inline as expansion Signed-off-by: Sebastian Freundt :100644 100644 f43aa49... e30034f... M src/sxe-utils.h commit 80ba81ea399716719af4aed5eeb49e8718c5c617 Author: Nelson Ferreira Date: Thu Jan 5 01:35:08 2012 -0500 Remove casts which were not needed and causing comparison sign mismatch Signed-off-by: Nelson Ferreira :100644 100644 95a1866... 99c8942... M src/mule/mule-ccl.c commit ed70c04349cc3fa0161ba08128c377486eac54cb Author: Nelson Ferreira Date: Thu Jan 5 01:33:23 2012 -0500 Add prototype for emacs_tparam to avoid warning Signed-off-by: Nelson Ferreira :100644 100644 5cef1a9... db13b47... M src/ui/TTY/terminfo.c commit bb05cfff16464403ac435ecd39c22ec30f038901 Author: Nelson Ferreira Date: Thu Jan 5 01:32:39 2012 -0500 Change the pre-processor conditional to check for MPC_SET_UI_FR to avoid warning Signed-off-by: Nelson Ferreira :100644 100644 e10f8a4... 768bd0c... M src/ent/ent-mpc.c :100644 100644 f488ae6... 3c8ed35... M src/ent/ent-mpc.h commit 8a1372fb35fc126e1af57c5c23af343cd5f45504 Author: Nelson Ferreira Date: Thu Jan 5 01:31:31 2012 -0500 Add new Assert-Equal and Assert-Not-Equal macros to test-harness, which print the actual values in case of failure. Use instead of (Assert (equal)) and (Assert (not (equal))) Signed-off-by: Nelson Ferreira :100644 100644 a623216... 9df7dd6... M tests/automated/ase-heap-tests.el :100644 100644 45b9ce9... fcd8242... M tests/automated/base64-tests.el :100644 100644 841caa9... 152df84... M tests/automated/byte-compiler-tests.el :100644 100644 149983f... 7beb21e... M tests/automated/ccl-tests.el :100644 100644 6f1f5a3... 25f19ee... M tests/automated/database-tests.el :100644 100644 aa6f0e8... 3f2dd52... M tests/automated/ent-tests.el :100644 100644 0b747a9... 6c1df6d... M tests/automated/extent-tests.el :100644 100644 a8f1bfb... 6bea45b... M tests/automated/format-tests.el :100644 100644 75c0d75... f8816cf... M tests/automated/hash-table-tests.el :100644 100644 8a158b2... fd5ea98... M tests/automated/inplace-tests.el :100644 100644 da0b80b... 5d57aef... M tests/automated/lisp-tests.el :100644 100644 e28ead7... e439b69... M tests/automated/map-tests.el :100644 100644 683aded... 834a7b7... M tests/automated/md5-tests.el :100644 100644 a08d1c9... bb8ebf7... M tests/automated/mule-tests.el :100644 100644 0ad82b0... 8b58fd9... M tests/automated/skiplist-tests.el :100644 100644 601766f... 0305cc7... M tests/automated/symbol-tests.el :100644 100644 8a9cd1f... e9ca782... M tests/automated/test-harness.el :100644 100644 a87a927... ef069fd... M tests/automated/weak-tests.el commit a2e176a2d2f133af3bf89c38ab29d9dfa08bcdc1 Author: Nelson Ferreira Date: Wed Jan 4 23:05:52 2012 -0500 More warning suppressions * lib-src/gnuslib.c (connect_to_unix_server): Use size_t for sz * src/ui/X11/event-Xt.c (x_reset_modifier_mapping): Add full prototype to auto functions * src/ui/glyphs-eimage.c (png_instantiate): use png_uint_32 in loop * src/ui/lwlib/xlwmenu.c (parameterize_string): add new offset to keep signedness in comparison * src/ui/X11/glyphs-x.c (x_subwindow_query_geometry): add prototyp * lib-src/gnuslib.c (connect_to_internet_server): Use size_t to compare with sizeof. * src/alloc.c (garbage_collect): ditto. * src/buffer.c (Fgenerate_new_buffer_name): ditto. * src/dumper.c (pdump_file_try): ditto. * src/dumper.c (pdump_load): ditto. * src/editfns.c (Fencode_time): ditto. * src/editfns.c (Fencode_btime): ditto. * src/editfns.c (Fcurrent_time_zone): ditto. * src/extents.c (print_extent_1): ditto. * src/mule/input-method-xlib.c (EmacsXtCvtStringToXIMStyles): ditto. * src/mule/input-method-xlib.c (describe_Window): ditto. * src/print.c (SXE_VSNPRINT_VA): ditto. * src/print.c (write_hex_ptr): ditto. * src/print.c (printing_major_badness): ditto. * src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto. * src/process-unix.c (unix_open_network_stream): ditto. * src/process-unix.c (unix_open_network_server_stream): ditto. * src/process.c (make_process_internal): ditto. * src/strftime.c (add_num_time_t): ditto. * src/ui/TTY/objects-tty.c (Ffind_tty_color): ditto. * src/ui/TTY/objects-tty.c (Ftty_registered_color_list): ditto. * src/ui/TTY/redisplay-tty.c (term_get_fkeys_1): ditto. * src/ui/X11/device-x.c (read_locale_specific_resources): ditto. * src/ui/X11/device-x.c (x_init_device): ditto. * src/ui/X11/device-x.c (signal_if_x_error): ditto. * src/ui/X11/dialog-x.c (dbox_descriptor_to_widget_value): ditto. * src/ui/X11/event-Xt.c (x_keysym_to_emacs_keysym): ditto. * src/ui/X11/event-Xt.c (describe_event): ditto. * src/ui/X11/frame-x.c (color_to_string): ditto. * src/ui/X11/frame-x.c (x_set_initial_frame_size): ditto. * src/ui/X11/frame-x.c (Fx_window_id): ditto. * src/ui/X11/objects-x.c (truename_via_random_props): ditto. * src/ui/X11/scrollbar-x.c (x_create_scrollbar_instance): ditto. * src/ui/glyphs-eimage.c (tiff_error_func): ditto. * src/ui/glyphs-eimage.c (tiff_warning_func): ditto. * src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto. * src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto. * src/ui/lwlib/xlwgauge.c (GaugeExpose): ditto. * src/ui/lwlib/xlwgauge.c (MaxLabel): ditto. * src/ui/lwlib/xlwmenu.c (parameterize_string): ditto. * src/ui/lwlib/xlwtabs.c (XawTabsSetTop): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. Signed-off-by: Nelson Ferreira :100644 100644 b056d6a... d665b30... M lib-src/gnuslib.c :100644 100644 ab31f2d... 55af853... M src/alloc.c :100644 100644 0718a59... 734cb7b... M src/buffer.c :100644 100644 9e56aa0... 8987436... M src/dumper.c :100644 100644 98e7507... a32f51b... M src/editfns.c :100644 100644 e5c3ab8... 226a17c... M src/extents.c :100644 100644 7c10248... ef5c0bd... M src/mule/input-method-xlib.c :100644 100644 58789f6... 9b95721... M src/print.c :100644 100644 1af232f... a9a1296... M src/process-unix.c :100644 100644 4e345a5... cb5b035... M src/process.c :100644 100644 6f94d55... 84a685f... M src/strftime.c :100644 100644 5d3fcf0... 0be74fa... M src/ui/TTY/objects-tty.c :100644 100644 9e8d8b2... c8c8485... M src/ui/TTY/redisplay-tty.c :100644 100644 622106f... ccb39bd... M src/ui/X11/device-x.c :100644 100644 3c67ada... dfcfa84... M src/ui/X11/dialog-x.c :100644 100644 087c601... b4d8d51... M src/ui/X11/event-Xt.c :100644 100644 8367fe1... d709600... M src/ui/X11/frame-x.c :100644 100644 6888c8c... ba3b46b... M src/ui/X11/glyphs-x.c :100644 100644 af30648... 6419630... M src/ui/X11/objects-x.c :100644 100644 c3f0ce9... 0e06a97... M src/ui/X11/scrollbar-x.c :100644 100644 e3fc1e4... 18f2153... M src/ui/glyphs-eimage.c :100644 100644 0f32f5a... acdae40... M src/ui/lwlib/lwlib-Xaw.c :100644 100644 b6478b4... c308e9e... M src/ui/lwlib/xlwgauge.c :100644 100644 b25921f... 7b067d7... M src/ui/lwlib/xlwmenu.c :100644 100644 8a34596... 18abf45... M src/ui/lwlib/xlwtabs.c :100644 100644 12da833... 0abf104... M src/ui/redisplay.c commit 4c6794a5c5bcd7bf9a8f4b6c6c97098cf2c88f15 Author: Nelson Ferreira Date: Wed Jan 4 22:49:38 2012 -0500 More warning suppression * lib-src/etags.c (etags_strrchr): restore the register qualifier * lib-src/gnuclient.c (main): remove unneeded shadowed variable definition * lib-src/gnuclient.c (tell_emacs_to_resume): use size_to compare to sizeof * lib-src/gnuclient.c (filename_expand): ditto. * lib-src/gnuclient.c (main): ditto. * lib-src/gnuserv.c (unix_init): ditto. * lib-src/ootags.c (main): ditto. * lib-src/profile.c (get_time): ditto. Signed-off-by: Nelson Ferreira :100644 100644 f7be6c3... cdcc73c... M lib-src/etags.c :100644 100644 f83a607... f95a337... M lib-src/gnuclient.c :100644 100644 1fabe54... 25a6d3c... M lib-src/gnuserv.c :100644 100644 58611e2... c2b6151... M lib-src/ootags.c :100644 100644 8f9c324... f96f436... M lib-src/profile.c commit 2e1a362f74fcaf5506fe4dbd81dacb8c16ede53e Author: Nelson Ferreira Date: Wed Jan 4 22:45:03 2012 -0500 Get rid of the slew of warning in tags code * lib-src/etags.c (main): added missing case labels. * lib-src/etags.c (consider_token): ditto. * lib-src/etags.c (C_entries): ditto. * lib-src/etags.c (main): Made sure size was compared to sizeof as size_t . Signed-off-by: Nelson Ferreira :100644 100644 bf6c320... f7be6c3... M lib-src/etags.c commit 3a67580d6f26012e7fbda6f355a0fe89ceb6eff0 Author: Nelson Ferreira Date: Wed Jan 4 19:24:51 2012 -0500 Fix previous fix. Use X_CFLAGS, not X_FLAGS... Signed-off-by: Nelson Ferreira :100644 100644 5556bc4... a7bb58a... M src/Makefile.am :100644 100644 a8b1a2d... 9db3046... M src/ui/TTY/Makefile.am commit 8d9caf434f035567f791e283716b38d99b382668 Author: Sebastian Freundt Date: Wed Jan 4 13:33:18 2012 +0000 Summary: chore, refactor nested function construct in event-Xt.c Keywords: build clang This changeset replaces the nested function thing used for modifier mappings by ordinary function calls and a closure structure. * src/ui/X11/event-Xt.c (x_reset_modifier_mapping): auto inline foo -> Signed-off-by: Sebastian Freundt :100644 100644 087c601... 4670184... M src/ui/X11/event-Xt.c commit 4340c8701bb671122d0a4f51e2613e851c7d8051 Author: Sebastian Freundt Date: Wed Jan 4 10:33:55 2012 +0000 Summary: chore, replace nested function construct by cpp equivalent Keywords: build clang This changeset replaces a nested function left-over, introduced to provide closure (over the compile stack), by a more portable pre-processor construct. * src/regex.c (regex_compile): auto inline foo -> #define Signed-off-by: Sebastian Freundt :100644 100644 b5ced47... a3da58b... M src/regex.c commit 2eec5d2183f87c1805c66c361282069246b96528 Author: Nelson Ferreira Date: Tue Jan 3 23:58:56 2012 -0500 Revert removal of X_FLAGS from libsxeuiTTY_a_CPPFLAGS. We really need to fix this. TTY should not depend on X11 even if X11 is being linked in... Signed-off-by: Nelson Ferreira :100644 100644 171dbae... a8b1a2d... M src/ui/TTY/Makefile.am commit 033216f92d0162b3a7d78c36e801e90535152157 Author: Nelson Ferreira Date: Tue Jan 3 23:48:22 2012 -0500 Revert removal of X_FLAGS from libsxecore_a_CPPFLAGS and libcruft_a_CPPFLAGS Signed-off-by: Nelson Ferreira :100644 100644 602c110... 5556bc4... M src/Makefile.am commit b0e712037bcd49aea4967ec8785b3c92f40c588c Author: Steve Youngs Date: Wed Jan 4 07:34:57 2012 +1000 fix my conflict fix Signed-off-by: Steve Youngs :100644 100644 4571923... 602c110... M src/Makefile.am commit a1b5402d8c5857f4034cf254a54abb08616cdd64 Author: Sebastian Freundt Date: Tue Jan 3 11:33:24 2012 +0000 Summary: fix to fix, do not blank EMACSPACKAGEPATH when finding ... Keywords: bldchn ... load path shadows. * src/Makefile.am (sxemacs.dmp): use BATCHENV in target so load paths contain the current user's package paths Signed-off-by: Sebastian Freundt :100644 100644 5744a6f... 0aca9bc... M src/Makefile.am commit 9ad792050bb03af38280ba676245bde07bba84da Author: Sebastian Freundt Date: Tue Jan 3 10:52:29 2012 +0000 Summary: minor, also massage sxemacs calls in tests/ with batch env Keywords: bldchn Again, due to a libtool inconsistency, this changeset adds the location of the newly built lwlib libary to the environment before calling sxemacs, this time in tests/ so make check will work. * tests/Makefile.am: add batch environment to sxemacs binary calls Signed-off-by: Sebastian Freundt :100644 100644 58a2a37... ee2a3eb... M tests/Makefile.am commit 699e5f09b46ffcf4d614ee0b850644bf52e9a8cb Author: Sebastian Freundt Date: Tue Jan 3 09:51:06 2012 +0000 Summary: minor, put XCCLDFLAGS in libtool built binaries and libs Keywords: build icc This changeset adds XCCLDFLAGS to all libs and binaries touched by libtool, in general whenever there's a foo_la_bar foo_la_LDFLAGS or AM_LDFLAGS should contain $(XCCLDFLAGS). * modules/ase/Makefile.am: add XCCLDFLAGS * modules/cl/Makefile.am: add XCCLDFLAGS * modules/dbus/Makefile.am: add XCCLDFLAGS * modules/ldap/Makefile.am: add XCCLDFLAGS * src/Makefile.am: add XCCLDFLAGS * src/ui/lwlib/Makefile.am: add XCCLDFLAGS Signed-off-by: Sebastian Freundt :100644 100644 efe979d... 161483c... M modules/ase/Makefile.am :100644 100644 767952e... 947df24... M modules/cl/Makefile.am :100644 100644 3b4d1a9... 723b877... M modules/dbus/Makefile.am :100644 100644 bbe77ed... 9515554... M modules/ldap/Makefile.am :100644 100644 32dc335... 5744a6f... M src/Makefile.am :100644 100644 689144b... 5729cda... M src/ui/lwlib/Makefile.am commit 8f8cf437bf7672f133c8c13cf2475cac32f56d48 Author: Sebastian Freundt Date: Tue Jan 3 09:23:44 2012 +0000 Summary: minor, provide XCCLDFLAGS to be passed on through libtool to the CC Keywords: build icc * m4/sxe-compiler.m4: put -static-foo into XCCLDFLAGS and AC_SUBST them * m4/sxe-libtool.m4: prepend XCCFLAG (-XCClinker) to XCCLDFLAGS entries Signed-off-by: Sebastian Freundt :100644 100644 24920e6... 4cce877... M m4/sxe-compiler.m4 :100644 100644 b2d3a18... c88a216... M m4/sxe-libtool.m4 commit f14fdf96617772fd08273bda52c39c4718021e2d Author: Sebastian Freundt Date: Mon Jan 2 23:14:59 2012 +0000 Summary: minor, tweak SXE_CHECK_LINKER_FLAGS Keywords: bldchn Just to be symmetric provide a 4 argument version for macro SXE_CHECK_LINKER_FLAGS, where the 4th argument is a list of additional flags to pass to the linker, in analogy to the 4-arg version of SXE_CHECK_COMPILER_FLAGS. * m4/sxe-linker.m4: provide 4 argument SXE_CHECK_LINKER_FLAGS for analogy reasons Signed-off-by: Sebastian Freundt :100644 100644 64ec17c... 06d5ac0... M m4/sxe-linker.m4 commit 643a0211c43cdd3691abdcda048fbb686024fa25 Author: Sebastian Freundt Date: Mon Jan 2 23:11:06 2012 +0000 Summary: fix to fix, do not treat compiler flags as linker flags Keywords: bldchn This changeset reverts some checks for falsely dubbed linker flags which are in fact compiler flags, namely -static-intel and -static-libgcc. Because these flags need to be checked against the fully expanded CFLAGS, the CFLAGS are generated beforehand and the checks themselves go to FEATFLAGS. * m4/sxe-linker.m4: fix, remove checks for -static-intel and -static-libgcc * m4/sxe-compiler.m4: check for -static-intel and -static-libgcc in the context of FEATFLAGS Signed-off-by: Sebastian Freundt :100644 100644 4511135... 24920e6... M m4/sxe-compiler.m4 :100644 100644 d65dab3... 64ec17c... M m4/sxe-linker.m4 commit cfa38d82790664fe638a5edf0bdbfba9dfc42bb0 Author: Nelson Ferreira Date: Mon Jan 2 17:45:22 2012 -0500 Fix detection of MacOS X native provided libpng * m4/sxe-mm.m4 (_SXE_MM_CHECK_PNG_VERSION): Use the previously detected PNG LDFLAGS, CFLAGS and LIBS when determining version. Signed-off-by: Nelson Ferreira :100644 100644 a96b1a9... cc67a7f... M m4/sxe-mm.m4 commit a83d30019ae267ba58e50f342906766f5a2c6cc8 Author: Sebastian Freundt Date: Mon Jan 2 22:35:42 2012 +0000 Summary: minor, specifically check for all optimisation flags Keywords: bldchn * m4/sxe-compiler.m4: if --with-ridiculously-aggressive-optimisations is not given perform a moderate check for optimisation flags instead of just setting them Signed-off-by: Sebastian Freundt :100644 100644 0ef05d6... 4511135... M m4/sxe-compiler.m4 commit 5fac5a7406a99455c3c23990f65b65d23319a18d Author: Sebastian Freundt Date: Mon Jan 2 22:09:07 2012 +0000 Summary: fix, check for special diagnostic 10237 if CC=icc Keywords: bldchn * m4/sxe-compiler.m4: if CC=icc check for special diagnostic 10237 to facilitate -static-intel Signed-off-by: Sebastian Freundt :100644 100644 dcde738... 0ef05d6... M m4/sxe-compiler.m4 commit 90edcdb06ebda871cabb992d09d81136d7262758 Author: Sebastian Freundt Date: Mon Jan 2 22:08:16 2012 +0000 Summary: fix, use all CFLAGS for linker flag check Keywords: bldchn * m4/sxe-linker.m4: actuaclly use the CFLAGS agreed upon so far to check linker flags Signed-off-by: Sebastian Freundt :100644 100644 9e3dbd0... d65dab3... M m4/sxe-linker.m4 commit 06ab263025dd31ade9131cda75b78e9447c5ee28 Author: Sebastian Freundt Date: Mon Jan 2 21:41:43 2012 +0000 Summary: minor, provide SXE_CHECK_COMPILER_XFLAG Keywords: bldchn This changeset provides a convenience macro, SXE_CHECK_COMPILER_XFLAG, to test how to pass on linker flags through the C compiler. * m4/sxe-compiler.m4: new, SXE_CHECK_COMPILER_XFLAG * m4/sxe-linker.m4: require SXE_CHECK_COMPILER_XFLAG Signed-off-by: Sebastian Freundt :100644 100644 01eec4e... dcde738... M m4/sxe-compiler.m4 :100644 100644 a8036f1... 9e3dbd0... M m4/sxe-linker.m4 commit 9373cf13a61b48ff780bef0e2f2851e92ecce509 Author: Sebastian Freundt Date: Mon Jan 2 19:54:54 2012 +0000 Summary: cosmetics, add meself to sppm.texi Keywords: boasting * info/sppm.texi: add my git repo Signed-off-by: Sebastian Freundt :100644 100644 9685bb6... 712d1dd... M info/sppm.texi commit e060837684670b5ef92597add7a172cb8bd5bb17 Author: Sebastian Freundt Date: Mon Jan 2 19:45:44 2012 +0000 Summary: minor, always pass on SXE_DYLD_PATH with pointers to the lwlibdir Keywords: bldchn This changeset prepends calls to the undumped or dumped sxe binary with BATCHENV which holds paths to the newly built lwlib libs. This fixes builds that switch from say the athena widget kit to the lucid kit, as the installed lwlib library will certainly not provide some symbols needed with the new widget kit. * lisp/Makefile.am: prepend all calls to sxe with BATCHENV * modules/Makefile.am: prepend all calls to sxe with BATCHENV * src/Makefile.am: prepend all calls to sxe with BATCHENV Signed-off-by: Sebastian Freundt :100644 100644 a1cdbe1... 01e5fda... M lisp/Makefile.am :100644 100644 f78f723... 744a6d4... M modules/Makefile.am :100644 100644 6b8791e... 32dc335... M src/Makefile.am commit 821020880a883e6c7ae2c4804d29a8ff17c8ebb1 Author: Sebastian Freundt Date: Mon Jan 2 14:26:58 2012 +0000 Summary: minor, call the linker (or the compiler front-end) when ... Keywords: bldchn ... checking for LD_ZFLAGs. This facilitates sparse and clang builds. * m4/sxe-linker.m4 (SXE_CHECK_LD_ZFLAG): be a wrapper for SXE_CHECK_LINKER_FLAGS Signed-off-by: Sebastian Freundt :100644 100644 ec8966d... a8036f1... M m4/sxe-linker.m4 commit 372156c4a7f1faccebdacbbbf0dc014b7302fbb9 Author: Sebastian Freundt Date: Mon Jan 2 14:23:33 2012 +0000 Summary: fix, carefully quote esd lib prepending Keywords: bldchn * configure.ac: fix, both esd-config and MM_LIBS quoted properly Signed-off-by: Sebastian Freundt :100644 100644 953dfba... 2f3f9b7... M configure.ac commit 1102c997c4f6cad32f80fb5b162be8e226d1ad58 Author: Sebastian Freundt Date: Mon Jan 2 12:39:13 2012 +0000 Summary: minor, rewrite linker checks to use the compiler front-end and XFLAG Keywords: bldchn * configure.ac (SXE_CHECK_LINKER_FLAGS -> SXE_CHECK_LDFLAGS): rename, in accordance to SXE_CHECK_CFLAGS use new SXE_CHECK_LINKER_FLAGS macro to check for nocombreloc * sxe-compiler.m4 (SXE_FEATFLAGS): move linker specific stuff to SXE_CHECK_LDFLAGS in sxe-linker.m4 * sxe-linker.m4 (SXE_CHECK_LINKER_FLAGS): new, macro to check for flags passed down to the linker via the compiler front-end, just as in real-life (SXE_CHECK_LDFLAGS): also check for compiler+linker specifics like static-intel and static-libgcc Signed-off-by: Sebastian Freundt :100644 100644 2a483f0... 953dfba... M configure.ac :100644 100644 905fe03... 01eec4e... M m4/sxe-compiler.m4 :100644 100644 7167593... ec8966d... M m4/sxe-linker.m4 commit 177e3a6c76137203f57b639ea8b0c75409e4e92c Author: Sebastian Freundt Date: Mon Jan 2 10:39:25 2012 +0000 Summary: cosmetics, add ar-lib wrapper script to git ignore file Keywords: bldchn * .gitignore: add `ar-lib' Signed-off-by: Sebastian Freundt :100644 100644 51a6c56... 1c693b5... M .gitignore commit a27549ef3e349d1624e697acf1c33b22d26a85d6 Author: Sebastian Freundt Date: Mon Jan 2 10:38:18 2012 +0000 Summary: fix to cosmetics, add AM_PROG_AR conditionally Keywords: bldchn * configure.ac: add AM_PROG_AR conditionally Signed-off-by: Sebastian Freundt :100644 100644 a5d1f97... 2a483f0... M configure.ac commit 653a75742fd420542eff3eb51134c14660703839 Author: Sebastian Freundt Date: Mon Jan 2 10:37:02 2012 +0000 Summary: cosmetics, add AM_PROG_AR like autoreconf suggests Keywords: bldchn * configure.ac: add AM_PROG_AR Signed-off-by: Sebastian Freundt :100644 100644 47468ca... a5d1f97... M configure.ac commit 7c089eab693837017f0d67136b4e55605c836b91 Author: Nelson Ferreira Date: Sun Jan 1 23:40:14 2012 -0500 Overcome differences in order of CFLAGS vs argument list. In the process, make the libpng used in Mac OS be the one detected, not a difference between compile and runtime. * m4/sxe-summary.m4 (SXE_SUMMARY): Add output of c_switch_system, ld_switch_general and ld_libs_system to the summary. * src/Makefile.am (libsxecore_a_CPPFLAGS): Remove X_CFLAGS since they are not (and should not be) needed. * src/Makefile.am (libcruft_a_CPPFLAGS): Ditto. * src/ui/TTY/Makefile.am (libsxeuiTTY_a_CPPFLAGS): Ditto. * src/Makefile.am (AM_CPPFLAGS): Use c_switch_general instead of c_switch_system * src/database/Makefile.am (AM_CPPFLAGS): Ditto. * src/ent/Makefile.am (AM_CPPFLAGS): Ditto. * src/events/Makefile.am (AM_CPPFLAGS): Ditto. * src/media/Makefile.am (AM_CPPFLAGS): Ditto. * src/media/Makefile.am (libmm_a_CPPFLAGS): Ditto. * src/mem/Makefile.am (AM_CPPFLAGS): Ditto. * src/mule/Makefile.am (AM_CPPFLAGS): Ditto. * src/ui/Gtk/Makefile.am (AM_CPPFLAGS): Ditto. * src/ui/Gtk/Makefile.am (libsxeuiGtk_a_CPPFLAGS): Ditto. * src/ui/Makefile.am (AM_CPPFLAGS): Ditto. * src/ui/Makefile.am (libsxeui_a_CPPFLAGS): Ditto. * src/ui/TTY/Makefile.am (AM_CPPFLAGS): Ditto. * src/ui/TTY/Makefile.am (libsxeuiTTY_a_CPPFLAGS): Ditto. * src/ui/X11/Makefile.am (AM_CPPFLAGS): Ditto. * src/ui/X11/Makefile.am (libsxeuiX11_a_CPPFLAGS): Ditto. Signed-off-by: Nelson Ferreira :100644 100644 d53fdff... 8a65ad8... M configure.ac :100644 100644 5c25982... cf2ca67... M m4/sxe-summary.m4 :100644 100644 6b8791e... cf63347... M src/Makefile.am :100644 100644 099dcc0... a05809a... M src/database/Makefile.am :100644 100644 32fe471... 299b8aa... M src/ent/Makefile.am :100644 100644 bc58658... e483e37... M src/events/Makefile.am :100644 100644 7ecb837... bd2007c... M src/media/Makefile.am :100644 100644 38cd9b4... 3dd0253... M src/mem/Makefile.am :100644 100644 ad605df... f5292e8... M src/mule/Makefile.am :100644 100644 93fc696... 40dfb69... M src/ui/Gtk/Makefile.am :100644 100644 17cbb13... b946f05... M src/ui/Makefile.am :100644 100644 d1fc800... 171dbae... M src/ui/TTY/Makefile.am :100644 100644 1b5e66c... 200ba77... M src/ui/X11/Makefile.am commit 804807b1a189cdec25cb16ffb290946447cc0d1c Author: Sebastian Freundt Date: Sun Jan 1 21:04:29 2012 +0000 Summary: minor, check certain compiler flags regardless of CC flavour Keywords: bldchn This changeset, in preparation to upcoming clang support, checks for certain compiler flags (warnings at the moment) regardless of flavour. It seems many compilers actually support a lot more gcc flags than gcc itself, so check for them without checking for the flavour first. This might break Sun studio build but Sun isn't shining anymore, is it? * m4/sxe-compiler.m4: check for warning flags irrespective of CC flavour Signed-off-by: Sebastian Freundt :100644 100644 64a7342... 905fe03... M m4/sxe-compiler.m4 commit c52e5ab7894cb2f5aef6d853a103cb282af58eb8 Author: Sebastian Freundt Date: Sun Jan 1 20:56:47 2012 +0000 Summary: minor, provide C11 check for anonymous structs Keywords: bldchn This changeset provides a check for anon structs, an on-and-off feature of gcc, and mandatory for C11 support. * m4/sxe-compiler.m4 (SXE_CHECK_ANON_STRUCTS): simply check if anon structs are possible, they ought to be when -std=gnu1x is selected but that's only possible in gcc 4.6.1 it seems. Signed-off-by: Sebastian Freundt :100644 100644 c42974a... 64a7342... M m4/sxe-compiler.m4 commit df246395d8af148700dd9307af66e041f9f4479c Author: Sebastian Freundt Date: Sun Jan 1 19:00:13 2012 +0000 Summary: fix, use our compiler flag check macros to check for pthread{,s} Keywords: bldchn This changeset properly checks for the flags -pthread and -pthreads. The old case based system could not cope with new gcc's and clang's error messages. * configure.ac: fix, use SXE_CHECK_COMPILER_FLAGS, a macro defined in m4/sxe-compiler.m4 Signed-off-by: Sebastian Freundt :100644 100644 d53fdff... 47468ca... M configure.ac commit 23cf82a7fa5b37d7e31bf1f430422ecbcc7146e8 Author: Nelson Ferreira Date: Fri Dec 16 23:51:26 2011 -0500 Add check for user email and name setup Signed-off-by: Nelson Ferreira :100755 100755 55574db... 88db014... M contrib/git-to-steve.sh commit 33605d8ed227ade297baa823b8551d60f40a7e1a Author: Steve Youngs Date: Sat Dec 17 13:30:23 2011 +1000 ensure we track origin/master Signed-off-by: Steve Youngs :100755 100755 3d3b7a9... 55574db... M contrib/git-to-steve.sh commit c39799e08637bb55b6b1a0cda7d9045be212cf3b Author: Nelson Ferreira Date: Fri Dec 16 22:08:30 2011 -0500 Added contrib script to help people setup their contributing branches Signed-off-by: Nelson Ferreira :000000 100755 0000000... 3d3b7a9... A contrib/git-to-steve.sh commit 71a3fb947b3582d4fe847097f6a54d1673731597 Author: Nelson Ferreira Date: Fri Dec 16 21:43:21 2011 -0500 Add copyright to autogen.sh Signed-off-by: Nelson Ferreira :100755 100755 7ad456a... 5bd7a2e... M autogen.sh commit 5660ee2f97ed12ca1f4b377d431fcd7dc1740c33 Author: Nelson Ferreira Date: Thu Dec 15 00:07:25 2011 -0500 Add triggers to action to update contrib scripts Signed-off-by: Nelson Ferreira :100644 100644 b413b8b... 35ed106... M contrib/README :100755 100755 4edc26b... 75027a0... M contrib/make-pkg.sh :100755 100755 42adeb0... 9b2df67... M contrib/report-build-failure.sh commit ad4fb739fac192a9af5fc2c5bdef92fe292d779e Author: Nelson Ferreira Date: Thu Dec 15 00:03:03 2011 -0500 More remove tla hook references in contrib Signed-off-by: Nelson Ferreira :100755 000000 c7d8dc3... 0000000... D contrib/hook commit d75799f66fe5c78bc131d069b348f5e74c1c8fed Author: Nelson Ferreira Date: Thu Dec 15 00:00:41 2011 -0500 Remove tla hook references in contrib Signed-off-by: Nelson Ferreira :100755 000000 21ece5c... 0000000... D contrib/10sendlog :100755 000000 68cf3fd... 0000000... D contrib/20mirror :100644 100644 6c6925b... b413b8b... M contrib/README commit 425838730140b68fc4952f146b875a8a23bf2f0d Author: Nelson Ferreira Date: Wed Dec 14 23:08:41 2011 -0500 Warn that cl emod is not being built due to missing bison Signed-off-by: Nelson Ferreira :100644 100644 6495632... d53fdff... M configure.ac commit 864a30c583e9f1969ef459fad093632c11b20baf Author: Nelson Ferreira Date: Wed Dec 14 22:52:40 2011 -0500 Revert "Add copyright and license to autogen.sh" This reverts commit 141c2bb87dad80dd319fe76517ec2429a10bebe6. :100755 100755 dd0b657... 7ad456a... M autogen.sh commit 141c2bb87dad80dd319fe76517ec2429a10bebe6 Author: Nelson Ferreira Date: Wed Dec 14 22:42:14 2011 -0500 Add copyright and license to autogen.sh :100755 100755 7ad456a... dd0b657... M autogen.sh commit a1783231ad682d92a9fbc2504cb7f2de7fe1a030 Author: Nelson Ferreira Date: Wed Dec 14 22:10:59 2011 -0500 Add the directory for the dbus module :000000 100644 0000000... 3b4d1a9... A modules/dbus/Makefile.am commit 6657aaca92854299636110e22f52d67324f6a388 Author: Nelson Ferreira Date: Wed Dec 14 21:36:21 2011 -0500 Add my copyright to configure.ac Signed-off-by: Nelson Ferreira :100644 100644 ae1bd4b... 6495632... M configure.ac commit b6e24839f4467534be899fdfd14653255ebf4ac4 Author: Nelson Ferreira Date: Fri Dec 9 14:20:15 2011 -0500 Enhance realpath and dirname checking. * m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_RETVAL): Do the checking in a function so that any core will show which test cored. * m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_RETVAL_OWNER): Ditto. * m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_ON_PROTECTED_MEMORY): Ditto. * m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_SANE_ON_NON_EXISTENT): Ditto. * m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_SIDE_EFFECT): Ditto. * m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_RETVAL_OWNER): Ditto. * m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_RETVAL_OWNER): Avoid a core in MacOS X by pre-choosing sys as the result. Signed-off-by: Nelson Ferreira :100644 100644 77f2ce3... 99ee02a... M m4/sxe-fs-funs.m4 commit 9e501c05c826bcf14b60c2a4969b6ca9e7ac6fe8 Author: Nelson Ferreira Date: Fri Dec 9 14:11:13 2011 -0500 Remove unneeded SXE_SHLIB_STUFF * m4/sxe-linker.m4: As the title says. This is not called anywhere, so better to take this ugly piece out. We have this logic already spreadout elsewhere anyway, both in our own stuff and libtool... Signed-off-by: Nelson Ferreira :100644 100644 8b30b05... 7167593... M m4/sxe-linker.m4 commit 24f599662a78f8fa2902bfc61da049c495059a07 Author: Nelson Ferreira Date: Fri Dec 9 11:04:10 2011 -0500 Stop configure if there is no makeinfo * m4/sxe-bldchain-progs.m4 (SXE_PROG_MAKEINFO): Detection of makeinfo. Since autoconf will actually define one using missing, we kinda need to execute --version to make sure it is actually real. * m4/sxe-bldchain-progs.m4 (SXE_CHECK_BUILDCHAIN): Add call to SXE_PROG_MAKEINFO Signed-off-by: Nelson Ferreira :100644 100644 6bdca66... c7f9cdb... M m4/sxe-bldchain-progs.m4 commit 47793f846b8db7cba40b77255a567d4d1045ff25 Author: Nelson Ferreira Date: Tue Dec 6 15:58:09 2011 -0500 Fix configure in solaris * m4/sxe-aux.m4 (SXE_CONSECUTIVE_UNDUP): Try use detected awk which will allow for better results. On solaris this should be either the xpg4 one, or gawk. * m4/sxe-aux.m4 (SXE_UNDUP): Ditto * m4/sxe-summary.m4 (SXE_SUMMARY): Ditto * m4/sxe-crypto.m4 (SXE_OPENSSL_VERSION): Try to use detected grep which will allow for -q. On solaris this should be either gnu grep or the xpg4 one. Signed-off-by: Nelson Ferreira :100644 100644 3e21c12... 4331e9c... M m4/sxe-aux.m4 :100644 100644 61f2cdd... 4ae9d7d... M m4/sxe-crypto.m4 :100644 100644 dd82537... 5c25982... M m4/sxe-summary.m4 commit 0e75bdde09434633be49af8ef0439e21daed3584 Author: Nelson Ferreira Date: Sat Dec 3 23:09:59 2011 -0500 Give a little more detail about crash reporting on MacOS X Signed-off-by: Nelson Ferreira :100644 100644 d10cd6e... 24cda27... M PROBLEMS commit e0a3e603d6b466247abcde7ccb8cf0bf874a6252 Author: Nelson Ferreira Date: Sat Dec 3 21:35:41 2011 -0500 Add resolution to missing makeinfo while building Signed-off-by: Nelson Ferreira :100644 100644 81db39f... d10cd6e... M PROBLEMS commit b3e6f095343692a2d33e16044200fe00728611c2 Author: Nelson Ferreira Date: Sat Dec 3 21:32:35 2011 -0500 Update link to mpc library. Warn of texinfo needed to build from git. Small typo fix Signed-off-by: Nelson Ferreira :100644 100644 0fdfeb9... 0897915... M INSTALL commit 9a417f025020ce650589bf52307fcb541ca0d42a Author: Nelson Ferreira Date: Sat Dec 3 03:02:40 2011 -0500 Fix detection and usage of mpc in newer versions (like mpc 0.9) * m4/sxe-maths.m4 (_SXE_CHECK_MPC): check for mpc_init and mpc_set_ui_fr which were recently removed so that they can be emulated for now. Also determine if mpc can be inited (and thus used) by making sure one of mpc_init or mpc_init2 is available. * m4/sxe-maths.m4 (SXE_CHECK_MPC_LIBS): check for mpc_init2 and mpc_set_ui_fr too. * src/ent/ent-mpc.h (bigc_init): conditional definition on whether mpc_init or mpc_init2 is available. * src/ent/ent-mpc.c: define mpc_set_ui_fr based on the MPC_SET_X_Y macro if available. Abort compile if not available. Signed-off-by: Nelson Ferreira :100644 100644 e1f7aba... 3bf2a02... M m4/sxe-maths.m4 :100644 100644 eaf9318... e10f8a4... M src/ent/ent-mpc.c :100644 100644 2adcac1... f488ae6... M src/ent/ent-mpc.h commit 9361b0108fb09deccb7465abecf77de8fdeb2b15 Author: Nelson Ferreira Date: Fri Dec 2 09:55:18 2011 -0500 Also make sxemacs packages of user home be looked up before xemacs ones, not just the system Signed-off-by: Nelson Ferreira :100644 100644 7162c93... ae1bd4b... M configure.ac commit adb396952122956823c0174057de6d0bec646ab4 Author: Nelson Ferreira Date: Fri Dec 2 01:04:33 2011 -0500 Revert order changer for module paths Signed-off-by: Nelson Ferreira :100644 100644 694c576... 7162c93... M configure.ac commit b5fad6fc87fa10f81c06e175e447ff121192abf2 Author: Nelson Ferreira Date: Thu Dec 1 22:06:31 2011 -0500 Enhance the module and package lookup paths * configure.ac: lookup sxemacs-/ before sxemacs/ for modules * configure.ac: looup sxemacs-packages before xemacs-packages Signed-off-by: Nelson Ferreira :100644 100644 36fdae6... 694c576... M configure.ac commit 11c5dc03a87e1c501ac4d231aadb8792b2ce4150 Author: Nelson Ferreira Date: Thu Dec 1 20:34:28 2011 -0500 [ Replace this line with a one-line summary of the changes ] * configure.ac: Properly quote eval so that ~ does not get expanded * configure.ac: Remove double ':' on package path * m4/sxe-summary.m4 (SXE_SUMMARY): Use awk instead of SED so that newlines are properly introduced in all cases Signed-off-by: Nelson Ferreira :100644 100644 1ecc2aa... 36fdae6... M configure.ac :100644 100644 7319a94... dd82537... M m4/sxe-summary.m4 commit b5566067355dbdabd4da4597c03e6a21ec262cb7 Author: Nelson Ferreira Date: Thu Dec 1 12:37:29 2011 -0500 Disable PIE in MacOS X Lion, thus pdump works again... * configure.ac: If darwin linker supports -no_pie, add it * m4/sxe-bldenv.m4 (SXE_LD_NO_PIE): New function to check if the linker supports -no_pie. * m4/sxe-compiler.m4 (SXE_CHECK_CC_CHAR): Invoke the linker check for -no_pie Signed-off-by: Nelson Ferreira :100644 100644 53965e9... 1ecc2aa... M configure.ac :100644 100644 64d66b3... 13a78ae... M m4/sxe-bldenv.m4 :100644 100644 b5e6aa3... c42974a... M m4/sxe-compiler.m4 commit 61340e710adcb3682ffb5c8a9476115359d8e1d2 Author: Nelson Ferreira Date: Thu Dec 1 11:10:21 2011 -0500 Cosmetic fixes to the configuration summary (ie Installation) * m4/sxe-summary.m4 (SXE_SUMMARY): Fix the Runtime behavior prefix output. Properly indent the search paths Signed-off-by: Nelson Ferreira :100644 100644 6d17cdf... 7319a94... M m4/sxe-summary.m4 commit a41701f91ef06d80e6d7c7e998f972610d10fc6c Author: Nelson Ferreira Date: Thu Dec 1 03:32:47 2011 -0500 Deduplicate options to compiler and linker, as well as consecutive LIBS * configure.ac: Use SXE_{APPEND,PREPEND}_UNDUP do add to c_switch_site and ld_switch_site * configure.ac: Ditto for adding to c_switch_gtk * configure.ac: Ditto for adding to X_CFLAGS * configure.ac: Ditto for adding to MM_CFLAGS, MM_LDFLAGS and MM_CPPFLAGS * configure.ac: Use SXE_CONSECUTIVE_UNDUP instead of SXE_SPACE to remove consecutive dups on libs_xauth * configure.ac: Ditto for ld_libs_general, ld_libs_window_system and ld_libs_all * configure.ac: Use SXE_UNDUP to remove dups from {c,ld}_switch_{general,window_system,all} * configure.ac: Remove extra verbose output of the switches, since this was moved to sxe-summary.m4 * m4/sxe-summary.m4 (SXE_SUMMARY): Provide output of {c,ld}_switch_{general,window_system,all} * m4/sxe-summary.m4 (SXE_SUMMARY): Don't use -e on echo, since not all shells honor it * m4/sxe-bldenv.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to LD_FLAGS, CPPFLAGS, ld_switch_{run,system,site} * m4/sxe-compiler.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to c_switch_{site,system}, CFLAGS * m4/sxe-crypto.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to CPPFLAGS, LDFLAGS * m4/sxe-libtool.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to LDFLAGS * m4/sxe-mm.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to {c,ld}_switch_site Signed-off-by: Nelson Ferreira :100644 100644 6d62a17... 53965e9... M configure.ac :100644 100644 2a930ed... 3e21c12... M m4/sxe-aux.m4 :100644 100644 3b2eb58... 64d66b3... M m4/sxe-bldenv.m4 :100644 100644 79f5d7c... b5e6aa3... M m4/sxe-compiler.m4 :100644 100644 69c89c9... 61f2cdd... M m4/sxe-crypto.m4 :100644 100644 cdd6c1e... b2d3a18... M m4/sxe-libtool.m4 :100644 100644 b1842bd... a96b1a9... M m4/sxe-mm.m4 :100644 100644 20f251e... 6d17cdf... M m4/sxe-summary.m4 commit e00fd44315c1cb18cef6815d05135e86e64fea1b Author: Steve Youngs Date: Mon Nov 28 13:03:43 2011 +1000 typo fix Signed-off-by: Steve Youngs :100644 100644 a1e18b6... f353f13... M src/filelock.c commit 1553d36581eeaaffda58879d436275eeffd28405 Author: Nelson Ferreira Date: Sun Nov 27 21:28:18 2011 -0500 Bug 129 - Bad conversion to snprintf * src/filelock.c (lock_file): Compute size of malloc and use it assert Signed-off-by: Nelson Ferreira :100644 100644 aaf5e0d... a1e18b6... M src/filelock.c commit b53263234ad9a7afda9903d7f6abb574b7e390a1 Author: lg Date: Sun Nov 27 22:00:52 2011 +0300 [add] command: M-x Wand-list-patterns RET [add] command: M-x Wand-list-composite-ops RET [add] operation: preview-op, powerful shit to preview some operations with different params [add] operation: posterize [add] operation: pattern [enh] Wand-redisplay: image-wand can be changed during operation [enh] make a use of (window-displayed-text-pixel-height) Signed-off-by: lg :100644 100644 d3e7fc2... 50af716... M lisp/ffi/ffi-wand.el commit 510321099de1dcb49c5a67ad038138fbe202b73e Author: Nelson Ferreira Date: Tue Nov 15 20:55:54 2011 -0500 Prevent inexistence of openssl ssl_verify_cert_chain from breaking the build Signed-off-by: Nelson Ferreira :100644 100644 ac95002... 69c89c9... M m4/sxe-crypto.m4 :100644 100644 29d61a6... 5ad630b... M src/openssl.c commit d94adf5dd4f6118b163c1d23a232144c4a4292b8 Author: Nelson Ferreira Date: Tue Nov 15 03:59:38 2011 -0500 Prevent inexistence of openssl server/client methods from breaking the build Signed-off-by: Nelson Ferreira :100644 100644 7c1a328... ac95002... M m4/sxe-crypto.m4 :100644 100644 309a72b... 29d61a6... M src/openssl.c commit caeea04d4b205b48d657174cdd2dadae2fe19720 Author: Zajcev Evgeny Date: Thu Nov 10 13:57:11 2011 +0300 [add] minibuffer prompt stack for use with recursive minibuffers Signed-off-by: Zajcev Evgeny :100644 100644 8ae557e... e9974f1... M lisp/minibuf.el commit 1f593aab5d4871218bae49ec34ab98945423e232 Author: JD Horelick Date: Mon Oct 24 06:16:12 2011 -0400 Fix compilation when MULE is disabled, due to a missing ifdef. Signed-off-by: Steve Youngs :100644 100644 49e4189... 00640b1... M src/chartab.c commit bba1659d8c31de192b8705516ee6b638af1e501b Author: Nelson Ferreira Date: Mon Oct 10 21:29:16 2011 -0400 Remove unused variable Signed-off-by: Nelson Ferreira :100644 100644 5d1e95b... 86b6935... M lib-src/movemail.c commit 3ec33f231ece7013a0281253a2c1701c3e8826f0 Author: Nelson Ferreira Date: Mon Oct 10 21:28:41 2011 -0400 Fix compile of previous commit Signed-off-by: Nelson Ferreira :100644 100644 5c5f9ba... 087c601... M src/ui/X11/event-Xt.c commit 9e3717a56c8105d1baafbecfd382cb23368b33b9 Author: Nelson Ferreira Date: Mon Oct 10 21:14:35 2011 -0400 Coverity fix CID:92 NEGATIVE_RETURNS * lib-src/movemail.c (main): Make sure read was successful before trying to write.. Signed-off-by: Nelson Ferreira :100644 100644 d328c45... 5d1e95b... M lib-src/movemail.c commit 0ab9fcceed4677e7d1c856ce7b85702a6a9a43f4 Author: Nelson Ferreira Date: Mon Oct 10 20:36:35 2011 -0400 Coverity fix. CID:135 NULL_RETURNS * src/ui/X11/event-Xt.c (x_to_emacs_keysym): make fure there is a frame before dereferencing to get the XIC. Signed-off-by: Nelson Ferreira :100644 100644 4d69694... 5c5f9ba... M src/ui/X11/event-Xt.c commit b45588282b1fd8cd908a237d5a9e43f225ae2807 Author: Nelson Ferreira Date: Mon Oct 10 20:29:54 2011 -0400 More binary files... * lisp/files.el (binary-file-regexps): Following the lead from a recent XEmacs commit, enhance the list of known binary files. Signed-off-by: Nelson Ferreira :100644 100644 faadca8... e261a1b... M lisp/files.el commit 546b20979094ed423312c678456b36019f2f81b7 Author: Nelson Ferreira Date: Mon Oct 10 19:56:12 2011 -0400 Coverity fix CID:202 REVERSE_INULL * src/mem/ralloc.c (update_heap_bloc_correspondence): Make sure heap is not NULL before dereference Signed-off-by: Nelson Ferreira :100644 100644 eeb25dc... c78bf2b... M src/mem/ralloc.c commit 3f835191903908f415451438c2250c42e0d6c3e8 Author: Nelson Ferreira Date: Mon Oct 10 19:51:13 2011 -0400 Coverity fix CI:203 REVERSE_INULL * src/doprnt.c (get_doprnt_args): avoid derefence a NULL specs (emacs_doprnt_1): ditto. Signed-off-by: Nelson Ferreira :100644 100644 23de309... 6bf4b74... M src/doprnt.c commit 92c0d21ac2e5a211ce557471a13b7b9a4c171ebf Author: Nelson Ferreira Date: Mon Oct 10 19:42:58 2011 -0400 Coverity fixes CID:45 FORWARD_NULL * src/dired.c (dfr_inner): Make sure bufp is not NULL before calling pathname_matches_p Signed-off-by: Nelson Ferreira :100644 100644 2fa35d9... e957a22... M src/dired.c commit 4f191f3275dbe870320198086d40ea147669f809 Author: Nelson Ferreira Date: Mon Oct 10 14:16:49 2011 -0400 Coverity fix: CID 121 NEGATIVE_RETURNS * src/ui/TTY/objects-tty.c (tty_font_spec_matches_charset): make sure length is updated by fixup_internal_substring. Signed-off-by: Nelson Ferreira :100644 100644 24a27d3... 5d3fcf0... M src/ui/TTY/objects-tty.c commit 3e06e26dd0b7fa065ae192010120289323ba33b6 Author: Nelson Ferreira Date: Mon Oct 10 14:15:09 2011 -0400 Coverity fix: CID:126 NEGATIVE_RETURNS * src/ui/X11/objects-x.c (x_font_spec_matches_charset): make sure that fixup_internal_substring updated the_length. Signed-off-by: Nelson Ferreira :100644 100644 cb3f6f4... af30648... M src/ui/X11/objects-x.c commit b97fa32b78c34f2fced22904e55bd92fa8b39379 Author: Nelson Ferreira Date: Mon Oct 10 11:31:45 2011 -0400 Fix solaris crash * src/ent/ent-float.c (vars_of_ent_float): Make sure to use a buffer since some implementations of snprintf will refuse a NULL buffer and not return the characters that would be written. Signed-off-by: Nelson Ferreira :100644 100644 6afa30e... 4345ba7... M src/ent/ent-float.c commit 601f92b982c4feac6a829e1d3078f0d9c3b9cc18 Author: Nelson Ferreira Date: Mon Oct 10 09:51:43 2011 -0400 Coverity fix: USE_AFTER_FREE CID:438 * src/sysdep.c (sys_fclose): loop with close on fd, not fclose Signed-off-by: Nelson Ferreira :100644 100644 fa74c2d... e4844df... M src/sysdep.c commit cb837c1cca8929b343e620e362060a96743d550f Author: Nelson Ferreira Date: Sun Oct 9 22:56:14 2011 -0400 SECURE_CODING: Use snprintf/write_fmt_str instead of sprintf * etc/tests/external-widget/test-ew-motif.c (ScaleValueChangedCB): Use snprintf instead of sprintf. * etc/tests/external-widget/test-ew-motif.c (main): ditto. * etc/tests/external-widget/test-ew-motif.c (main): ditto. * etc/tests/external-widget/test-ew-xlib.c (draw_text): ditto * lib-src/gnuclient.c (tell_emacs_to_resume): ditto. * lib-src/gnuclient.c (main): ditto. * lib-src/gnuserv.c (ipc_init): ditto. * lib-src/gnuserv.c (unix_init): ditto. * lib-src/gnuslib.c (connect_to_ipc_server): ditto. * lib-src/gnuslib.c (connect_to_unix_server): ditto. * lib-src/make-po.c (buf_print): ditto. * lib-src/movemail.c (lock_dot): ditto. * lib-src/pop.c (pop_open): ditto. * lib-src/profile.c (get_time): ditto. * lib-src/yow.c (main): ditto. * src/bytecode.c (invalid_byte_code_error): ditto. * src/extents.c (print_extent_1): ditto. * src/m/cydra5.h (PTY_NAME_SPRINTF): ditto. * src/m/cydra5.h (PTY_TTY_NAME_SPRINTF): ditto. * src/media/media-ffmpeg.c (media_ffmpeg_streaminfo): ditto. * src/media/sound-hpplay.c (player_error_internal): ditto. * src/media/sound-sunplay.c (init_device): ditto. * src/media/sound-sunplay.c (play_sound_file): ditto. * src/media/sound-sunplay.c (play_sound_data): ditto. * src/media/sound-sunplay.c (sound_native_audio_init): ditto. * src/process.c (make_process_internal): ditto. * src/ui/Gtk/menubar-gtk.c (menu_descriptor_to_widget_1): ditto. * src/print.c: fix comment * modules/ase/ase-resclass.h (resc_rng_to_string): check return of snprintf. * modules/ase/ase-resclass.c (_ase_resc_rng_to_string): ditto. * modules/ase/ase-resclass.c (_ase_resc_elm_to_string): ditto. * src/media/sound-jack.c (sound_jack_subthread_create): ditto. * src/effi.c (WRITE_FMT_STRING): new macro to use write_fmt_string. * src/lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): Finally fix the computed value not used warning. * src/events/events.c (print_event): remove unneeded buf * modules/ase/ase-cartesian.c (ase_cartesian_prnt): Use write_fmt_str instead of sprintf. * modules/ase/ase-heap.c (ase_yheap_prnt): ditto. * modules/ase/ase-heap.c (ase_dheap_prnt): ditto. * modules/ase/ase-heap.c (ase_wheap_prnt): ditto. * modules/ase/ase-metric.c (ase_metric_prnt): ditto. * modules/ase/ase-permutation.c (_ase_permutation_prnt_cyc): ditto. * src/bytecode.c (print_compiled_function): ditto. * src/chartab.c (print_chartab_two_byte_charset): ditto. * src/chartab.c (print_char_table): ditto. * src/database/database.c (print_database): ditto. * src/database/eldap.c (print_ldap): ditto. * src/database/postgresql.c (print_pgconn): ditto. * src/database/postgresql.c (print_pgresult): ditto. * src/effi.c (print_ffiobject): ditto. * src/effi.c (print_ffi_job): ditto. * src/emacs.c (fatal_error_signal): ditto. * src/extents.c (print_extent_1): ditto. * src/extents.c (print_extent): ditto. * src/media/media.c (media_substream_print_audio): ditto. * src/media/media.c (media_substream_print_video): ditto. * src/media/sound-alsa.c (sound_alsa_print): ditto. * src/media/sound-pulse.c (sound_pulse_print): ditto. Signed-off-by: Nelson Ferreira :100644 100644 3fa9aa8... 4333c73... M etc/tests/external-widget/test-ew-motif.c :100644 100644 d5db1e7... 84e8f4d... M etc/tests/external-widget/test-ew-xlib.c :100644 100644 671f3a7... f83a607... M lib-src/gnuclient.c :100644 100644 c396fe9... 1fabe54... M lib-src/gnuserv.c :100644 100644 6e6bcd5... b056d6a... M lib-src/gnuslib.c :100644 100644 2fadbe3... eea6dcb... M lib-src/make-po.c :100644 100644 70248f7... d328c45... M lib-src/movemail.c :100644 100644 b4e3fba... 5e88567... M lib-src/pop.c :100644 100644 9429ab3... 8f9c324... M lib-src/profile.c :100644 100644 ce4d1a0... 8f7df31... M lib-src/yow.c :100644 100644 fb3205c... 2432548... M modules/ase/ase-cartesian.c :100644 100644 72216e0... 0066bc6... M modules/ase/ase-heap.c :100644 100644 b61c0ee... 9ea995c... M modules/ase/ase-metric.c :100644 100644 90215e8... 653c3ca... M modules/ase/ase-permutation.c :100644 100644 d275bac... 44a33e8... M modules/ase/ase-resclass.c :100644 100644 c7b1fb3... 9e44d64... M modules/ase/ase-resclass.h :100644 100644 8f6769b... f17d058... M src/bytecode.c :100644 100644 6bf3f43... 49e4189... M src/chartab.c :100644 100644 08b592b... d1174d3... M src/database/database.c :100644 100644 3d4c8cc... 182da91... M src/database/eldap.c :100644 100644 091f1f4... d125335... M src/database/postgresql.c :100644 100644 0597ac8... ded16d4... M src/effi.c :100644 100644 d426640... 555fa35... M src/emacs.c :100644 100644 04aa180... ee07e4f... M src/events/events.c :100644 100644 dda4c0d... e5c3ab8... M src/extents.c :100644 100644 c7cadba... a2280c1... M src/lisp.h :100644 100644 2bdd3f3... d4e4ae7... M src/m/cydra5.h :100644 100644 f3ea874... e1667a3... M src/media/media-ffmpeg.c :100644 100644 78dcda8... 4ce4417... M src/media/media.c :100644 100644 34293de... c887ef0... M src/media/sound-alsa.c :100644 100644 0df7b42... ff57395... M src/media/sound-hpplay.c :100644 100644 42699aa... 8018e5f... M src/media/sound-jack.c :100644 100644 ff73ea3... c2e1e18... M src/media/sound-pulse.c :100644 100644 715052e... e3a6c4f... M src/media/sound-sunplay.c :100644 100644 18b2884... 58789f6... M src/print.c :100644 100644 68305a2... 4e345a5... M src/process.c :100644 100644 374461a... 93a4c30... M src/ui/Gtk/menubar-gtk.c commit dab31a7d58f5bf610f4cbcf0fe67d939e2778224 Author: Steve Youngs Date: Tue Oct 4 15:55:35 2011 +1000 Quick typo fix (missing semi-colon) * src/filelock.c (lock_file_1): Add missing semi-colon. Signed-off-by: Steve Youngs :100644 100644 00be8ea... aaf5e0d... M src/filelock.c commit 44455d60f0e281703fc03c79138c85fe295d878e Author: Nelson Ferreira Date: Tue Oct 4 01:16:11 2011 -0400 Security fixes * src/alloc.c (garbage-collect): check return of snprintf * src/doprnt.c (emacs_doprnt_smZ): ditto * src/dumper.c (pdump_file_try): ditto * src/dumper.c (pdump_load): ditto * src/editfns.c (Fencode_time): ditto * src/editfns.c (Fencode_btime): ditto * src/editfns.c (current_time_zone): ditto * src/ent/ent-float.c (vars_of_ent_float): ditto * src/filelock.c (lock_file_1): ditto * src/media/sound-arts.c (sound_arts_play): ditto * src/mule/mule-ccl.c (ccl_driver): ditto * src/opaque.c (print_opaque_ptr): ditto * src/strftime.c (add_num_time_t): ditto * src/casetab.c (print_case_table): use write_fmt_str instead of sprintf * src/elhash.c (print_hash_table): ditto * src/events/event-stream.c (print_timeout): ditto * src/events/events.c (print_event): ditto * src/media/sound-nas.c (sound_nas_print): ditto * src/media/sound.c (print_audio_job): ditto * src/opaque.c (print_opaque): ditto * src/openssl.c (print_evp_pkey): ditto * src/symbols.c (print_symbol_value_magic): ditto * src/filelock.c (lock_file): Use snprintf instead of sprintf * src/libsst.c (sst_set_ger): ditto * src/libsst.c (sst_set_gr): ditto * src/libsst.c (sst_set_gx): ditto * src/libsst.c (sst_tones): ditto * src/libsst.c (sst_dmtf): ditto * src/print.c (float_to_string): ditto * src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto * src/process-unix.c (unix_open_network_stream): ditto * src/s/hpux.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/rtu.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/sco4.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/sco5.h (PTY_TTY_NAME_SPRINTF): ditto * src/data.c (Fnumber_to_string): correct arguments to new buffer size aware float_to_string and long_to_string * src/doprnt.c (emacs_doprnt_number): correct arguments to new buffer size aware long_to_string * src/print.c (print_internal): ditto * src/ui/redisplay.c (window_line_number): ditto * src/ui/redisplay.c (decode_mode_spec): ditto * src/ent/ent-float.c (print_float): correct arguments to new buffer size aware float_to_string * src/ent/ent-float.h: define new argument for float_to_string * src/lisp.h: define new argument for long_to_string * src/emacs.c (assert_failed): flush stderr to make sure assertion is written. * src/print.c (float_to_string): rewrite so that it knows size and does not overflow buf. Also uses snprintf instead of sprintf * src/print.c (long_to_string): ditto. Signed-off-by: Nelson Ferreira :100644 100644 b0878f4... ab31f2d... M src/alloc.c :100644 100644 dd8426d... 0af249d... M src/casetab.c :100644 100644 5d950db... 8518476... M src/data.c :100644 100644 c66ec4c... 23de309... M src/doprnt.c :100644 100644 1d9e565... 9e56aa0... M src/dumper.c :100644 100644 e399a6b... 98e7507... M src/editfns.c :100644 100644 c4f6466... fbd4f77... M src/elhash.c :100644 100644 272de9e... d426640... M src/emacs.c :100644 100644 a934ce5... 6afa30e... M src/ent/ent-float.c :100644 100644 77defc7... 72eb7f9... M src/ent/ent-float.h :100644 100644 e3a20d9... d8b9eda... M src/ent/ent-gmp.c :100644 100644 e7d4a84... 1a54fad... M src/events/event-stream.c :100644 100644 c7b3a72... 04aa180... M src/events/events.c :100644 100644 941201e... 00be8ea... M src/filelock.c :100644 100644 c30043f... ce6d3ad... M src/libsst.c :100644 100644 148c463... c7cadba... M src/lisp.h :100644 100644 f726f6f... 0c71f30... M src/media/sound-arts.c :100644 100644 efb2932... 5977b3d... M src/media/sound-nas.c :100644 100644 335585d... 6b941f5... M src/media/sound.c :100644 100644 56a3db4... 95a1866... M src/mule/mule-ccl.c :100644 100644 0da4753... 1901c3a... M src/opaque.c :100644 100644 2698834... 309a72b... M src/openssl.c :100644 100644 17c2fa8... 18b2884... M src/print.c :100644 100644 00139b7... 1af232f... M src/process-unix.c :100644 100644 1814339... ee0523e... M src/s/hpux.h :100644 100644 bbc6c18... 624b0fd... M src/s/rtu.h :100644 100644 842c8e8... 44df302... M src/s/sco4.h :100644 100644 df5c43b... 407f1b7... M src/s/sco5.h :100644 100644 8fac3dc... 6f94d55... M src/strftime.c :100644 100644 d5c1740... fff6d46... M src/symbols.c :100644 100644 2ea5840... 12da833... M src/ui/redisplay.c commit 1473f115161aae88ea13df5f07ab4dbd3a8fea47 Author: Nelson Ferreira Date: Sun Oct 2 19:14:00 2011 -0400 Coverity fixes. Replace UNUSED with SXE_UNUSED since some system includes (like sox.h) define it in an incompatible fashion Signed-off-by: Nelson Ferreira :100644 100644 919b10f... 9970cb1... M modules/ase/ase-digraph.c :100644 100644 95c72d1... 72216e0... M modules/ase/ase-heap.c :100644 100644 abcb5aa... 90215e8... M modules/ase/ase-permutation.c :100644 100644 9e39980... d275bac... M modules/ase/ase-resclass.c :100644 100644 07fee4e... 8929e17... M modules/ase/ase.h :100644 100644 cc110e5... 77eed6b... M modules/cl/cl-loop.c :100644 100644 04117a5... 4ad2084... M modules/cl/cl.h :100644 100644 3e8206a... b0878f4... M src/alloc.c :100644 100644 7f873d8... 4b19c50... M src/bloom.c :100644 100644 ad79eb4... 438ea31... M src/dllist.c :100644 100644 37a19f3... c66ec4c... M src/doprnt.c :100644 100644 7533ddc... 0597ac8... M src/effi.c :100644 100644 26da8c9... 99c646d... M src/emodules-ng.c :100644 100644 d3bae21... a934ce5... M src/ent/ent-float.c :100644 100644 c0ccfcd... ea8e8ef... M src/ent/ent-gaussian.c :100644 100644 7efcedd... e3a20d9... M src/ent/ent-gmp.c :100644 100644 e5ca291... ea9ee99... M src/ent/ent-indef.c :100644 100644 2be57c1... ed67a64... M src/ent/ent-int.c :100644 100644 0ae9500... 276c165... M src/ent/ent-lift.c :100644 100644 f7ad04e... 52cff71... M src/ent/ent-lift.h :100644 100644 fdfa1f3... eaf9318... M src/ent/ent-mpc.c :100644 100644 08ae459... 042bd18... M src/ent/ent-mpfr.c :100644 100644 fba5b79... 5778e79... M src/ent/ent-pseumpc.c :100644 100644 0d854c6... 01e2271... M src/ent/ent-quatern.c :100644 100644 f5c0c13... e7d4a84... M src/events/event-stream.c :100644 100644 4f1cbf2... 570a241... M src/events/workers.c :100644 100644 152b3db... dda4c0d... M src/extents.c :100644 100644 238509b... eb7196d... M src/lstream.c :100644 100644 55addf5... 2417209... M src/map.c :100644 100644 376c0ec... ac6c32a... M src/media/media-internal.c :100644 100644 8af1af7... 43fda46... M src/media/media-sox.h :100644 100644 8984fa7... 335585d... M src/media/sound.c :100644 100644 e70e4d1... 14d6991... M src/media/sound.h :100644 100644 cf6abd0... 0e9924d... M src/mem/blocktype.c :100644 100644 43d9265... 25f9508... M src/skiplist.c :100644 100644 83569d9... f43aa49... M src/sxe-utils.h :100644 100644 8a3d3f3... 4bcb849... M src/ui/TTY/event-tty.c :100644 100644 5925e23... 9e8d8b2... M src/ui/TTY/redisplay-tty.c :100644 100644 70f5e88... 622106f... M src/ui/X11/device-x.c :100644 100644 fc374d5... 4d69694... M src/ui/X11/event-Xt.c :100644 100644 bbec034... b81ccfe... M src/ui/keymap.c commit 0a2603e5c40f9a6e309d9698b17cb35481bccac0 Author: Nelson Ferreira Date: Sun Oct 2 17:26:45 2011 -0400 Coverity fixes * src/lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): silence value computed not used warning. * src/lisp.h: add prototypes for write_hex_ptr, write_fmt_str and write_fmt_sting. Signed-off-by: Nelson Ferreira :100644 100644 b3d2122... 148c463... M src/lisp.h commit 7d4418caa5a2ceec10bc8866ba49f6486ad0f2c1 Author: Nelson Ferreira Date: Sun Oct 2 17:23:23 2011 -0400 [ Replace this line with a one-line summary of the changes ] * src/emodules-ng.c (__emodng_find): only get module info if on debug mode Signed-off-by: Nelson Ferreira :100644 100644 fe34dd3... 26da8c9... M src/emodules-ng.c commit aaf0744b562035565f56a421683cc57fe8a61939 Author: Nelson Ferreira Date: Sun Oct 2 17:22:10 2011 -0400 Coverity fixes * src/doc.c (unparesseuxify_doc_string): decrease stack usage * src/doc.c (Fsnarf_documentation): check return of snprintf Signed-off-by: Nelson Ferreira :100644 100644 bfc938f... 3d0fb83... M src/doc.c commit a1990b58f16693a5264c4c76a3c50ab76ec8f8fe Author: Nelson Ferreira Date: Sun Oct 2 17:20:05 2011 -0400 Coverity fixes * src/ui/X11/frame-x.c (color_to_string): use snprintf instead of sprintf * src/ui/X11/frame-x.c (x_set_initial_frame_size): ditto. * src/ui/X11/frame-x.c (Fx_window_id): ditto. Signed-off-by: Nelson Ferreira :100644 100644 c473f91... 8367fe1... M src/ui/X11/frame-x.c commit 93d5585b3d51fe5bfb1e59450ee4932eba303327 Author: Nelson Ferreira Date: Sun Oct 2 17:18:08 2011 -0400 Coverity fixes * src/ui/X11/event-Xt.c (x_keysym_to_emacs_keysym): check result of snprintf * src/ui/X11/event-Xt.c (describe_event_window): ditto. * src/ui/X11/event-Xt.c (describe_event): ditto. Signed-off-by: Nelson Ferreira :100644 100644 1fb2489... fc374d5... M src/ui/X11/event-Xt.c commit 9141c5c50183f4d6f2d70e763218a016a475cbe0 Author: Nelson Ferreira Date: Sun Oct 2 17:16:05 2011 -0400 Coverity fixes * src/ui/X11/dialog-x.c (dbox_descriptor_to_widget_value): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 08b561b... 3c67ada... M src/ui/X11/dialog-x.c commit ae902379b2faac884803a2dcfd0dcf7a08847d78 Author: Nelson Ferreira Date: Sun Oct 2 17:15:03 2011 -0400 Coverity changes * src/ui/TTY/terminfo.c (emacs_tparam): use strncpy instead of strcpy Signed-off-by: Nelson Ferreira :100644 100644 e822587... 5cef1a9... M src/ui/TTY/terminfo.c commit 77ba997b77d8d2f84cb2dedf016c1647f8854a8f Author: Nelson Ferreira Date: Sun Oct 2 17:14:11 2011 -0400 Coverity fixes * src/ui/TTY/redisplay-tty.c (term_get_fkeys_1): check return of snprintf Signed-off-by: Nelson Ferreira :100644 100644 f80cc14... 5925e23... M src/ui/TTY/redisplay-tty.c commit a57c5abdde2eab0ac2d2d9db211bbe274b7be6f1 Author: Nelson Ferreira Date: Sun Oct 2 17:12:59 2011 -0400 Coverity fixes * src/ui/X11/objects-x.c (x_print_color_instance): use write_fmt_str instead of snprintf * src/ui/X11/objects-x.c (x_print_font_instance): ditto * src/ui/X11/objects-x.c (truename_via_random_props): check result of snprintf and remove not needed finalizer from strncpy. Signed-off-by: Nelson Ferreira :100644 100644 8bd4afa... cb3f6f4... M src/ui/X11/objects-x.c commit 6643fab15c4a2ca2682a7c7b1401ece15bd0a6a2 Author: Nelson Ferreira Date: Sun Oct 2 17:10:09 2011 -0400 Coverity fixes * src/ui/TTY/objects-tty.c (Ffind_tty_color): check return of snprintf * src/ui/TTY/objects-tty.c (Ftty_registered_color_list): ditto. Signed-off-by: Nelson Ferreira :100644 100644 9829d6a... 24a27d3... M src/ui/TTY/objects-tty.c commit a6f9b92f9dac20836ebbacedaae254fea64e63fd Author: Nelson Ferreira Date: Sun Oct 2 17:08:56 2011 -0400 Coverity fixes * src/ui/TTY/gpmevent.c (Fgpm_enabled_p): check return of snprintf * src/ui/TTY/gpmevent.c (Fgpm_enable): ditto. Signed-off-by: Nelson Ferreira :100644 100644 218a256... 41890bd... M src/ui/TTY/gpmevent.c commit 2b62e7cf259fc14c9fc3080936e1d3b50f8e85ff Author: Nelson Ferreira Date: Sun Oct 2 17:06:55 2011 -0400 Coverity fixes * src/ui/Gtk/ui-gtk.c (ffi_object_printer): use write_fmt_str instead of sprintf. * src/ui/Gtk/ui-gtk.c (emacs_gtk_object_printer): ditto. * src/ui/Gtk/ui-gtk.c (object_getprop): use write fmt_string instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 7791f6b... e80ab33... M src/ui/Gtk/ui-gtk.c commit 188f2dd925d79b0a32772759dd0d59de02f6b076 Author: Nelson Ferreira Date: Sun Oct 2 17:04:49 2011 -0400 Coverity fixes * src/ui/Gtk/objects-gtk.c (gtk_print_color_instance): use write_fmt_str instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 2c9af09... a4533b9... M src/ui/Gtk/objects-gtk.c commit 54a1a690905c2b77085c2f4a297ae178dc8738d9 Author: Nelson Ferreira Date: Sun Oct 2 17:03:44 2011 -0400 Coverity fixes * src/ui/Gtk/gtk-xemacs.c (xemacs_gtk_convert_color): use snprint instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 45218c4... c04c274... M src/ui/Gtk/gtk-xemacs.c commit cef7318363af827ef1be8a8c145ae0a53e23bf68 Author: Nelson Ferreira Date: Sun Oct 2 17:02:29 2011 -0400 Coverity fixes * src/ui/Gtk/glyphs-gtk.c (gtk_print_image_instance): use write_fmt_str instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 0eabf5e... f771092... M src/ui/Gtk/glyphs-gtk.c commit 50c4498ef55e89d4848d39abd7dfed496d0cda36 Author: Nelson Ferreira Date: Sun Oct 2 15:32:52 2011 -0400 Coverity fixes * src/ui/X11/xmu.c (XmuPrintDefaultErrorMessage): use snprint instead of sprintf and strncpy instead of strcpy Signed-off-by: Nelson Ferreira :100644 100644 f04d529... 1201462... M src/ui/X11/xmu.c commit 3d8307c03f667e95aaea2e72ca3c3379e729e1bb Author: Nelson Ferreira Date: Sun Oct 2 15:16:45 2011 -0400 Coverity fixes * src/ui/X11/ExternalShell.c (GetGeometry): use snprintf instead sprintf Signed-off-by: Nelson Ferreira :100644 100644 c4c64ad... 4762f37... M src/ui/X11/ExternalShell.c commit bfdfd5d2040348d851c82fc9e268e8f022bdbd4d Author: Nelson Ferreira Date: Sun Oct 2 15:15:26 2011 -0400 Coverity fixes * src/ui/Gtk/frame-gtk.c (Fgtk_window_id): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 7794b5b... aabbe66... M src/ui/Gtk/frame-gtk.c commit ce323dfe4b5df433fd32ad55cb1b5635d2707561 Author: Nelson Ferreira Date: Sun Oct 2 15:14:01 2011 -0400 Coverity fixes. * src/ui/Gtk/event-gtk.c (gtk_keysym_to_emacs_keysym): use snprintf instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 e2d887e... 8c3057a... M src/ui/Gtk/event-gtk.c commit bd67478c0d4409301a2dbabf89265ae689757d3b Author: Nelson Ferreira Date: Sun Oct 2 15:12:46 2011 -0400 Coverity fixes * src/rangetab.c (print_range_table): use write_fmt_str instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 d9fae1b... 6eadb54... M src/rangetab.c commit 1edd2621051b69b05d9c8b8224b53f067f09b5b5 Author: Nelson Ferreira Date: Sun Oct 2 15:11:19 2011 -0400 Coverity fixes * src/mule/mule-charset.c (print_charset): use write_fmt_str/write_fmt_string instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 9cf3fe0... a018d8a... M src/mule/mule-charset.c commit 92a8c7ec3f6f8f007dce5e156ebeab5fbed5ba7d Author: Nelson Ferreira Date: Sun Oct 2 15:07:04 2011 -0400 Coverity * src/ui/glyphs-eimage.c: always use safer vsnprintf. * src/ui/glyphs-eimage.c (tiff_error_func): always use safer vsnprintf. * src/ui/glyphs-eimage.c (tiff_warning_func): ditto. Signed-off-by: Nelson Ferreira :100644 100644 212f966... e3fc1e4... M src/ui/glyphs-eimage.c commit 9ef59d8f22f9f07e22661f2494a5990e517963bb Author: Nelson Ferreira Date: Sun Oct 2 14:54:22 2011 -0400 Coverity fixes * src/mule/input-method-xlib.c (EmacsXtCvtStringToXIMStyles): use snprintf instead of sprintf. * src/mule/input-method-xlib.c (describe_Window): ditto. Also check for the result of the system syscall. Signed-off-by: Nelson Ferreira :100644 100644 eb083af... 7c10248... M src/mule/input-method-xlib.c commit e1e8c5c2108bf008ed7635c84ccfdf278f927f42 Author: Nelson Ferreira Date: Sun Oct 2 14:51:35 2011 -0400 Coverity fixes * src/md5.c (Fmd5): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 0fc8a5e... 4a8262b... M src/md5.c commit 254cbaa152249fe8f9860d597c2852d6d5498895 Author: Nelson Ferreira Date: Sun Oct 2 14:48:45 2011 -0400 Coverity fixes * src/search.c (compre_prfun): Use write_fmt_str instead of snprintf * src/search.c (fast_string_match): safeguard alloca from being used with a negative length. Signed-off-by: Nelson Ferreira :100644 100644 72206aa... 52271ce... M src/search.c commit e6bc33a73872ed415bea0963e51138c14a19b110 Author: Nelson Ferreira Date: Sat Oct 1 21:06:36 2011 -0400 Coverity fixes * src/ui/glyphs.c (print_image_instance): Use write_fmt_str instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 57573f3... ac2586e... M src/ui/glyphs.c commit e8f583098a2cc95cc37a07624eade7f79051f32f Author: Nelson Ferreira Date: Fri Sep 30 20:15:32 2011 -0400 Coverity fixes * src/dired.c (dired_realpath): free the buffer if realpath fails. RESOURCE_LEAK * src/dired.c (dfr_inner): only consider the canonname as fullname if it could resolve the canonical name CID:205 REVERSE_INULL Signed-off-by: Nelson Ferreira :100644 100644 3b0af90... 2fa35d9... M src/dired.c commit 99b5f8fa81a70785930684f61d4effcfb8e878b2 Author: Nelson Ferreira Date: Fri Sep 30 20:03:12 2011 -0400 Security fixes. * src/ui/X11/device-x.c (read_locale_specific_resources): check snprintf results and use sizeof instead of countof since we are talking about chars... Signed-off-by: Nelson Ferreira :100644 100644 7ff29bd... 70f5e88... M src/ui/X11/device-x.c commit 25f4f87b5ce9dd4d06db1a4e1c83b55c890f34d6 Author: Nelson Ferreira Date: Fri Sep 30 19:54:51 2011 -0400 CID:295 SECURE_CODING * src/marker.c (print_marker): use write_fmt_str instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 f51fc1b... a16eeeb... M src/marker.c commit 6ca14c9da7542d947768d191f023e3c83d5dbfc5 Author: Nelson Ferreira Date: Fri Sep 30 19:53:18 2011 -0400 Security fixes * src/sheap.c (report_sheap_usage): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 c53cdb8... 6a7dc1b... M src/sheap.c commit efef848e8f128e7f1c348c1d2be9a81326e95f1d Author: Nelson Ferreira Date: Fri Sep 30 19:51:57 2011 -0400 Coverity fixes * src/effi.c: include sysdep.h for the async_timeout prototypes * src/effi.c (Fffi_load_library): use strncpy and strncat instead of strcpy/strcat Signed-off-by: Nelson Ferreira :100644 100644 ad4b27d... 7533ddc... M src/effi.c commit 5bd8af857e052f62eee2763f5d369d47b6ac4220 Author: Nelson Ferreira Date: Fri Sep 30 19:47:55 2011 -0400 Coverity fixes * src/ui/keymap.c (print_keymap): use write_fmt_str instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 8089528... bbec034... M src/ui/keymap.c commit 2392906b807ae7e7a98f02a843993b4d5a2c4c7f Author: Nelson Ferreira Date: Fri Sep 30 19:46:22 2011 -0400 Coverity fixes. * src/ui/X11/menubar-x.c (command_builder_operate_menu_accelerator): use write_fmt_str instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 d9c0a2e... 419ade4... M src/ui/X11/menubar-x.c commit 2f736345ae648bb1d2d13443c99da10816db7d61 Author: Nelson Ferreira Date: Fri Sep 30 19:44:33 2011 -0400 Coverity fixes * src/skiplist.c (print_skiplist): use write_fmt_str instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 3f8d1b2... 43d9265... M src/skiplist.c commit 48e4e38395f984711bcefd2de2caa063ca923128 Author: Nelson Ferreira Date: Fri Sep 30 19:42:04 2011 -0400 Coverity fixes. SECURE_CODING CI:302,301 * src/objects.c (print_color_instance): use write_fmt_str instead of sprintf * src/objects.c (print_fonr_instance): use write_fmt_str instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 13a9824... b9e023f... M src/objects.c commit 145a7e2b73a1f6930793b453792fbb6a7937e10b Author: Nelson Ferreira Date: Fri Sep 30 19:39:44 2011 -0400 Coverity fixes CID:330 * src/ui/frame.c (print_frame): use write_fmt_str and write_fmt_string instead of sprintf. Signed-off-by: Nelson Ferreira :100644 100644 ee4e77d... 2c982ce... M src/ui/frame.c commit d3a0c0747d2334910b8d7e56781430d5b4da5784 Author: Nelson Ferreira Date: Fri Sep 30 19:38:16 2011 -0400 Coverity fixes. SECURE_CODING CID:329 * src/ui/device.c (print_device): use write_fmt_string instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 b051d46... fc40164... M src/ui/device.c commit 51d485bd01a5760ea3b13ab1365cd7bb34556ea1 Author: Nelson Ferreira Date: Fri Sep 30 19:33:37 2011 -0400 Coverity fixes. SECURE_CODING CID:339,338,337 * src/ui/lwlib/xlwgauge.c: include lwlib-internal.h * src/ui/lwlib/xlwgauge.c (GaugeExpose): use snprintf instead of sprintf. small reformat of expressions to help human parsing... * src/ui/lwlib/xlwgauge.c (GaugeSelect): use snprintf instead of sprintf * src/ui/lwlib/xlwgauge.c (MaxLabel): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 53c8e3d... b6478b4... M src/ui/lwlib/xlwgauge.c commit ea86735587622cddb04275e5e09c155a6c708315 Author: Nelson Ferreira Date: Fri Sep 30 19:28:38 2011 -0400 CID:327 SECURE_CODING * src/ui/X11/scrollbar-x.c (x_create_scrollbar_instance): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 f76f71c... c3f0ce9... M src/ui/X11/scrollbar-x.c commit a9c8fcb06bfe8b43248e06d08ca80bc63a0e7d8d Author: Nelson Ferreira Date: Fri Sep 30 19:23:54 2011 -0400 Coverity fixes * src/callproc.c: remove unused report_fork_error * src/callproc.c (Fold_call_process_internal): check result from pipe (CID:152) Signed-off-by: Nelson Ferreira :100644 100644 32fe641... a38cc83... M src/callproc.c commit efff1ea850955cf937abf1bf39b09e32560ada12 Author: Nelson Ferreira Date: Fri Sep 30 19:17:38 2011 -0400 Coverity fixes * src/sysdep.c (init_system_name): use strncpy instead of strcpy * src/sysdep.h: add start/stop async timeout prototypes. Signed-off-by: Nelson Ferreira :100644 100644 c806b5a... fa74c2d... M src/sysdep.c :100644 100644 17fbfa0... 65d70c4... M src/sysdep.h commit c642ad69e1ae0a53538a895c568f79109737b1fe Author: Nelson Ferreira Date: Fri Sep 30 19:15:01 2011 -0400 Coverity fixes * src/ui/redisplay.c (add_octal_runes): make a reference to add_failed to "shutup" coverity. * src/ui/redisplay.c (decode_mode_spec): make just enough room for a long * src/ui/redisplay.c (decode_mode_spec): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 d64c5d8... 2ea5840... M src/ui/redisplay.c commit 2f19e5be35a3ba9f930b9273bcf915b518a67aab Author: Nelson Ferreira Date: Fri Sep 30 19:09:41 2011 -0400 Secure coding * src/bloom.c (print_bloom): use write_fmt_string instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 b2abc37... 7f873d8... M src/bloom.c commit 2780dc18bd810694158d5623c5a2354fde52aabd Author: Nelson Ferreira Date: Fri Sep 30 19:07:37 2011 -0400 CID:428 UNUSED_VALUE * src/ui/window.c (print_window): use write_fmt_str instead of snprintf * src/ui/window.c (margin_width_internal): no need to check this return * src/ui/window.c (print_window_config): use write_fmt_str instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 8c8e156... 8053a62... M src/ui/window.c commit ace775f3b21c31b89f5c2610db833b19feddb2fe Author: Nelson Ferreira Date: Fri Sep 30 19:02:33 2011 -0400 CID:294 SECURE_CODING * src/lstream.c (print_lstream): use write_fmt_string instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 d70c64c... 238509b... M src/lstream.c commit a5e0d17edb97d4d6c02b314dd2fb4b367ea7a7e5 Author: Nelson Ferreira Date: Fri Sep 30 19:00:30 2011 -0400 CID:291 SECURE_CODING * src/fns.c (base16_encode_1): use snprintf instead of sprint, needs addition parameter for buffer parameter... * src/fns.c (Fbase16_encode_string): use base16_encode_1 with the new parameter Signed-off-by: Nelson Ferreira :100644 100644 d34dbbd... fbde501... M src/fns.c commit f20464fa0b29d30097214423713470e39c3a3173 Author: Nelson Ferreira Date: Fri Sep 30 18:57:52 2011 -0400 CID:256 SECURE_CODING * lib-src/ootags.c (main): avoid using sprintf just to build a 1 char string... * lib-src/ootags.c (main): use snprintf instead of sprintf * lib-src/ootags.c (main): ditto. Signed-off-by: Nelson Ferreira :100644 100644 466c991... 58611e2... M lib-src/ootags.c commit ce18607b427c5072374aeaa20ce0d9eb8daad0fb Author: Nelson Ferreira Date: Fri Sep 30 18:53:33 2011 -0400 CID:150 Call result should be used * lib-src/mmencode.c (from64): check result of fgets * lib-src/mmencode.c (fromqp): ditto Signed-off-by: Nelson Ferreira :100644 100644 87e6999... 6195f16... M lib-src/mmencode.c commit 33b82ca64cc18caa691641d6c26886d45c3e08c1 Author: Nelson Ferreira Date: Fri Sep 30 18:47:11 2011 -0400 Misc security fixes * lib-src/make-docfile.c (next_extra_elc): Make appropriate check on fgets * lib-src/make-docfile.c (main): check for chdir success * lib-src/make-docfile.c (scan_c_file): check for fscanf success Signed-off-by: Nelson Ferreira :100644 100644 9cd4d5b... 3d79747... M lib-src/make-docfile.c commit 658c22dcf2e182db11489fab10d9b6b3d1ec5ec3 Author: Nelson Ferreira Date: Fri Sep 30 18:40:45 2011 -0400 CID:245,142,90 SECURE_CODING, CALL_RESULT_SHOULD_BE_CHECK, NEGATIVE_RETURN * lib-src/gnuslib.c: include assert and remove RCS * lib-src/gnuslib.c (connect_to_internet_server): use snprintf instead of sprintf, and check result from write * lib-src/gnuslib.c (disconnect_from_server): check for negative length possible result from the read. Signed-off-by: Nelson Ferreira :100644 100644 ceb38d7... 6e6bcd5... M lib-src/gnuslib.c commit c86e306109a5d377915ef6c5fc5853222bab2aea Author: Nelson Ferreira Date: Fri Sep 30 18:34:32 2011 -0400 No CID yet... * src/ui/lwlib/lwlib-Xm.c (make_dialog): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 33bf70d... 329cbea... M src/ui/lwlib/lwlib-Xm.c commit 9c13751a4e50ad094a875c17dab79b3b6a995b1b Author: Nelson Ferreira Date: Fri Sep 30 18:32:13 2011 -0400 CID:328 SECURE_CODING * src/ui/console.c (print_console): use write_fmt_string instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 c6f189c... 3f68aad... M src/ui/console.c commit 45195a31db8b74dba5e1479168bfd7919e4db53e Author: Nelson Ferreira Date: Fri Sep 30 18:28:40 2011 -0400 CID:317 * src/ui/lwlib/lwlib.c (safe_strdup): use strncpy instead of strcpy Signed-off-by: Nelson Ferreira :100644 100644 7d9b957... f0d257b... M src/ui/lwlib/lwlib.c commit dfe710a61402d72673994393f65825cf11646e3e Author: Nelson Ferreira Date: Fri Sep 30 18:20:31 2011 -0400 Small type change * lib-src/etags.c (argv): Use int instead of ssize_t as per manpage * src/print.c (std_handle_out_va): ditto * src/print.c (write_fmt_str): fix comment reference to function name Signed-off-by: Nelson Ferreira :100644 100644 5d0050d... bf6c320... M lib-src/etags.c :100644 100644 37b6867... 17c2fa8... M src/print.c commit 8cdc357845a93187e343889c9aa5dd412e13970b Author: Nelson Ferreira Date: Fri Sep 30 18:16:43 2011 -0400 SECURE_CODING * src/ui/X11/glyphs-x.c (x_print_image_instance): use write_fmt_str instead of sprintf * src/ui/X11/glyphs-x.c: removed #if 0 write_lisp_string_to_temp_file Signed-off-by: Nelson Ferreira :100644 100644 8d44661... 6888c8c... M src/ui/X11/glyphs-x.c commit 1a041fcabf6a7128436222b02d164a6b5c14dc34 Author: Nelson Ferreira Date: Fri Sep 30 18:14:24 2011 -0400 SECURE_CODING * src/dumper.c (pdump): improve security on error message Signed-off-by: Nelson Ferreira :100644 100644 d035d7b... 1d9e565... M src/dumper.c commit e9c951f097c6227235b4fd5747f09d19d597650c Author: Nelson Ferreira Date: Fri Sep 30 18:11:40 2011 -0400 CID:336 SECURE_CODING * src/ui/lwlib/lwlib-Xaw.c (make_dialog): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 cbc6f01... 0f32f5a... M src/ui/lwlib/lwlib-Xaw.c commit be6b417e62479e67414cd698a1f475d8c1a893ab Author: Nelson Ferreira Date: Fri Sep 30 18:05:42 2011 -0400 Misc coverity fixes (lost CID) * src/ui/lwlib/xlwmenu.c: include lwlib-internal.h * src/ui/lwlib/xlwmenu.c (resource_widget_value): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 1d671f6... b25921f... M src/ui/lwlib/xlwmenu.c commit 46ac865842319f1c7965e48f075b3994de855c72 Author: Nelson Ferreira Date: Fri Sep 30 18:00:39 2011 -0400 CID:57 FORWARD_NULL * src/ui/glyphs-widget.c (layout_query_geometry): make sure to test for width and height != NULL before dereference. Signed-off-by: Nelson Ferreira :100644 100644 b68367d... e68fdea... M src/ui/glyphs-widget.c commit 16065833f6d5095a06e075ee9e7eb55eed10d79f Author: Nelson Ferreira Date: Fri Sep 30 17:33:09 2011 -0400 Fixup snprintf * src/buffer.c (Fgenerate_new_buffer_name): check snprintf result Signed-off-by: Nelson Ferreira :100644 100644 b21dc71... 0718a59... M src/buffer.c commit bc3ca68aa9c4de57e3a2eebb8577649ada2f9225 Author: Nelson Ferreira Date: Fri Sep 30 17:30:11 2011 -0400 CID:341 SECURE_CODING * src/ui/lwlib/xlwtabs.c (XawTabsSetTop): use snprintf instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 b03780b... 8a34596... M src/ui/lwlib/xlwtabs.c commit e2fbcafdcdadbbbfc339d70c24937a9d28e41cec Author: Nelson Ferreira Date: Fri Sep 30 02:25:03 2011 -0400 CID:143,144 Call result should be used * lib-src/hexl.c (main): check result of fread Signed-off-by: Nelson Ferreira :100644 100644 ea636c7... 8919784... M lib-src/hexl.c commit 1ff152706d4cf1792ce5c9ce27b41d90775f8ff9 Author: Nelson Ferreira Date: Fri Sep 30 02:21:48 2011 -0400 CID:293 SECURE_CODING * src/lread.c (Fload_internal): use strncpy instead of strcpy Signed-off-by: Nelson Ferreira :100644 100644 6944355... 2642141... M src/lread.c commit e84c6df53a9942380f1dc65ec673ff2dd61d618a Author: Nelson Ferreira Date: Fri Sep 30 02:18:40 2011 -0400 CID:151 Call result should be used * lib-src/movemail.c (main): check the result of ftruncate Signed-off-by: Nelson Ferreira :100644 100644 07af3ee... 70248f7... M lib-src/movemail.c commit 167457edf8ce98fd9eddb8cb866fa118d5abe6c0 Author: Nelson Ferreira Date: Fri Sep 30 01:22:49 2011 -0400 Coverity related fixes. * src/ui/specifier.c (print_specifier): use write_fmt_string instead of snprintf Signed-off-by: Nelson Ferreira :100644 100644 c7cdc8e... 29bb731... M src/ui/specifier.c commit a2a6b1e74780bd1d5916a4b45f77a815c9fe1de3 Author: Nelson Ferreira Date: Fri Sep 30 01:17:43 2011 -0400 CID:154 - Call result should be used... * src/emacs.c (main_1): Check for return of dup(0) Signed-off-by: Nelson Ferreira :100644 100644 7c692c4... 272de9e... M src/emacs.c commit e9681b09b5a7ce7c498761dde8f664bc5c2606f8 Author: Nelson Ferreira Date: Fri Sep 30 01:01:02 2011 -0400 CID:334 * src/ui/gui.c (print_gui_item): use write_fmt_string instead of sprintf Signed-off-by: Nelson Ferreira :100644 100644 5e8916b... 001e643... M src/ui/gui.c commit 89322a1a61b0c8ebae1d608d8623594e293833e1 Author: Nelson Ferreira Date: Thu Sep 29 20:05:34 2011 -0400 Coverity fixes. Several CID's related to use of sprintf and stack usage. * src/print.c (std_handle_out_external): cleanup extranous scope * src/print.c (std_handle_out_external): remove condition for extlen == 0, since that is impossible. CID:23 DEADCODE * src/print.c (std_handle_out_va): Lowered buffer from 16K to 1K since most messages will be small and this could lead to heavy stack usage (specially upon assert failure in std_handle_out_external). CID:348,349 STACK_USE * src/print.c (internal_object_printer): Use newly refactored write_fmt_string instead of sprintf. CID:305 SECURE_CODING * src/print.c (printing_major_badness): Use snprintf CID:240 SECURE_CODING * src/print.c (default_object_printer): Use write_fmt_string instead of sprintf CID:239 SECURE_CODING * src/print.c (internal_object_printer): ditto. * src/print.c (SXE_VSNPRINT_VA): Macro to do vsnprintf with automatic buffer resizing. * src/print.c (write_fmt_str): New function for small (like integers) sprintf. * src/print.c (write_fmt_string): Moved up and refactored to use the macro which tries buffer reallocation. * src/print.c (std_handle_out_va): Refactor to use macro which tries buffer reallocation. * src/print.c (stdout_out): minor indenting change * src/print.c (fatal): Make sure not to do GETTEXT when in fatal error * src/print.c (write_hex_ptr): New function to print a pointer value in hex Signed-off-by: Nelson Ferreira :100644 100644 a0b49a8... 37b6867... M src/print.c commit 4e4b098389c3e4cafce5cf708bc67c0be68cb043 Author: Nelson Ferreira Date: Thu Sep 29 19:27:48 2011 -0400 CID:241 SECURE_CODING * lib-src/etags.c (main): use snprint and warn of truncate cmdline (and refuse to run) Signed-off-by: Nelson Ferreira :100644 100644 8b66342... 5d0050d... M lib-src/etags.c commit 485f8b6ab687062b816e7fd240652069ecb7a0a8 Author: Nelson Ferreira Date: Sun Sep 18 02:39:57 2011 -0400 CID:122 - NEGATIVE_RETURNS - Possible use of negative file descriptor * src/ui/X11/event-Xt.c(emacs_Xt_select_console): Only call select_filedesc if the descriptor is valid :100644 100644 5719a4f... 1fb2489... M src/ui/X11/event-Xt.c commit d431c63bf7b3850593e4b0b16ac4abc8ac0778ec Author: Nelson Ferreira Date: Sun Sep 18 02:38:37 2011 -0400 CID:123 - NEGATIVE_RETURNS - Possible use of negative file descriptor * src/ui/X11/event-Xt.c(emacs_Xt_select_process): Only call select_filedesc if the descriptor is valid :100644 100644 d70662d... 5719a4f... M src/ui/X11/event-Xt.c commit 62ba7094ad9b34af06ec1be68a56b6bd3623052a Author: Nelson Ferreira Date: Sun Sep 18 02:37:01 2011 -0400 CID:124 NEGATIVE_RETURNS - Possible use of negative file descriptor. * src/ui/X11/event-Xt.c(emacs_Xt_unselect_console): Only call unselect_filedesc if the descriptor is valid :100644 100644 fd8fad1... d70662d... M src/ui/X11/event-Xt.c commit d6ffcb4f3f58fc3c1ee4c1e4fd7ae008de68f036 Author: Nelson Ferreira Date: Sun Sep 18 02:35:16 2011 -0400 CID:125 - NEGATIVE RETURNS - Possible use of negative file descriptios * src/ui/X11/event-Xt.c(emacs_Xt_unselect_process): only call unselect_filedesc if indeed it is a valid one. :100644 100644 a1b9906... fd8fad1... M src/ui/X11/event-Xt.c commit d48c1d5ae6854edc231f09da3fe6545efeceba82 Author: Nelson Ferreira Date: Sun Sep 18 02:33:14 2011 -0400 CID:135 - NULL RETURNS - Possible NULL pointer dereference * src/ui/X11/console-x.h(error_check_frame_type): make assert also verify the pointer is not NULL before dereference. :100644 100644 9a0141d... f68765d... M src/ui/frame.h commit 30a505f594ffbb8daf73e92be4efcce3bdac5df7 Author: Nelson Ferreira Date: Sun Sep 18 02:28:42 2011 -0400 CID:182 - RESOURCE_LEAK - memory not freed inside Prolog_functions * lib-src/ootags.c(Prolog_functions): free last before returning :100644 100644 350f391... 466c991... M lib-src/ootags.c commit fe9b6c1d35e6796ff049a0723a5d152ee03e170a Author: Nelson Ferreira Date: Sun Sep 18 02:25:34 2011 -0400 CID:192 RESOURCE_LEAK - new argv is not freed * src/emacs.c(make_docfile): free newargv after the return of execv (which will be never if successful, but, if execv fails no memory will be leaked.) :100644 100644 397936f... 7c692c4... M src/emacs.c commit b1791dd1984cb146fd651e54b46a2dc6861ef082 Author: Nelson Ferreira Date: Sun Sep 18 02:20:33 2011 -0400 CID:226 SECURE_CODING - risky use of strcpy * lib-src/etags.c(concat): use strncpy :100644 100644 af5fcf4... 8b66342... M lib-src/etags.c commit 23dacdd87770efc88c8885c04e0309603882fc74 Author: Nelson Ferreira Date: Sun Sep 18 02:19:36 2011 -0400 CID:226 - SECURE_CODING risky usage of strcpy * lib-src/movemail.c(concat): Use strncpy :100644 100644 219bced... 07af3ee... M lib-src/movemail.c commit 5c5ab9b05b0d7060596eb82b24e69e2e67b511ea Author: Nelson Ferreira Date: Sun Sep 18 02:15:59 2011 -0400 CID:228 SECURE_CODING - risky usage of strcat * lib-src/etags.c (relative_filename): actually define res_left :100644 100644 9f1b5c4... af5fcf4... M lib-src/etags.c commit a044f33f86f5b46ad059eab48433cd43c7e22750 Author: Nelson Ferreira Date: Sun Sep 18 02:13:44 2011 -0400 Fix last commit of CID:228 SECURE_CODING - risky usage of strcat * lib-src/ootags.c (relative_filename): actually define res_left :100644 100644 3226541... 350f391... M lib-src/ootags.c commit 41f651004ee702e581a073f2e69dbc737071a019 Author: Nelson Ferreira Date: Sun Sep 18 02:06:06 2011 -0400 CID:230 SECURE_CODING - risky use of strcpy * lib-src/etags.c (write_classname): Use strncpy :100644 100644 37b270a... 9f1b5c4... M lib-src/etags.c commit c4a0c7cef9c994678fb0d57a01b3edc836cf08be Author: Nelson Ferreira Date: Sun Sep 18 00:24:47 2011 -0400 CID:232 SECURE_CODING - risky usage of strcpy * lib-src/ootags.c (inf;): Use strncpy :100644 100644 64260fd... 3226541... M lib-src/ootags.c commit ed6a69d53c4b4c8d75e4fa577c24b487f04c09e2 Author: Nelson Ferreira Date: Sun Sep 18 00:22:17 2011 -0400 CID:241 SECURE_CODING - risky usage of sprintf * lib-src/etags.c (argv): use snprintf :100644 100644 8e84d6a... 37b270a... M lib-src/etags.c commit 2af1929bcb271a1dba3060c91d955e246479bec7 Author: Nelson Ferreira Date: Sun Sep 18 00:19:53 2011 -0400 CID:318 SECURE_CODING - risky usage of sprintf * src/ui/X11/event-Xt.c (describe_event): Use snprint :100644 100644 189c450... a1b9906... M src/ui/X11/event-Xt.c commit 8ff50ec5916da4ff0cb8eb5cbdbe2aa3ea029de5 Author: Nelson Ferreira Date: Sun Sep 18 00:04:47 2011 -0400 CID:340 SECURE_CODING - risky usage of strcat * src/ui/lwlib/xlwmenu.c (parameterize_string): use strncat instead of strcat and keep the space available checked... :100644 100644 040a387... 1d671f6... M src/ui/lwlib/xlwmenu.c commit f332d26ee91f9ff3304f2a17e8638f71c1a0250b Author: Nelson Ferreira Date: Sun Sep 18 00:00:56 2011 -0400 Added sxe-utils.h with several utilities from lisp.h * src/sxe-utils.h: added code from lisp.h related to stuff like min, max, UNUSED, UNLIKELY, etc * src/lisp.h: remove code moved to sxe-utils.h and added include to it * src/sxemacs.h: added include to sxe-utils.h Signed-off-by: Nelson Ferreira :100644 100644 c30c7b7... b3d2122... M src/lisp.h :000000 100644 0000000... 83569d9... A src/sxe-utils.h :100644 100644 bb5345a... 9cec2e3... M src/sxemacs.h commit f1b073aadd7787e4241089db17046b9900678d45 Author: Nelson Ferreira Date: Sat Sep 17 17:07:34 2011 -0400 CID:475 USE AFTER FREE * lib-src/etags.c (stream;): Make sure to reset name to NULL after the free :100644 100644 0f73641... 8e84d6a... M lib-src/etags.c commit 75da3883aa5e9aa0b21b6731ea31007a44f1555b Author: Nelson Ferreira Date: Sat Sep 17 15:21:21 2011 -0400 CID:179 RESOURCE LEAK - free string in odd case * lib-src/make-docfile.c (scan_lisp_file): Free string before returning from function. This would happend only if there was a dynamic doc string with no next expression. :100644 100644 5eecb3b... 9cd4d5b... M lib-src/make-docfile.c commit 3988b6f0e4031a4c5c6effde754bdbfe7c704531 Author: Nelson Ferreira Date: Fri Sep 16 23:33:22 2011 -0400 Several fixes to dumper. CID:107,108,206 NEGATIVE_RETURNS, REVERSE_INULL * src/dumper.c: Make pdump_length an off_t to fix CID:108 * src/dumper.c (pdump_register_sub): move strlen inside the if to only do it when str!=NULL CID:206 * src/dumper.c (pdump): Make sure the fds are >=0 and abort otherwise due to the early nature of the call. Signed-off-by: Nelson Ferreira :100644 100644 6ad00e8... d035d7b... M src/dumper.c commit 20c4651c3873847e98079777df8d81cc369135e1 Author: Nelson Ferreira Date: Fri Sep 16 23:26:57 2011 -0400 CID:61 INFINITE_LOOP - Let's make the "infinite" loop very evident until we teach coverity about Fsignal... * src/ui/X11/device-x.c (signal_if_x_error): Make infinite loop real clear. Signed-off-by: Nelson Ferreira :100644 100644 429a03e... 7ff29bd... M src/ui/X11/device-x.c commit 4928d3a16e80bee862c2ff035e08218203a3a364 Author: Nelson Ferreira Date: Fri Sep 16 23:20:18 2011 -0400 CID:190 RESOURCE_LEAK free the rune when not needed... * src/ui/redisplay.c (create_text_block): use add_glyph_rune_noret Signed-off-by: Nelson Ferreira :100644 100644 905edf1... d64c5d8... M src/ui/redisplay.c commit 51a4d03b18acfb6654c341b5c98ce7e27f905ebc Author: Nelson Ferreira Date: Fri Sep 16 23:12:57 2011 -0400 CID:170,172 PW.INCLUDE_RECURSION - Avoid recursive includes * src/ui/lwlib/xlwmenu.h: Conditionally include lwlib.h * src/ui/lwlib/lwlib.h: Conditionally include xlwmenu.h Signed-off-by: Nelson Ferreira :100644 100644 72b6a58... 719f6e0... M src/ui/lwlib/lwlib.h :100644 100644 63078d9... 6f7b2f7... M src/ui/lwlib/xlwmenu.h commit 4203b7669ead397ed10a8ce908862ae5d2ba5620 Author: Nelson Ferreira Date: Fri Sep 16 23:08:57 2011 -0400 CID:174 RESOURCE LEAK - memory not freed * lib-src/etags.c (stream;): free memory in the case where it is not used Signed-off-by: Nelson Ferreira :100644 100644 49002f6... 0f73641... M lib-src/etags.c commit 6d3da4a6d4c3f7e37e73f32b6ac807aa78d7bd63 Author: Nelson Ferreira Date: Fri Sep 16 23:01:46 2011 -0400 CID:377 STRING OVERFLOW - use strncpy to avoid possible string overflow * lib-src/gnuclient.c (main): Use strncpy Signed-off-by: Nelson Ferreira :100644 100644 92eb784... 671f3a7... M lib-src/gnuclient.c commit cfb92900bc3f7d544793c9652ace58ef300d6c61 Author: Nelson Ferreira Date: Fri Sep 16 22:25:36 2011 -0400 CID:395 UNINIT - Fix uninitalized use of a member of struct gb * src/extents.c (extent_fragment_update): initialize width to 0, which seems better than some random value... Signed-off-by: Nelson Ferreira :100644 100644 24d0d0a... 152b3db... M src/extents.c commit bd9d2b26489b3cf95f5654a71912e7ea947e5000 Author: Nelson Ferreira Date: Fri Sep 16 22:09:06 2011 -0400 CID:456 FORWARD NULL - possible crash on dereference * src/media/media-ffmpeg.c (media_ffmpeg_analyse_audio): Only switch on avcc->sample_fmt if avcc != NULL Signed-off-by: Nelson Ferreira :100644 100644 dc1bcef... f3ea874... M src/media/media-ffmpeg.c commit 4cfb6a2068be4032a16e7de99508e9d01ca1eff3 Author: Nelson Ferreira Date: Fri Sep 16 21:56:13 2011 -0400 CID:468 MISSING_LOCK * src/media/sound-alsa.c (sound_alsa_play): Add the lock around aj->play_state Signed-off-by: Nelson Ferreira :100644 100644 e01160e... 34293de... M src/media/sound-alsa.c commit e0cb37d7777a2a69d9fef9fce657bf43e9c27189 Author: Nelson Ferreira Date: Fri Sep 16 21:53:29 2011 -0400 CID:469 PW.BAD_MACRO_REDEF * src/media/media-sox.c: undef UNUSED before including media-sox.h because sox.h conflicts with lisp.h definition. This should have as proper fix a SXE_UNUSED macro... For a later time. Signed-off-by: Nelson Ferreira :100644 100644 52e8844... 0237366... M src/media/media-sox.c commit 8091b99b0e8b5e0f1d9bc9265b585c5e4424f008 Author: Nelson Ferreira Date: Fri Sep 16 21:52:53 2011 -0400 CID:469 PW.BAD_MACRO_REDEF * src/media/media-sox.c: undef UNUSED before including media-sox.h because sox.h conflicts with lisp.h definition. This should have as proper fix a SXE_UNUSED macro... For a later time. Signed-off-by: Nelson Ferreira :100644 100644 ca39a2c... 52e8844... M src/media/media-sox.c commit abbacea1e851264719f077735b96216e38f5001c Author: Nelson Ferreira Date: Fri Sep 16 21:36:23 2011 -0400 CID:462 RESOURCE LEAK * src/media/media-sndfile.c (media_sndfile_open): free mtap on abnormal return Signed-off-by: Nelson Ferreira :100644 100644 d52461d... 5bf16bb... M src/media/media-sndfile.c commit 0d5520f336bbd7356912d1f527a7a4118bc27535 Author: Steve Youngs Date: Fri Sep 16 19:35:35 2011 +1000 Quick trivial one-char typo fix * src/media/sound-ao.c (sound_ao_play): Add missing ; Signed-off-by: Steve Youngs :100644 100644 9c5c1f4... ee69cdb... M src/media/sound-ao.c commit bfbb41fed218d7a9304b35d636718b8f6817bd2b Author: Nelson Ferreira Date: Fri Sep 16 05:08:20 2011 -0400 Add missing semi-color Signed-off-by: Nelson Ferreira :100644 100644 9c5c1f4... ee69cdb... M src/media/sound-ao.c commit e7291c9856761f19e790e5ddc3da7e62b1253600 Author: Nelson Ferreira Date: Fri Sep 16 05:02:59 2011 -0400 Fix stupid strncat usage mistake Signed-off-by: Nelson Ferreira :100644 100644 4296f39... dc1bcef... M src/media/media-ffmpeg.c commit f7e10d70c18279c741e058b12c07207f3df84631 Author: Nelson Ferreira Date: Fri Sep 16 03:38:17 2011 -0400 Make sure a pointer to the local ures is not returned, but a copy instead. CID:199 Signed-off-by: Nelson Ferreira :100644 100644 6c3c850... f8e2c71... M modules/ase/ase-interval.c commit b99e5f98849430b5289fa8528a2e43ab50d49c89 Author: Nelson Ferreira Date: Fri Sep 16 03:35:38 2011 -0400 Make sure to fclose the file on error CID:195 Signed-off-by: Nelson Ferreira :100644 100644 314d2ae... 2698834... M src/openssl.c commit 68c00c25312d910589b4e7ff4b4cb52fbf96c32c Author: Nelson Ferreira Date: Fri Sep 16 03:33:59 2011 -0400 Make sure to use add.*_rune_noret when not interested on the return value.. CID:175,177,190 Signed-off-by: Nelson Ferreira :100644 100644 1c21bac... 905edf1... M src/ui/redisplay.c commit f13aaac2d7059359140f640d5e0216a219f0a3d7 Author: Nelson Ferreira Date: Fri Sep 16 03:32:15 2011 -0400 Make sure that the args array is initialized CID:394 Signed-off-by: Nelson Ferreira :100644 100644 777fdff... 6c3c850... M modules/ase/ase-interval.c commit b93e4a19a1740451f09f3583e8189296fd95117a Author: Nelson Ferreira Date: Fri Sep 16 03:24:30 2011 -0400 Make sure dl.top_clip is initialized CID:406 Signed-off-by: Nelson Ferreira :100644 100644 3f326f6... 67eb9a1... M src/ui/X11/toolbar-x.c commit c27cf9442451113ae38cc618a9877fe7043a13da Author: Nelson Ferreira Date: Fri Sep 16 03:22:27 2011 -0400 Avoid doing decode_buffer twice when not doing clash detection CID:430 Signed-off-by: Nelson Ferreira :100644 100644 63a3a7a... b21dc71... M src/buffer.c commit bd3f42bc5d276a1eb0de972c1b21ad98921916e7 Author: Nelson Ferreira Date: Fri Sep 16 03:20:33 2011 -0400 Remove unneeded initialization of command_builder pointer. CID:431 Signed-off-by: Nelson Ferreira :100644 100644 6c098a3... f5c0c13... M src/events/event-stream.c commit 74a24efbf7b2b2cae554d902d1c8182246ced527 Author: Nelson Ferreira Date: Fri Sep 16 03:12:13 2011 -0400 Do not assign the return of setlocale(LC_ALL,"C") to locale var since it will be no longer used afterwards. CID:432 Signed-off-by: Nelson Ferreira :100644 100644 cf20e90... eb083af... M src/mule/input-method-xlib.c commit 2c330fc143900f8f9d42ec8970a792b8fc7a4189 Author: Nelson Ferreira Date: Fri Sep 16 03:08:39 2011 -0400 Remove unused value of eckey CID:435 Signed-off-by: Nelson Ferreira :100644 100644 93c014c... 314d2ae... M src/openssl.c commit 74e0a12ce9a5a6c0d32aee266a44cc4f0ef7fab2 Author: Nelson Ferreira Date: Fri Sep 16 03:06:33 2011 -0400 Make sure that check and change of state is done on the mutual exclusion zone. move the sleep outside of it. CID:440 Signed-off-by: Nelson Ferreira :100644 100644 6cc9030... 9c5c1f4... M src/media/sound-ao.c commit 0199ae03af9d581a3cc5d061ce546d13fdd79111 Author: Nelson Ferreira Date: Fri Sep 16 02:58:50 2011 -0400 make sure the optable_index cannot be negative, instead an assertion is made. CID:117,116,115,114,111,110,109,88,87 Signed-off-by: Nelson Ferreira :100644 100644 eb9e407... d9df318... M src/ent/ent.c commit 645c51d393756cf586aed02e4e2c60507d35a73b Author: Nelson Ferreira Date: Fri Sep 16 02:55:59 2011 -0400 Make sure avfc is not NULL before dereferencing CID:457 Signed-off-by: Nelson Ferreira :100644 100644 6479d9c... 4296f39... M src/media/media-ffmpeg.c commit 1f7d14475ad7c51360fd306feeed2bf45a42b333 Author: Nelson Ferreira Date: Fri Sep 16 02:54:12 2011 -0400 Make sure that avfc is non null before de-reference. CID:458 Signed-off-by: Nelson Ferreira :100644 100644 1b8a2c9... 6479d9c... M src/media/media-ffmpeg.c commit 29c457d81cdf29d0f120b577c5159a86377368ea Author: Nelson Ferreira Date: Fri Sep 16 02:42:43 2011 -0400 Make sure the pointers are valid before dereferencing CID:461 Signed-off-by: Nelson Ferreira :100644 100644 9ffa1c0... 1b8a2c9... M src/media/media-ffmpeg.c commit 6b22b5595c47b17665b80edca66fd2801a1d5c81 Author: Nelson Ferreira Date: Fri Sep 16 02:39:23 2011 -0400 Use strncat instead of strcat, even in a paranoid fashion. CID:463 Signed-off-by: Nelson Ferreira :100644 100644 ff3ef6b... 9ffa1c0... M src/media/media-ffmpeg.c commit 0f123bce9031ac63ec3233d5d14c3b83c74fd5ba Author: Nelson Ferreira Date: Fri Sep 16 02:29:35 2011 -0400 Make sure that mtp has the proper play state before entering the loop. CID:466 Signed-off-by: Nelson Ferreira :100644 100644 4b05f31... 6cc9030... M src/media/sound-ao.c commit b6781faf0ef11417ca4b9c534cdf41c424ab6da3 Author: Nelson Ferreira Date: Thu Sep 15 23:44:22 2011 -0400 Fix stupid typo on previous fix, that broke build. Signed-off-by: Nelson Ferreira :100644 100644 b832264... 777fdff... M modules/ase/ase-interval.c commit 4dc86a9abb14efef7fc95295a3ed9ef3226cded0 Author: Nelson Ferreira Date: Thu Sep 15 23:33:33 2011 -0400 Fix several FILE* leaks in ssl CID:193,194,195,196,197,198 Signed-off-by: Nelson Ferreira :100644 100644 e901cbd... 93c014c... M src/openssl.c commit 8169a297babb43f3d3c98e7f62d56cc79c51517e Author: Nelson Ferreira Date: Thu Sep 15 23:17:23 2011 -0400 Make implementation comment about issues with strlen of NULL pointers match the implementation Signed-off-by: Nelson Ferreira :100644 100644 56257c1... 3e8206a... M src/alloc.c commit 0cf4be2e3f709b71e415bddcdef506af3dc3c1ff Author: Nelson Ferreira Date: Thu Sep 15 23:16:01 2011 -0400 Fix several invalid uses of negative returns on acessing an array due to ase_optable_index CID:87,88,109,110,111,114,115,116,117 Signed-off-by: Nelson Ferreira :100644 100644 08ad31b... eb9e407... M src/ent/ent.c commit e33af2c8698c99df7630b756b48c80120591eed0 Author: Nelson Ferreira Date: Thu Sep 15 22:59:24 2011 -0400 Allocate and copy ures when it would be the return address. CID:200 Signed-off-by: Nelson Ferreira :100644 100644 83aadcc... b832264... M modules/ase/ase-interval.c commit 3ac8ebb6f527f54b33ebd009c5c8c682c7a6b07f Author: Nelson Ferreira Date: Thu Sep 15 22:43:44 2011 -0400 Move variable path definition to avoid out-of-scope references to the memory location. CID:201 Signed-off-by: Nelson Ferreira :100644 100644 62f6766... e399a6b... M src/editfns.c commit e500fea58533821432a4e3d00ad2ce4f7d5d664b Author: Nelson Ferreira Date: Thu Sep 15 22:36:53 2011 -0400 CID:326,325 Use snprintf instead of sprintf. Although current sizes and formatting string are fine (since it is only integer printing), it won't hurt to limit the buffer. Signed-off-by: Nelson Ferreira :100644 100644 25732e3... 8bd4afa... M src/ui/X11/objects-x.c commit 98c274850f751a0d8beb8230719eaa3c468cabdc Author: Nelson Ferreira Date: Thu Sep 15 22:32:37 2011 -0400 Use snprint instead of sprintf. One of the uses of this CID:342 was of valid concern. Signed-off-by: Nelson Ferreira :100644 100644 cba7122... c7cdc8e... M src/ui/specifier.c commit b08c9e23dfa8660efd580f57a5dcd13466ddf19e Author: Nelson Ferreira Date: Thu Sep 15 21:43:29 2011 -0400 Use snprint even if there is no issue with given size... Actually reduced it, so that the stack is less likely to blow up. CID:343 Signed-off-by: Nelson Ferreira :100644 100644 39a9fb7... 8c8e156... M src/ui/window.c commit 41ec22d5d00f8fd1cd50b92315935fc29243ea27 Author: Nelson Ferreira Date: Thu Sep 15 19:36:26 2011 -0400 Get rid of harmless warning about ignoring result of getc, while ignoring ESC ISO2022 sequences. CID:11 Signed-off-by: Nelson Ferreira :100644 100644 97a51db... 5eecb3b... M lib-src/make-docfile.c commit 12e0723d376527a27703711230761c128cbb9b24 Author: Nelson Ferreira Date: Thu Sep 15 19:01:26 2011 -0400 Avoid potential race condition and check only mtp as loop exit condition, which is updated at each switch condition that may change the state and also updated under lock. Signed-off-by: Nelson Ferreira :100644 100644 8073c87... 4b05f31... M src/media/sound-ao.c commit bd10f44c52f220c633b33971339b71c56f3bfb39 Author: Nelson Ferreira Date: Thu Sep 15 18:58:11 2011 -0400 Signed-off-by: Nelson Ferreira Correct silly mistake in previous locking fix. Use UNLOCK instead of LOCK. CID:454 :100644 100644 726f1cc... 8073c87... M src/media/sound-ao.c commit 2a25b391dc16c15a473cdeae07c74f2908e72c1e Author: Nelson Ferreira Date: Thu Sep 15 00:34:37 2011 -0400 Avoid resource leaks in redisplay (runes mostly). CID:175,176,177,186,187,188,189,190,191 Signed-off-by: Nelson Ferreira :100644 100644 30907b7... 1c21bac... M src/ui/redisplay.c commit 3e58c8da036cac45dc58e1a48b1d1efc8351942d Author: Nelson Ferreira Date: Wed Sep 14 23:44:13 2011 -0400 Enclosed the media stop status assignment inside the mutex zone. Also made sure any "derived" vars were updated CID:440,441,442 Signed-off-by: Nelson Ferreira :100644 100644 fb127d8... 726f1cc... M src/media/sound-ao.c :100644 100644 7c481b6... 9ac7732... M src/media/sound-oss.c commit f05461329a01c23ba2922fd6691db7bc3cc663c9 Author: Nelson Ferreira Date: Wed Sep 14 23:34:49 2011 -0400 Use ssize_t for string length and return from read calls CID:130,131,132,133 Signed-off-by: Nelson Ferreira :100644 100644 841df6c... e901cbd... M src/openssl.c commit fd8b8a3bb15f76d2e2bae30a1ebe314fc53356b2 Author: Nelson Ferreira Date: Wed Sep 14 23:25:35 2011 -0400 Initialize the return object to Qnil CID:452 Signed-off-by: Nelson Ferreira :100644 100644 049f0d3... d70c64c... M src/lstream.c commit 12053ed7c67df51b6d10d74a530778b4df3aceb5 Author: Nelson Ferreira Date: Wed Sep 14 23:13:27 2011 -0400 Check for NULL return from getenv on pdump_load. These are made with assert since it is so early there is no recovery possible or needed. CID:443 Signed-off-by: Nelson Ferreira :100644 100644 19c39b0... 6ad00e8... M src/dumper.c commit 5ad7dd003d7dd641db9b48b0f6592b4842943099 Author: Nelson Ferreira Date: Wed Sep 14 23:11:02 2011 -0400 Check for NULL return from getenv CID:444 Signed-off-by: Nelson Ferreira :100644 100644 abb35e3... 62f6766... M src/editfns.c commit 4c56069688f2a058c109ea7e4b73d6b192fe4bcb Author: Nelson Ferreira Date: Wed Sep 14 22:54:49 2011 -0400 Remove superfluous pointer check which seems to trigger CID:445 Signed-off-by: Nelson Ferreira :100644 100644 6ac936d... fb127d8... M src/media/sound-ao.c commit 7c0ce6b5e7d6f83c530a222e656a8d7e76dad9eb Author: Nelson Ferreira Date: Wed Sep 14 06:17:22 2011 -0400 Fix potential usage of negative file handle CID:119 :100644 100644 6b06c15... 6944355... M src/lread.c commit c287beb0ed2738a6d6276908e0111f2ceb53f6dc Author: Nelson Ferreira Date: Wed Sep 14 06:15:46 2011 -0400 Fix potential usage of negative file descriptor CID:120 :100644 100644 77dc2ba... 2f23a47... M src/ui/TTY/console-tty.c commit f405cbbbe32390d2566c2beaf5c625890f0141a4 Author: Nelson Ferreira Date: Wed Sep 14 06:10:40 2011 -0400 Fix potential usage of negative file handle CID:119 Signed-off-by: Nelson Ferreira :100644 100644 5152924... 049f0d3... M src/lstream.c commit 8a746856b518bfebda288e42b123efddd0056a74 Author: Nelson Ferreira Date: Wed Sep 14 05:45:51 2011 -0400 Make loop explicit in signal_if_x_error CID:61 Signed-off-by: Nelson Ferreira :100644 100644 0b3232f... 429a03e... M src/ui/X11/device-x.c commit cfd1add02f324342f7759be9072370d3641a713d Author: Nelson Ferreira Date: Wed Sep 14 05:41:35 2011 -0400 Shutup unchecked call return value (CID:13) Signed-off-by: Nelson Ferreira :100644 100644 b2c2890... 3b0af90... M src/dired.c commit bab7ced32042a27158cc4071953fd3a5bd5861d1 Author: Nelson Ferreira Date: Wed Sep 14 05:34:29 2011 -0400 Fix potential array overrun of static due to sign bit expansion CID:141 :100644 100644 0770941... dea767c... M src/ui/imgproc.c :100644 100644 31c67e8... dbe8255... M src/ui/imgproc.h commit 9a05aef02ce6295b9ed9ea4ab21d966192322cfd Author: Nelson Ferreira Date: Wed Sep 14 05:27:18 2011 -0400 Fix undefined order of eval in while condition. CID:30 :100644 100644 f1a2e7a... d3bae21... M src/ent/ent-float.c :100644 100644 e438f05... d34dbbd... M src/fns.c commit bfe35695270a23519dbf07d1753d0338188c8911 Author: Nelson Ferreira Date: Wed Sep 14 04:36:00 2011 -0400 Fix potential stack/string overflow warning CID:379 :100644 100644 a2441a8... d5c1740... M src/symbols.c commit 5d005036fed821ef324ffc11b5d1f2c2096abb90 Author: Nelson Ferreira Date: Wed Sep 14 04:29:22 2011 -0400 Fix potential stack overflow (via string overflow) CID:380 :100644 100644 ea29847... a2441a8... M src/symbols.c commit 16415314c4d55836d8d68a5501b1897dc60afb85 Author: Nelson Ferreira Date: Wed Sep 14 04:24:09 2011 -0400 Use snprintf instead of sprint CID:344 SECURE_CODING :100644 100644 20e5800... 39a9fb7... M src/ui/window.c commit 14bfb75b6c1b3bb3ddda1ef67d81f5f528e83a74 Author: Nelson Ferreira Date: Wed Sep 14 04:16:58 2011 -0400 Fix strcpy from environment variable into fixed size buffer. Fix strcat from argument into fixed size buffer (call to expand_filename). CID:381 :100644 100644 856de67... 92eb784... M lib-src/gnuclient.c commit e3696f36872c948d5a9767ac3215f25f07e6d6bd Author: Nelson Ferreira Date: Wed Sep 14 04:15:53 2011 -0400 Fix unchecked strcpy from commandline argument into fixed size buffer CID:382 :100644 100644 9660858... ce4d1a0... M lib-src/yow.c commit 2c189e4a741cb2b604420d70d6e6878596f43a11 Author: Nelson Ferreira Date: Wed Sep 14 01:05:59 2011 -0400 Fix the ent-mpc issues of Bug 126. :100644 100644 adcf2da... 2adcac1... M src/ent/ent-mpc.h commit ee57c8f50fd14ab598244b190d1c051c0c6ca6ec Author: Nelson Ferreira Date: Wed Sep 14 00:59:52 2011 -0400 Check the result of sxemacs_stat in Fwrite_region_internal (CID:14) :100644 100644 ec8e1e9... 9f4ba2e... M src/fileio.c commit 524de51eeeaace9c84a933f778798a45fa611c6e Author: Nelson Ferreira Date: Tue Sep 13 23:20:05 2011 -0400 Prevent harmless COVERITY warning message of the BAD_ALLOC_STRLEN checker on relative_filename about the usage of pointer+1 inside strlen as parameter to xnew. Changed it because it is indeed more maintainable to walk past the '/' and use that afterwards. :100644 100644 c1e806f... 49002f6... M lib-src/etags.c :100644 100644 f843e86... 64260fd... M lib-src/ootags.c commit 78bfe4f2108f42e55a0b4bda8601de8f2865c939 Author: Nelson Ferreira Date: Tue Sep 13 22:44:30 2011 -0400 Fix CID:436 Unused value :100644 100644 924f0b3... 08b561b... M src/ui/X11/dialog-x.c commit 231ffe1a4b25ba6275377c346577afd0565cd776 Author: Nelson Ferreira Date: Tue Sep 13 22:36:15 2011 -0400 Fix CID:437 Unused value :100644 100644 c3ae59c... 57573f3... M src/ui/glyphs.c commit 6d75147f02d56ed339f63eb55874e0adabac8e4b Author: Steve Youngs Date: Tue Sep 13 10:37:37 2011 +1000 Purge SXEmacs of tooltalk -- remainding tidy up Finger's crossed, this is the END of tooltalk. Yay! * PROBLEMS: Delete the tooltalk stuff. * etc/tests/external-widget/Makefile (CFLAGS): Remove the -DTOOLTALK flag * etc/tests/external-widget/test-ew-motif.c (handle_tt_input): Remove. It was tooltalk. * etc/tests/external-widget/test-ew-motif.c (HxInitializeToolTalk): Ditto. * etc/tests/external-widget/test-ew-motif.c (main): Don't call HxInitializeToolTalk(). * info/external-widget.texi (Using an External Client Widget): Don't mention tooltalk. * src/events/event-stream.c (execute_internal_event): Mention in comments relating to tooltalk to revisit with D-Bus * src/ui/X11/ExternalClient.h (XtNuseToolTalk): Remove. * src/ui/X11/ExternalClient.h (XtCUseToolTalk): Ditto. * .gitignore: Remove tooltalk directory. Signed-off-by: Steve Youngs :100644 100644 196d716... 51a6c56... M .gitignore :100644 100644 d6a5775... 81db39f... M PROBLEMS :100644 100644 0692ed9... 8e6c0e0... M etc/tests/external-widget/Makefile :100644 100644 15061c7... 3fa9aa8... M etc/tests/external-widget/test-ew-motif.c :100644 100644 6f318f1... 0490ec3... M info/external-widget.texi :100644 100644 813c2ca... 6c098a3... M src/events/event-stream.c :100644 100644 5de3623... a6a8a72... M src/ui/X11/ExternalClient.h commit b359d963178f727f70ed74b16a8e99ae8f370f85 Author: Steve Youngs Date: Tue Sep 13 03:03:00 2011 +1000 Purge SXEmacs of tooltalk cruft -- src, lisp This kills off pretty much all of the tooltalk. But I expect a couple more (at least) changesets to completely tidy it up. * lisp/Makefile.am (corelispels): Remove check-features.el. It was just tooltalk and sparcwork cruft. * lisp/dumped-lisp.el (packages-hardcoded-lisp): Remove tooltalk related stuff. Was all just comments anyway. * lisp/subr.el (error): Remove tooltalk-error * src/ui/Makefile.am (libsxeui_a_headers): Remove tooltalk.h * src/ui/X11/ExternalClientP.h: Remove the use_tooltalk member from the ExternalClientPart struct. * src/ui/X11/ExternalClient.c: Remove tooltalk cruft. * src/ui/X11/ExternalClient.c (send_tooltalk_handshake): Remove. * src/ui/X11/ExternalClient.c (tt_callback): Ditto. * src/symsinit.h: Remove tooltalk cruft. * src/procimpl.h: Remove tooltalk from process_methods * src/process.c (connected_via_filedesc_p): return 0 regardless. It was only ever non-0 with a tooltalk connection. 'nuff said. * src/process-unix.c (unix_tooltalk_connection_p): Remove. * src/process-unix.c (process_type_create_unix): Remove tooltalk cruft. * src/lrecord.h: Remove tooltalk cruft. * src/inline.c: Ditto. * src/gdbinit: Ditto. * src/emacs.c (shut_down_emacs): Ditto. * src/dbxrc (Usage): Ditto. Signed-off-by: Steve Youngs :100644 100644 dc828f6... a1cdbe1... M lisp/Makefile.am :100644 000000 a4f2e2c... 0000000... D lisp/check-features.el :100644 100644 c4b4ca1... c57c71a... M lisp/dumped-lisp.el :100644 100644 6cd13e3... e662dd0... M lisp/subr.el :100644 100644 108bba4... 26ef24f... M src/dbxrc :100644 100644 ba27e28... 397936f... M src/emacs.c :100644 100644 f50dcc8... fefb2a4... M src/gdbinit :100644 100644 5a952d3... da97660... M src/inline.c :100644 100644 d5192b6... 1435aba... M src/lrecord.h :100644 100644 123fc2a... 00139b7... M src/process-unix.c :100644 100644 455e46b... 68305a2... M src/process.c :100644 100644 55a87a7... fbbb461... M src/procimpl.h :100644 100644 4fdcda9... be16cc8... M src/symsinit.h :100644 000000 e78b988... 0000000... D src/tooltalk.c :100644 000000 d752e66... 0000000... D src/tooltalk.doc :100644 100644 0746af1... 17cbb13... M src/ui/Makefile.am :100644 100644 472ec94... efde8a7... M src/ui/X11/ExternalClient.c :100644 100644 58b87eb... 8cc8c4b... M src/ui/X11/ExternalClientP.h :100644 000000 218225e... 0000000... D src/ui/tooltalk.h commit 4e3e32b885e43b60602509c77881970a46d7842d Author: Steve Youngs Date: Tue Sep 13 01:07:35 2011 +1000 Purge SXEmacs of tooltalk madness -- test suite This eradicates tooltalk from our test suite. * tests/Makefile.am (tooltalk_tests): Removed. * tests/Makefile.am (EXTRA_DIST): Remove tooltalk_tests. Signed-off-by: Steve Youngs :100644 100644 abbd7ca... 58a2a37... M tests/Makefile.am :100644 000000 ba5240b... 0000000... D tests/tooltalk/Makefile :100644 000000 fb265da... 0000000... D tests/tooltalk/beeps.el :100644 000000 2c37e60... 0000000... D tests/tooltalk/emacs-eval.c :100644 000000 4f0e6ad... 0000000... D tests/tooltalk/load-file.c :100644 000000 128fca9... 0000000... D tests/tooltalk/make-client-frame.c :100644 000000 c8ebffc... 0000000... D tests/tooltalk/simple.el commit f630823748bc0215843d131ab437026cf75c5bb3 Author: Steve Youngs Date: Tue Sep 13 00:31:59 2011 +1000 Purge SXEmacs of tooltalk and CDE cruft -- docs, autoconf Tooltalk was some old Sun/Sparcworks thingamajiggy. Nobody uses it anymore and it has been superseded by D-Bus anyway. Even though SXEmacs doesn't yet have full (any?) D-Bus support we're nuking this silly tooltalk madness now. This changeset removes the tooltalk cruft from our build chain autotool stuff and from the docs. * configure.ac: Remove all the tooltalk and CDE cruft. * m4/sxe-summary.m4 (SXE_SUMMARY): Ditto. * etc/PACKAGES: Ditto. * info/sxemacs-faq.texi (Q4.4.2): Removed. Plus nuke other mentions of tooltalk. * info/sxemacs/packages.texi (Available Packages): Remove tooltalk. Yes I know that the tooltalk XEmacs package is still available, but there's not much point in saying so in the SXEmacs manual if SXEmacs doesn't support tooltalk at all. * info/lispref/objects.texi: Remove all the tooltalk cruft. * info/lispref/lispref.texi: Ditto. * info/lispref/hooks.texi (Standard Hooks): Ditto. * info/lispref/errors.texi (Standard Errors): Ditto. * info/internals/internals.texi: Ditto. * info/lispref/ldap.texi (LDAP Support): Set prev node to X-Windows. Skips tooltalk. * info/lispref/x-windows.texi (X-Windows): Set next node to LDAP Support. Skips tooltalk. Signed-off-by: Steve Youngs :100644 100644 b62310e... 6d62a17... M configure.ac :100644 100644 e1720e1... 13cbd4b... M etc/PACKAGES :100644 000000 dea463a... 0000000... D info/Makefile.obsolete :100644 100644 f9035b6... 6ce4a2d... M info/internals/internals.texi :100644 100644 9b510c5... cfc0a44... M info/lispref/errors.texi :100644 100644 c0ba926... 05e05d3... M info/lispref/hooks.texi :100644 100644 f33160b... 99152b7... M info/lispref/ldap.texi :100644 100644 fa55376... a33bf7a... M info/lispref/lispref.texi :100644 100644 f0fa348... 23e8db5... M info/lispref/objects.texi :100644 000000 693d4b6... 0000000... D info/lispref/tooltalk.texi :100644 100644 1662a70... 06d3690... M info/lispref/x-windows.texi :100644 100644 e998d96... fb0ee5f... M info/sxemacs-faq.texi :100644 100644 2f14f11... d9238e3... M info/sxemacs/packages.texi :100644 100644 4be5f78... 20f251e... M m4/sxe-summary.m4 commit 17c4890036d6eb15c2cadd59079a0308811b2d8e Author: Zajcev Evgeny Date: Tue Jun 21 16:47:10 2011 +0400 - [FIX] ffi-curl, avoid signalling Signed-off-by: Zajcev Evgeny :100644 100644 1ce365e... f2b4ea1... M lisp/ffi/ffi-curl.el commit 25efa66cc66274a744cacb5dbb877fb6ac1736f7 Author: Zajcev Evgeny Date: Tue Jun 21 11:15:39 2011 +0400 ffi-wand, removed some dups Signed-off-by: Zajcev Evgeny :100644 100644 da09c19... d3e7fc2... M lisp/ffi/ffi-wand.el commit 5a94101323ed5f2cdba8ce69c4e8a7fccf4bbc57 Author: Zajcev Evgeny Date: Mon Jun 20 19:56:04 2011 +0400 - revert, avoid raw format check Signed-off-by: Zajcev Evgeny :100644 100644 607760a... da09c19... M lisp/ffi/ffi-wand.el commit 24d257de634928f0e8e804e010b0c97a246fcb52 Author: Zajcev Evgeny Date: Thu Jun 16 13:16:28 2011 +0400 - [add] wand: partial support for GM lib - [fix] safe version of ffi-magic misc enhs :100644 100644 36d362e... 607760a... M lisp/ffi/ffi-wand.el commit 40098fccc15a565a136d36219d44c22ebbb0af44 Author: Steve Youngs Date: Thu Jun 16 12:36:17 2011 +1000 Sundry FFI fixes (see bug #127) Here are a couple of FFI fixes that bring us closer to fixing bug #127 * lisp/ffi/ffi-sqlite.el (sqlite-bind-value): Use sqlite-STATIC instead of sqlite-TRANSIENT * src/effi.c (ffi_call_using_libffi): Temporarily turn of async timeouts when calling ffi_call() * src/signal.c (stop_async_timeouts): Make it available externally. * src/signal.c (start_async_timeouts): Ditto. Signed-off-by: Steve Youngs :100644 100644 6f7b371... 3dbffa5... M lisp/ffi/ffi-sqlite.el :100644 100644 4f0635e... ad4b27d... M src/effi.c :100644 100644 fe6abfb... 9251a0a... M src/signal.c commit a2153383210b07e3bc0d8bc281647ee530907eb5 Author: Zajcev Evgeny Date: Tue Jun 14 22:34:45 2011 +0400 - [enh] ffi-magic with safe strings :100644 100644 f92af62... 69e863d... M lisp/ffi.el :100644 100644 280d050... 5068146... M lisp/ffi/ffi-magic.el commit ad9e2b4f262ca555dc96b5f473a4f55709ad620c Author: Steve Youngs Date: Thu May 12 09:50:23 2011 +1000 Fix building with current git FFmpeg * m4/sxe-mm.m4 (SXE_MM_CHECK_FFMPEG): Turn off -Werror in the test to see if url_fopen() needs ByteIOContext**. That stuff is now deprecated in current FFmpeg git repo. This patch allows SXEmacs to build with it, although, with loads of warnings. Yeah, I'm on it. :-) Signed-off-by: Steve Youngs :100644 100644 919cad7... b1842bd... M m4/sxe-mm.m4 commit 3137c1f8547cb644bb2f58c129c4fd3f9efa1ecb Author: Steve Youngs Date: Sat May 7 17:57:33 2011 +1000 Update and fix our .desktop file. * etc/sxemacs.desktop.in (StartupNotify): Set to false. I'm almost certain we don't do this. * etc/sxemacs.desktop.in (MimeType): Update to include all the MIME types I can think of that we support. * etc/sxemacs.desktop.in (Categories): The spec says that if we're a "TextEditor", we should also be a "Utility". So add that. Signed-off-by: Steve Youngs :100644 100644 4b12649... bfc04ae... M etc/sxemacs.desktop.in commit 57b7c2148871b254536dc0732b7d71409ad9c434 Author: Steve Youngs Date: Sat May 7 02:20:17 2011 +1000 Libpng 1.5 fix. One of the things they did in libpng 1.5 was to remove all the stuff in 1.4 and earlier that had been marked deprecated. Of course we were using some of those deprecated things. This patch fixes that and brings back PNGs to SXEmacsen built with the latest libpng. * src/ui/glyphs-eimage.c (png_instantiate): Rewrite and update for libpng 1.5.x. Also, handle interlaced PNGs. Signed-off-by: Steve Youngs :100644 100644 0322168... 212f966... M src/ui/glyphs-eimage.c commit e624dd0d042594f851ab12903b28f9597a08edea Author: Nelson Ferreira Date: Mon Apr 18 13:12:00 2011 -0400 * src/mule/input-method-xlib.c: Fix a header due to EmacsFrame.h move that had been overlooked. Signed-off-by: Nelson Ferreira :100644 100644 a92c53c... cf20e90... M src/mule/input-method-xlib.c commit 0524224d1442a02959248ffeea8916612f3bd45b Author: Nelson Ferreira Date: Mon Apr 18 13:06:30 2011 -0400 Even friendlier advice to the novice git SXEmacs contributor. * autogen.sh: also state one needs to git push --tag * autogen.sh: if the detected TREE_VERSION differs from the expected, issue a warning Signed-off-by: Nelson Ferreira :100755 100755 3876839... 7ad456a... M autogen.sh commit e3c67d680963dd79d409cf78bed451de25eaeb71 Author: Nelson Ferreira Date: Mon Apr 18 12:11:16 2011 -0400 * src/ui/glyphs.c: properly allow Q_mask_{file,data}, Q_hotspot_{x,y}, Q_foreground, Qbackground on tty only builds. * src/ui/glyphs.c(syms_of_glyphs): ditto. * src/ui/glyphs.c(xface_normalize): properly handle tty only builds by returning nil when HAVE_WINDOW_SYSTEM is not defined and conversion is needed. Signed-off-by: Nelson Ferreira :100644 100644 b191e55... c3ae59c... M src/ui/glyphs.c commit 5948c7c4c8d608de8432a1f0a5dda556335ef0ce Author: Nelson Ferreira Date: Mon Apr 18 12:07:50 2011 -0400 Build improvements * autogen.sh: when outside of "proper" git repos try to be friendlier by using the defaults and suggest the tag command. * src/Emacs{Frame,Manager,Shell}*, src/External*: moved into src/ui/X11 as that is the proper place for those files * src/Makefile.am, src/ui/X11/Makefile.am: adjust targets for move of the files * src/mule/input-method-motif.c: adjust header path * src/ui/lwlib/lwlib-Xlw.c: ditto Signed-off-by: Nelson Ferreira :100755 100755 23cc576... 3876839... M autogen.sh :100644 000000 7e00848... 0000000... D src/EmacsFrame.c :100644 000000 754145c... 0000000... D src/EmacsFrame.h :100644 000000 31bb220... 0000000... D src/EmacsFrameP.h :100644 000000 df7f055... 0000000... D src/EmacsManager.c :100644 000000 ed0b03f... 0000000... D src/EmacsManager.h :100644 000000 d588388... 0000000... D src/EmacsManagerP.h :100644 000000 cdcf626... 0000000... D src/EmacsShell-sub.c :100644 000000 10cf3e9... 0000000... D src/EmacsShell.c :100644 000000 b852606... 0000000... D src/EmacsShell.h :100644 000000 440329e... 0000000... D src/EmacsShellP.h :100644 000000 26e6445... 0000000... D src/ExternalClient-Xlib.c :100644 000000 472ec94... 0000000... D src/ExternalClient.c :100644 000000 5de3623... 0000000... D src/ExternalClient.h :100644 000000 58b87eb... 0000000... D src/ExternalClientP.h :100644 000000 c4c64ad... 0000000... D src/ExternalShell.c :100644 000000 8d3245a... 0000000... D src/ExternalShell.h :100644 000000 6288c5b... 0000000... D src/ExternalShellP.h :100644 100644 7dc66a0... 6b8791e... M src/Makefile.am :100644 100644 569583e... af1d2b8... M src/mule/input-method-motif.c :000000 100644 0000000... 7e00848... A src/ui/X11/EmacsFrame.c :000000 100644 0000000... 754145c... A src/ui/X11/EmacsFrame.h :000000 100644 0000000... 31bb220... A src/ui/X11/EmacsFrameP.h :000000 100644 0000000... df7f055... A src/ui/X11/EmacsManager.c :000000 100644 0000000... ed0b03f... A src/ui/X11/EmacsManager.h :000000 100644 0000000... d588388... A src/ui/X11/EmacsManagerP.h :000000 100644 0000000... cdcf626... A src/ui/X11/EmacsShell-sub.c :000000 100644 0000000... 10cf3e9... A src/ui/X11/EmacsShell.c :000000 100644 0000000... b852606... A src/ui/X11/EmacsShell.h :000000 100644 0000000... 440329e... A src/ui/X11/EmacsShellP.h :000000 100644 0000000... 26e6445... A src/ui/X11/ExternalClient-Xlib.c :000000 100644 0000000... 472ec94... A src/ui/X11/ExternalClient.c :000000 100644 0000000... 5de3623... A src/ui/X11/ExternalClient.h :000000 100644 0000000... 58b87eb... A src/ui/X11/ExternalClientP.h :000000 100644 0000000... c4c64ad... A src/ui/X11/ExternalShell.c :000000 100644 0000000... 8d3245a... A src/ui/X11/ExternalShell.h :000000 100644 0000000... 6288c5b... A src/ui/X11/ExternalShellP.h :100644 100644 0d50ebe... 1b5e66c... M src/ui/X11/Makefile.am :000000 100644 0000000... 69ccef5... A src/ui/X11/xintrinsic.h :000000 100644 0000000... e5c11c0... A src/ui/X11/xintrinsicp.h :100644 100644 82aef57... d4777d6... M src/ui/lwlib/lwlib-Xlw.c :100644 000000 69ccef5... 0000000... D src/xintrinsic.h :100644 000000 e5c11c0... 0000000... D src/xintrinsicp.h commit ae4f56c0181f68b112fcb76e4995f953370e5afb Author: Steve Youngs Date: Sat Mar 19 09:19:41 2011 +1000 Couple more warning fixes * src/media/sound-jack.c (sound_jack_shutdown_cbfun): Use %p mask to prevent compiler warning. * src/media/media.c (__add_prop): Drop the artificial attribute to prevent a compiler warning. Signed-off-by: Steve Youngs :100644 100644 9777433... 78dcda8... M src/media/media.c :100644 100644 85b934b... 42699aa... M src/media/sound-jack.c commit e3337135b8da41305d5f18c3f60ec43588a94f95 Author: Steve Youngs Date: Fri Mar 18 23:00:18 2011 +1000 Fix a few more compiler warnings. * src/skiplist.h: #if 0 out some as yet unused function declarations. Prevents compiler warnings. * src/openssl.c (Fossl_ssl_cipher_description): SSL_get_current_cipher returns a const, so needs to be stored in a const. Prevents compiler warning. * src/openssl.c (Fossl_ssl_cipher_version): Ditto. * src/openssl.c (Fossl_ssl_cipher_name): Ditto. * src/openssl.c (Fossl_ssl_cipher_bits): Ditto. Signed-off-by: Steve Youngs :100644 100644 57a6d03... 841df6c... M src/openssl.c :100644 100644 bf452bc... 3f48dfa... M src/skiplist.h commit 9882c223485e9481ca620554eab0d1001726df24 Author: Steve Youngs Date: Mon Mar 14 18:43:31 2011 +1000 Fixes all byte-compiler warnings in our elisp. * lisp/ffi/ffi-wand.el (Wand-mode-insert-info, Wand-mode-select-region): Use #'when-boundp to avoid byte-compiler warning. Also require wid-edit for same. * lisp/help.el: Globally declare #'find-function #'find-variable and #'view-scroll-lines-up at compile time to avoid byte-compiler warnings. * lisp/minibuf.el (x-read-color-completion-table): defvar it at compile time to avoid byte-compiler warning. Signed-off-by: Steve Youngs :100644 100644 bb5a288... 36d362e... M lisp/ffi/ffi-wand.el :100644 100644 bdb6b31... 3ec02df... M lisp/help.el :100644 100644 f1572bd... 8ae557e... M lisp/minibuf.el commit 14473da93cb50edd102821b88e5c6494df346263 Author: Steve Youngs Date: Mon Mar 14 17:36:18 2011 +1000 Fix several compiler warnings in C sources. This takes care of most of the compiler warnings that have crept back into the C sources. There are a couple more left, but they will require us to catch up with current versions of libpng and ffmpeg, so not quite as trivial as the rest of this patch. * modules/ase/ase-metric.c (ase_metric_prnt): Don't try to cast XASE_METRIC_DIST to unsigned int, use %p printf mask instead. Prevents compiler warning about casting pointer to int of different size. * src/ui/TTY/terminfo.c (emacs_tparam): cast string to char* to keep tparm/ncurses happy. Prevents compiler warning. * src/ui/X11/glyphs-x.c (x_subwindow_query_geometry): Cast dx, dy to int. Prevents a compiler warning about wrong types. * src/media/sound-alsa.h (sound_alsa_aj_data_s): samplerate is an unsigned int. Prevents a compiler warning. Signed-off-by: Steve Youngs :100644 100644 68c8171... b61c0ee... M modules/ase/ase-metric.c :100644 100644 ef7f496... 61bd4f6... M src/media/sound-alsa.h :100644 100644 1df88a4... e822587... M src/ui/TTY/terminfo.c :100644 100644 6667f7d... 8d44661... M src/ui/X11/glyphs-x.c commit 18d23f87c34415e83693b14bdce915ed8ef5c080 Author: Steve Youngs Date: Mon Mar 14 08:19:33 2011 +1000 Add Last version ChangeLog and tweak SPPM * info/sppm.texi (Making Releases): Tweak the instructions in a couple of places. Signed-off-by: Steve Youngs :000000 100644 0000000... 971bc6a... A ChangeLog.d/ChangeLog-22.1.14 :100644 100644 71e0aca... 9685bb6... M info/sppm.texi