* Zajcev Evgeny <zevlg@xxxxxxxxx> writes:
> Steve Youngs <steve@xxxxxxxxxxx> writes:
>> [...not handled in switch errors...]
>>
>> *** I find all those "enumeration value `foo' not handled in switch"
>> warnings very off putting. Is there something that can be done
>> about them? Oh and I mean "fixed" not "hidden" :-P
> Use -Wno-switch gcc flag.
Did you notice the words `"Oh and I mean "fixed" not "hidden"'?
>>
/home/steve/programming/SXEmacs/core/sxemacs-22.1.0/lib-src/movemail.c:581:
warning: the use of `mktemp' is dangerous, better use `mkstemp'
>>
>> *** This just plain scares the fuck out of me. Can somebody please
>> fix this.
> just change mktemp() to mkstemp() :))
But what about...
,----[ Man: mktemp(3) ]
| SYNOPSIS
| #include <stdlib.h>
|
| char *mktemp(char *template);
`----
,----[ Man: mkstemp(3) ]
| SYNOPSIS
| #include <stdlib.h>
|
| int mkstemp(char *template);
`----
...those differences? One's a char and the other's an int. Does that
matter?
> it is true: 255 can't be greater than 255.
I'm sure my wife could think of a way to argue that. :-)
> I believe that this patch should work:
Great! Where's your repo?
> btw: I've noticed you are using style like:
> static int get_unallocated_leading_byte(int dimension) [1]
> I would recommend using
> static int
> get_unallocated_leading_byte(int dimension) [2]
And I would agree with you. I'll happily accept any patches that does
this.
>> [...checks...]
>>
>> *** Whenever you build, *ALWAYS* run `make check'. And if it doesn't
>> pass 100% clean, worry. Find out why. Fix it if you can. And
>> report it here.
> Some test fails, because they require some packages to be installed.
> For example os-tests.el requires sh-script package (for
> `executable-find' function).
> Also ccl-tests.el should run only when building muleised sxemacs,
> because it requires `ccl-execute' function.
OK, cool. But as a developer you should have these packages already
installed anyway, no?
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| In space, |
| No one can hear you rip a stinky |
|------------------------------------<steve@xxxxxxxxxxx>---|
pgpCmTMDyPHLo.pgp
Description: PGP signature
|