sxemacs-devel
[Top] [All Lists]

Re: [Success] "steve@xxxxxxxxxxxxxxxxx/sxemacs--main--22.1.0--patch-8"

From: Steve Youngs <steve@xxxxxxxxxxx>
Subject: Re: [Success] "steve@xxxxxxxxxxxxxxxxx/sxemacs--main--22.1.0--patch-8"
Date: Wed, 15 Dec 2004 00:05:32 +1000
Organization: The SXEmacs Project
User-agent: Gnus/5.110003 (No Gnus v0.3) sxemacs/22.1
* Zajcev Evgeny <zevlg@xxxxxxxxx> writes:

  > Steve Youngs <steve@xxxxxxxxxxx> writes:
  >> * Zajcev Evgeny <zevlg@xxxxxxxxx> writes:
  >> > It is not critical thing that you ommit some cases declared in
  >> > enum type, but sometimes useful to track error when you forgot to
  >> > handle some condidion which you've declared in enum type.  So
  >> > -Wno-swich can be considered as fix.
  >> 
  >> OK, so we add `-Wno-switch' to the "hard-coded" (in the Makefile.in)
  >> compiler flags and everyone's happy.  Until one day someone introduces
  >> a bug that _NOT_ having this flag set may have alerted the person who
  >> introduced the bug that his code had a bug.
  >> 
  >> See what I'm getting at?

  > ok, normally to avoid such warning - avoid using enum type at all.
  > But it is stupid.  Any other(fixing code) solution is worse than
  > -Wno-switch.

  > Ok, what if we will have TAG_CFLAGS to build tag programs and CFLAGS
  > to build other programs.  TAG_CFLAGS will include -Wno-switch and
  > CFLAGS wont?

  > BTW: such bugs are easy to catch, even eisier than fixing existing
  > code to avoid warnings.

Evgeny, I am shocked and astounded.  Please explain to me why the
answer isn't something like...

  Find out if these unused thingies really are unused and delete
  them.  And if for some strange bazaar reason they really are used
  but because of some weird voodoo the compiler thinks they aren't,
  find a way to show the compiler "the light" _*WITHOUT RESORTING TO
  EXTRA CFLAGS*_.

Evgeny, I know that you have probably forgotten more about C than I'll
ever know, but lets not just give in on this and hide things behind
CFLAGS or anything else.

As a complete novice where C is concerned, I view _any_ warning as
bad.  I'm not a novice where elisp is concerned, and I view _any_
warning as bad.  I honestly believe that all software should compile
totally error and warning free.


-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                        In space,                         |
|             No one can hear you rip a stinky             |
|------------------------------------<steve@xxxxxxxxxxx>---|

Attachment: pgpih79GInOGJ.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>