sxemacs-devel
[Top] [All Lists]

Re: sxemacs--ckent--22.1.0--patch-1

From: Steve Youngs <steve@xxxxxxxxxxx>
Subject: Re: sxemacs--ckent--22.1.0--patch-1
Date: Mon, 20 Dec 2004 09:38:57 +1000
Organization: The SXEmacs Project
User-agent: Gnus/5.110003 (No Gnus v0.3) sxemacs/22.1
* Zajcev Evgeny <zevlg@xxxxxxxxx> writes:

  > Steve Youngs <steve@xxxxxxxxxxx> writes:
  >> >  (defvar preloaded-file-list nil
  >> > -  "List of files preloaded into the XEmacs binary image.")
  >> > +  "List of files preloaded into the SXEmacs binary image.")
  >> 
  >> >  (defvar Installation-string nil
  >> >    "Description of XEmacs installation.")
  >> > @@ -268,20 +268,20 @@
  >> 
  >> >  ;(loadup-profile-results nil 'external-debugging-output)
  >> 
  >> > -;; Dump into the name `xemacs' (only)
  >> > +;; Dump into the name `sxemacs' (only)
  >> >  (when (member "dump" command-line-args)
  >> > -  (message "Dumping under the name xemacs")
  >> > +  (message "Dumping under the name sxemacs")
  >> >    ;; This is handled earlier in the build process.
  >> > -  ;; (condition-case () (delete-file "xemacs") (file-error nil))
  >> > +  ;; (condition-case () (delete-file "sxemacs") (file-error nil))
  >> >    (when (fboundp 'really-free)
  >> >      (really-free))
  >> >    (dump-emacs
  >> >     (cond
  >> >      ((featurep 'infodock) "infodock")
  >> >      ;; #### BILL!!!
  >> > -    ;; If we want to dump under a name other than `xemacs', do that 
here!
  >> > -    ;; ((featurep 'gtk) "xemacs-gtk")
  >> > -    (t "xemacs"))
  >> > +    ;; If we want to dump under a name other than `sxemacs', do that 
here!
  >> > +    ;; ((featurep 'gtk) "sxemacs-gtk")
  >> > +    (t "sxemacs"))
  >> >     "temacs")
  >> >    (kill-emacs))
  >> 
  >> This part is fine.  But I wonder why I haven't had any problems in the
  >> area with building?

  > Actually the only useful part of this patch is this part. :)  As i
  > understood you've accepted it?

Yes.  But I haven't applied anything because I imaging that this would
be in your^WClark's patch-3, right?

  > Other parts was just automitally changed by hands, and in head
  > repeating:  "Change all xemacs to sxemacs, change all xemacs to
  > sxemacs, change all xemacs to sxemacs".

Hehe, subliminal hacking. :-P

  >> Evgeny, the best way to redo this would be...
  >> 
  >> $ tla replay --reverse patch-1 RET
  >> $ tla commit -s "reverting patch-1" RET
  >> 
  >> ...and then start hacking again.
  >> 
  >> Thanks, Evgeny.  I'm looking forward to seeing a merge request for
  >> sxemacs--ckent--22.1.0--patch-3. :-)
  >> 

  > Great!  I'll say it Clark.

Super! :-)

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                        In space,                         |
|             No one can hear you rip a stinky             |
|------------------------------------<steve@xxxxxxxxxxx>---|

Attachment: pgpZ2ODQET3Hk.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>