sxemacs-devel
[Top] [All Lists]

Re: [MERGE-REQ] hroptatyr@xxxxxxxxxxxxxxxxxxxx/sxemacs--hrop--22.1.1--pa

From: Steve Youngs <steve@xxxxxxxxxxx>
Subject: Re: [MERGE-REQ] hroptatyr@xxxxxxxxxxxxxxxxxxxx/sxemacs--hrop--22.1.1--patch-5
Date: Tue, 18 Jan 2005 09:59:29 +1000
Organization: The SXEmacs Project
User-agent: Gnus/5.110003 (No Gnus v0.3) SXEmacs/22.1.1 (Aston Martin, linux)
[moved to -devel for discussion]

* Sebastian Freundt <hroptatyr@xxxxxxxxxxx> writes:

  >       sxemacs--hrop--22.1.1--patch-5

A few problems with this...

  >     * etc/sxemacs.xpm: new
    
  >     * etc/sxemacs-beta.xpm: new

They aren't really "new" are they?

  >     modified files:
  >      etc/sxemacs-beta.xpm etc/sxemacs.xpm

You had some conflicts and didn't resolve them before you committed.
Only sxemacs.xpm is actually modified in this patch.

But anyway...

sxemacs.xpm is now horrible.  The background grid is as ugly as a hat
full of arseholes!  Sebastian, did you view the new .xpm file in
SXEmacs _before_ committing it? [1]

That grid has a very important role, it helps to give the hot pink
"SXEmacs" some depth and perspective.  But, and this is a big _BUT_,
the grid should _NOT_ attract your eye.  The way it is now, your eye
is drawn to the flaws in the grid.

Sebastian, do you understand what I am trying to say?  Can you fix it?


Footnotes: 
[1]  Although, I should keep quiet, I committed it before looking at
     it...

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                        In space,                         |
|             No one can hear you rip a stinky             |
|------------------------------------<steve@xxxxxxxxxxx>---|

Attachment: pgpnwzIJnfYQn.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [MERGE-REQ] hroptatyr@xxxxxxxxxxxxxxxxxxxx/sxemacs--hrop--22.1.1--patch-5, Steve Youngs <=